[JENKINS-32535] Improved test coverage 'add-job-to-view' and 'remove-job-from-view'

test/pom.xml

@@ -63,7 +63,7 @@ THE SOFTWARE.
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>jenkins-test-harness</artifactId>
-      <version>2.5</version>
+      <version>2.6</version>
       <scope>test</scope>
       <exclusions>
         <exclusion>

test/src/test/java/hudson/cli/AddJobToViewCommandTest.java

+/*
+ * The MIT License
+ *
+ * Copyright 2016 Red Hat, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+package hudson.cli;
+
+import hudson.model.DirectlyModifiableView;
+import hudson.model.FreeStyleProject;
+import hudson.model.Job;
+import hudson.model.ListView;
+import hudson.model.View;
+import jenkins.model.Jenkins;
+import org.junit.Before;
+import org.junit.Test;
+
+import static hudson.cli.CLICommandInvoker.Matcher.succeededSilently;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.equalTo;
+
+/**
+ * @author pjanouse
+ */
+public class AddJobToViewCommandTest extends ViewManipulationTestBase {
+
+    @Override
+    public CLICommandInvoker getCommand() {
+        return new CLICommandInvoker(j, "add-job-to-view");
+    }
+
+    @Test public void addJobShouldSucceed() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project = j.createFreeStyleProject("aProject");
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(false));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject");
+
+        assertThat(result, succeededSilently());
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(1));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(true));
+    }
+
+    @Test public void addJobShouldSucceedEvenAlreadyAdded () throws Exception {
+
+        FreeStyleProject project = j.createFreeStyleProject("aProject");
+
+        j.jenkins.addView(new ListView("aView"));
+        ((DirectlyModifiableView) j.jenkins.getView("aView")).add(project);
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(1));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(true));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject");
+
+        assertThat(result, succeededSilently());
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(1));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(true));
+    }
+
+    @Test public void addJobManyShouldSucceed() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project1 = j.createFreeStyleProject("aProject1");
+        FreeStyleProject project2 = j.createFreeStyleProject("aProject2");
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(false));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject1", "aProject2");
+
+        assertThat(result, succeededSilently());
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(2));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(true));
+        assertThat(j.jenkins.getView("aView").contains(project2 ), equalTo(true));
+    }
+
+    @Test public void addJobManyShouldSucceedEvenAJobIsSpecifiedTwice() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project = j.createFreeStyleProject("aProject");
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(false));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject", "aProject");
+
+        assertThat(result, succeededSilently());
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(1));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(true));
+    }
+
+}

test/src/test/java/hudson/cli/RemoveJobFromViewCommandTest.java

+/*
+ * The MIT License
+ *
+ * Copyright 2016 Red Hat, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+package hudson.cli;
+
+import hudson.model.DirectlyModifiableView;
+import hudson.model.FreeStyleProject;
+import hudson.model.Job;
+import hudson.model.ListView;
+import hudson.model.View;
+import jenkins.model.Jenkins;
+import org.junit.Before;
+import org.junit.Test;
+
+import static hudson.cli.CLICommandInvoker.Matcher.succeededSilently;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.equalTo;
+
+/**
+ * @author pjanouse
+ */
+public class RemoveJobFromViewCommandTest extends ViewManipulationTestBase {
+
+    @Override
+    public CLICommandInvoker getCommand() {
+        return new CLICommandInvoker(j, "remove-job-from-view");
+    }
+
+    @Test public void removeJobShouldSucceed() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project = j.createFreeStyleProject("aProject");
+        ((DirectlyModifiableView) j.jenkins.getView("aView")).add(project);
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(1));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(true));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject");
+
+        assertThat(result, succeededSilently());
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(false));
+    }
+
+    @Test public void removeJobManyShouldSucceed() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project1 = j.createFreeStyleProject("aProject1");
+        FreeStyleProject project2 = j.createFreeStyleProject("aProject2");
+        ((DirectlyModifiableView) j.jenkins.getView("aView")).add(project1);
+        ((DirectlyModifiableView) j.jenkins.getView("aView")).add(project2);
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(2));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(true));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(true));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject1", "aProject2");
+
+        assertThat(result, succeededSilently());
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2 ), equalTo(false));
+    }
+
+    @Test public void removeJobManyShouldSucceedEvenAJobIsSpecifiedTwice() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project = j.createFreeStyleProject("aProject");
+        ((DirectlyModifiableView) j.jenkins.getView("aView")).add(project);
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(1));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(true));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject", "aProject");
+
+        assertThat(result, succeededSilently());
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(false));
+    }
+
+}

test/src/test/java/hudson/cli/ViewManipulationTest.java

-/*
- * The MIT License
- *
- * Copyright (c) 2014 Red Hat, Inc.
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
- * THE SOFTWARE.
- */
-package hudson.cli;
-
-import static org.junit.Assert.*;
-import static hudson.cli.CLICommandInvoker.Matcher.*;
-import static org.hamcrest.Matchers.*;
-
-import jenkins.model.Jenkins;
-import hudson.cli.CLICommandInvoker.Result;
-import hudson.model.FreeStyleProject;
-import hudson.model.Job;
-import hudson.model.ListView;
-import hudson.model.View;
-
-import org.junit.Rule;
-import org.junit.Test;
-import org.jvnet.hudson.test.JenkinsRule;
-
-public class ViewManipulationTest {
-
-    @Rule public final JenkinsRule j = new JenkinsRule();
-
-    private Result res;
-
-    @Test
-    public void addJobToView() throws Exception {
-        ListView view = new ListView("a_view");
-        j.jenkins.addView(view);
-        FreeStyleProject inView = j.createFreeStyleProject("in_view");
-        FreeStyleProject inView2 = j.createFreeStyleProject("in_view2");
-        FreeStyleProject notInView = j.createFreeStyleProject("not_in_view");
-
-        res = add().invokeWithArgs("a_view", "in_view", "in_view2");
-        assertThat(res, succeededSilently());
-
-        assertTrue(view.contains(inView));
-        assertTrue(view.contains(inView2));
-        assertFalse(view.contains(notInView));
-    }
-
-    @Test
-    public void removeJobFromView() throws Exception {
-        ListView view = new ListView("a_view");
-        j.jenkins.addView(view);
-        FreeStyleProject inView = j.createFreeStyleProject("in_view");
-        FreeStyleProject removed = j.createFreeStyleProject("removed");
-        FreeStyleProject removed2 = j.createFreeStyleProject("removed2");
-        view.add(inView);
-        view.add(removed);
-        view.add(removed2);
-
-        res = remove().invokeWithArgs("a_view", "removed", "removed2");
-        assertThat(res, succeededSilently());
-
-        assertTrue(view.contains(inView));
-        assertFalse(view.contains(removed));
-        assertFalse(view.contains(removed2));
-    }
-
-    @Test
-    public void failIfTheViewIsNotDirectlyModifiable() throws Exception {
-        j.createFreeStyleProject("a_project");
-
-        res = add().invokeWithArgs("All", "a_project");
-        assertThat(res, failedWith(4));
-        assertThat(res.stderr(), containsString("ERROR: 'All' view can not be modified directly"));
-
-        res = remove().invokeWithArgs("All", "a_project");
-        assertThat(res, failedWith(4));
-        assertThat(res.stderr(), containsString("ERROR: 'All' view can not be modified directly"));
-    }
-
-    @Test
-    public void failIfUserNotAuthorizedToConfigure() throws Exception {
-        ListView view = new ListView("a_view");
-        j.jenkins.addView(view);
-        j.createFreeStyleProject("a_project");
-
-        res = add().authorizedTo(Jenkins.READ, Job.READ, View.READ).invokeWithArgs("a_view", "a_project");
-        assertThat(res, failedWith(6));
-        assertThat(res.stderr(), containsString("ERROR: user is missing the View/Configure permission"));
-
-        res = remove().authorizedTo(Jenkins.READ, Job.READ, View.READ).invokeWithArgs("a_view", "a_project");
-        assertThat(res, failedWith(6));
-        assertThat(res.stderr(), containsString("ERROR: user is missing the View/Configure permission"));
-    }
-
-    private CLICommandInvoker add() {
-        return new CLICommandInvoker(j, new AddJobToViewCommand());
-    }
-
-    private CLICommandInvoker remove() {
-        return new CLICommandInvoker(j, new RemoveJobFromViewCommand());
-    }
-}

test/src/test/java/hudson/cli/ViewManipulationTestBase.java

+/*
+ * The MIT License
+ *
+ * Copyright 2016 Red Hat, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+package hudson.cli;
+
+import hudson.model.FreeStyleProject;
+import hudson.model.Job;
+import hudson.model.ListView;
+import hudson.model.View;
+import jenkins.model.Jenkins;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.jvnet.hudson.test.JenkinsRule;
+
+import java.io.IOException;
+
+import static hudson.cli.CLICommandInvoker.Matcher.failedWith;
+import static hudson.cli.CLICommandInvoker.Matcher.hasNoStandardOutput;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.Matchers.equalTo;
+
+/**
+ * @author pjanouse
+ */
+public abstract class ViewManipulationTestBase {
+
+    protected CLICommandInvoker command;
+
+    abstract CLICommandInvoker getCommand();
+
+    @Rule public final JenkinsRule j = new JenkinsRule();
+
+    @Before public void setUp() {
+        command = getCommand();
+    }
+
+    @Test public void jobViewManipulationShouldFailWithJenkinsReadPermissionOnly() throws IOException {
+
+        j.jenkins.addView(new ListView("aView"));
+        j.createFreeStyleProject("aProject");
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ)
+                .invokeWithArgs("aView", "aProject");
+
+        assertThat(result, failedWith(6));
+        assertThat(result, hasNoStandardOutput());
+        assertThat(result.stderr(), containsString("ERROR: user is missing the View/Read permission"));
+    }
+
+    @Test public void jobViewManipulationShouldFailWithViewReadPermissionOnly() throws IOException {
+
+        j.jenkins.addView(new ListView("aView"));
+        j.createFreeStyleProject("aProject");
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ)
+                .invokeWithArgs("aView", "aProject");
+
+        assertThat(result, failedWith(3));
+        assertThat(result, hasNoStandardOutput());
+        assertThat(result.stderr(), containsString("ERROR: No such job 'aProject'"));
+    }
+
+    @Test public void jobViewManipulationShouldFailWithViewReadAndJobReadPermissionsOnly() throws IOException {
+
+        j.jenkins.addView(new ListView("aView"));
+        j.createFreeStyleProject("aProject");
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ)
+                .invokeWithArgs("aView", "aProject");
+
+        assertThat(result, failedWith(6));
+        assertThat(result, hasNoStandardOutput());
+        assertThat(result.stderr(), containsString("ERROR: user is missing the View/Configure permission"));
+    }
+
+    @Test public void jobViewManipulationShouldFailIfTheViewIsNotDirectlyModifiable() throws Exception {
+
+        FreeStyleProject project = j.createFreeStyleProject("aProject");
+
+        assertThat(j.jenkins.getView("All").getAllItems().size(), equalTo(1));
+        assertThat(j.jenkins.getView("All").contains(project), equalTo(true));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("All", "aProject");
+
+        assertThat(result, failedWith(4));
+        assertThat(result.stderr(), containsString("ERROR: 'All' view can not be modified directly"));
+        assertThat(j.jenkins.getView("All").getAllItems().size(), equalTo(1));
+        assertThat(j.jenkins.getView("All").contains(project), equalTo(true));
+    }
+
+    @Test public void jobViewManipulationShouldFailIfTheJobDoesNotExist() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+
+        CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "never_created");
+
+        assertThat(result, failedWith(3));
+        assertThat(result.stderr(), containsString("ERROR: No such job 'never_created'"));
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+
+        FreeStyleProject project = j.createFreeStyleProject("aProject");
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+
+        result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject1");
+
+        assertThat(result, failedWith(3));
+        assertThat(result.stderr(), containsString("ERROR: No such job 'aProject1'; perhaps you meant 'aProject'?"));
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project), equalTo(false));
+    }
+
+    @Test public void jobViewManipulationShouldFailIfTheJobNameIsEmpty() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "");
+
+        assertThat(result, failedWith(3));
+        assertThat(result.stderr(), containsString("ERROR: No such job ''"));
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+    }
+
+    @Test public void jobViewManipulationManyShouldFailIfFirstJobDoesNotExist() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project1 = j.createFreeStyleProject("aProject1");
+        FreeStyleProject project2 = j.createFreeStyleProject("aProject2");
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(false));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "never_created", "aProject1", "aProject2");
+
+        assertThat(result, failedWith(3));
+        assertThat(result.stderr(), containsString("ERROR: No such job 'never_created'; perhaps you meant 'aProject1'?"));
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(false));
+    }
+
+    @Test public void jobViewManipulationManyShouldFailIfMiddleJobDoesNotExist() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project1 = j.createFreeStyleProject("aProject1");
+        FreeStyleProject project2 = j.createFreeStyleProject("aProject2");
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(false));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject1", "never_created", "aProject2");
+
+        assertThat(result, failedWith(3));
+        assertThat(result.stderr(), containsString("ERROR: No such job 'never_created'; perhaps you meant 'aProject1'?"));
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(false));
+    }
+
+    @Test public void jobViewManipulationManyShouldFailIfLastJobDoesNotExist() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project1 = j.createFreeStyleProject("aProject1");
+        FreeStyleProject project2 = j.createFreeStyleProject("aProject2");
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(false));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject1", "aProject2", "never_created");
+
+        assertThat(result, failedWith(3));
+        assertThat(result.stderr(), containsString("ERROR: No such job 'never_created'; perhaps you meant 'aProject1'?"));
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(false));
+    }
+
+    @Test public void jobViewManipulationManyShouldFailIfMoreJobsDoNotExist() throws Exception {
+
+        j.jenkins.addView(new ListView("aView"));
+        FreeStyleProject project1 = j.createFreeStyleProject("aProject1");
+        FreeStyleProject project2 = j.createFreeStyleProject("aProject2");
+
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(false));
+
+        final CLICommandInvoker.Result result = command
+                .authorizedTo(Jenkins.READ, View.READ, Job.READ, View.CONFIGURE)
+                .invokeWithArgs("aView", "aProject1", "never_created", "aProject2", "never_created");
+
+        assertThat(result, failedWith(3));
+        assertThat(result.stderr(), containsString("ERROR: No such job 'never_created'; perhaps you meant 'aProject1'?"));
+        assertThat(j.jenkins.getView("aView").getAllItems().size(), equalTo(0));
+        assertThat(j.jenkins.getView("aView").contains(project1), equalTo(false));
+        assertThat(j.jenkins.getView("aView").contains(project2), equalTo(false));
+    }
+
+}