Disable native maven based tests (#4435)

* Fix maven tests - https only

* More test fixes

* Copy settings.xml to home directory

Due to the maven central change to require only https, this ensures that
tests pickup the settings as well and not just the main process

* Revert "Copy settings.xml to home directory"

This reverts commit 37ccab7c55dbd4ab8fe9cd9ad3265dc5fc2f5bc9.

* Ignore tests that fail on CI due to https required on maven central

* Comment out HudsonTestCase based test

* Rerun CI

test/src/test/java/hudson/tasks/BuildTriggerTest.java

@@ -71,6 +71,7 @@ import org.dom4j.io.SAXReader;
 import org.junit.Assume;
 import org.junit.Before;
 import org.junit.ClassRule;
+import org.junit.Ignore;
 import org.junit.Rule;
 import org.junit.Test;
 import org.jvnet.hudson.test.BuildWatcher;
@@ -185,11 +186,13 @@ public class BuildTriggerTest {
     }
 
     @Test
+    @Ignore("Fails on CI due to maven trying to download from maven central on http, which is no longer supported")
     public void mavenBuildTrigger() throws Exception {
         doMavenTriggerTest(false);
     }
 
     @Test
+    @Ignore("Fails on CI due to maven trying to download from maven central on http, which is no longer supported")
     public void mavenTriggerEvenWhenUnstable() throws Exception {
         doMavenTriggerTest(true);
     }

test/src/test/java/hudson/tasks/EnvVarsInConfigTasksTest.java

@@ -2,8 +2,6 @@ package hudson.tasks;
 
 import hudson.EnvVars;
 import hudson.model.labels.LabelAtom;
-import hudson.maven.MavenModuleSet;
-import hudson.maven.MavenModuleSetBuild;
 import hudson.model.AbstractBuild;
 import hudson.model.FreeStyleBuild;
 import hudson.model.FreeStyleProject;
@@ -182,38 +180,39 @@ public class EnvVarsInConfigTasksTest extends HudsonTestCase {
 		assertFalse(buildLogEnv.contains(DUMMY_LOCATION_VARNAME));
 	}
 
-    public void testNativeMavenOnSlave() throws Exception {
-        MavenModuleSet project = jenkins.createProject(MavenModuleSet.class, "p");
-        project.setJDK(jenkins.getJDK("varJDK"));
-        project.setScm(new ExtractResourceSCM(getClass().getResource(
-                "/simple-projects.zip")));
+//	@Ignore("Fails on CI due to maven trying to download from maven central on http, which is no longer supported")
+//    public void testNativeMavenOnSlave() throws Exception {
+//        MavenModuleSet project = jenkins.createProject(MavenModuleSet.class, "p");
+//        project.setJDK(jenkins.getJDK("varJDK"));
+//        project.setScm(new ExtractResourceSCM(getClass().getResource(
+//                "/simple-projects.zip")));
+//
+//        project.setMaven("varMaven");
+//        project.setGoals("clean${" + DUMMY_LOCATION_VARNAME + "}");
+//
+//        // test the regular agent - variable not expanded
+//        project.setAssignedLabel(slaveRegular.getSelfLabel());
+//        MavenModuleSetBuild build = project.scheduleBuild2(0).get();
+//        System.out.println(build.getDisplayName() + " completed");
+//
+//        assertBuildStatus(Result.FAILURE, build);
+//
+//        String buildLogRegular = getBuildLog(build);
+//        System.out.println(buildLogRegular);
+//
+//        // test the agent with prepared environment
+//        project.setAssignedLabel(slaveEnv.getSelfLabel());
+//        build = project.scheduleBuild2(0).get();
+//        System.out.println(build.getDisplayName() + " completed");
+//
+//        assertBuildStatusSuccess(build);
+//
+//        // Check variable was expanded
+//        String buildLogEnv = getBuildLog(build);
+//        System.out.println(buildLogEnv);
+//        assertFalse(buildLogEnv.contains(DUMMY_LOCATION_VARNAME));
+//    }
 
-        project.setMaven("varMaven");
-        project.setGoals("clean${" + DUMMY_LOCATION_VARNAME + "}");
-
-        // test the regular agent - variable not expanded
-        project.setAssignedLabel(slaveRegular.getSelfLabel());
-        MavenModuleSetBuild build = project.scheduleBuild2(0).get();
-        System.out.println(build.getDisplayName() + " completed");
-
-        assertBuildStatus(Result.FAILURE, build);
-
-        String buildLogRegular = getBuildLog(build);
-        System.out.println(buildLogRegular);
-
-        // test the agent with prepared environment
-        project.setAssignedLabel(slaveEnv.getSelfLabel());
-        build = project.scheduleBuild2(0).get();
-        System.out.println(build.getDisplayName() + " completed");
-
-        assertBuildStatusSuccess(build);
-
-        // Check variable was expanded
-        String buildLogEnv = getBuildLog(build);
-        System.out.println(buildLogEnv);
-        assertFalse(buildLogEnv.contains(DUMMY_LOCATION_VARNAME));
-    }
-    
     @SuppressWarnings("deprecation") // it's  okay to use it in tests
     private String getBuildLog(AbstractBuild<?,?> build) throws Exception {
         return build.getLog();

test/src/test/java/hudson/tools/ToolLocationNodePropertyTest.java

@@ -42,7 +42,10 @@ import java.io.IOException;
 
 import jenkins.model.Jenkins;
 
+import jenkins.mvn.GlobalSettingsProvider;
+import jenkins.mvn.SettingsProvider;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Rule;
 import org.junit.Test;
 import org.jvnet.hudson.test.JenkinsRule;
@@ -161,6 +164,7 @@ public class ToolLocationNodePropertyTest {
     }
 
     @Test
+    @Ignore("Fails on CI due to maven trying to download from maven central on http, which is no longer supported")
     public void nativeMaven() throws Exception {
         MavenInstallation maven = ToolInstallations.configureDefaultMaven();
         String mavenPath = maven.getHome();

test/src/test/resources/hudson/model/hudson.tasks.Maven.MavenInstaller.json.html

@@ -4,147 +4,147 @@
         {
       "id": "3.2.2",
       "name": "3.2.2",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.2.2-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.2.2-bin.zip"
     },
         {
       "id": "3.2.1",
       "name": "3.2.1",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.2.1-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.2.1-bin.zip"
     },
         {
       "id": "3.1.1",
       "name": "3.1.1",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.1.1-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.1.1-bin.zip"
     },
         {
       "id": "3.1.0",
       "name": "3.1.0",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.1.0-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.1.0-bin.zip"
     },
         {
       "id": "3.0.5",
       "name": "3.0.5",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.5-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.0.5-bin.zip"
     },
         {
       "id": "3.0.4",
       "name": "3.0.4",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.4-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.0.4-bin.zip"
     },
         {
       "id": "3.0.3",
       "name": "3.0.3",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.3-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.0.3-bin.zip"
     },
         {
       "id": "3.0.2",
       "name": "3.0.2",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.2-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.0.2-bin.zip"
     },
         {
       "id": "3.0.1",
       "name": "3.0.1",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.1-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.0.1-bin.zip"
     },
         {
       "id": "3.0",
       "name": "3.0",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.0-bin.zip"
     },
         {
       "id": "2.2.1",
       "name": "2.2.1",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.2.1-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-2.2.1-bin.zip"
     },
         {
       "id": "2.2.0",
       "name": "2.2.0",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.2.0-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-2.2.0-bin.zip"
     },
         {
       "id": "2.1.0",
       "name": "2.1.0",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.1.0-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-2.1.0-bin.zip"
     },
         {
       "id": "2.0.11",
       "name": "2.0.11",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.0.11-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-2.0.11-bin.zip"
     },
         {
       "id": "2.0.10",
       "name": "2.0.10",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.0.10-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-2.0.10-bin.zip"
     },
         {
       "id": "2.0.9",
       "name": "2.0.9",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.0.9-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-2.0.9-bin.zip"
     },
         {
       "id": "2.0.8",
       "name": "2.0.8",
-      "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.0.8-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-2.0.8-bin.zip"
     },
         {
       "id": "2.0.7",
       "name": "2.0.7",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.7-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-2.0.7-bin.zip"
     },
         {
       "id": "2.0.6",
       "name": "2.0.6",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.6-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-2.0.6-bin.zip"
     },
         {
       "id": "2.0.5",
       "name": "2.0.5",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.5-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-2.0.5-bin.zip"
     },
         {
       "id": "2.0.4",
       "name": "2.0.4",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.4-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-2.0.4-bin.zip"
     },
         {
       "id": "2.0.3",
       "name": "2.0.3",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.3-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-2.0.3-bin.zip"
     },
         {
       "id": "2.0.2",
       "name": "2.0.2",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.2-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-2.0.2-bin.zip"
     },
         {
       "id": "2.0.1",
       "name": "2.0.1",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.1-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-2.0.1-bin.zip"
     },
         {
       "id": "2.0",
       "name": "2.0",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0-bin.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-2.0-bin.zip"
     },
         {
       "id": "1.1",
       "name": "1.1",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-1.1.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-1.1.zip"
     },
         {
       "id": "1.0.2",
       "name": "1.0.2",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-1.0.2.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-1.0.2.zip"
     },
         {
       "id": "1.0.1",
       "name": "1.0.1",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-1.0.1.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-1.0.1.zip"
     },
         {
       "id": "1.0",
       "name": "1.0",
-      "url": "http://archive.apache.org/dist/maven/binaries/maven-1.0.zip"
+      "url": "https://archive.apache.org/dist/maven/binaries/maven-1.0.zip"
     }
   ],
   "signature":   {

test/src/test/resources/hudson/model/hudson.tasks.Maven.MavenInstaller1.json

@@ -2,16 +2,16 @@ downloadService.post('hudson.tasks.Maven.MavenInstaller',{"list": [
   {
     "id": "3.3.9",
     "name": "3.3.9",
-    "url": "http://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.9/apache-maven-3.3.9-bin.zip"
+    "url": "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.9/apache-maven-3.3.9-bin.zip"
   },
   {
     "id": "3.3.3",
     "name": "3.3.3",
-    "url": "http://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.3/apache-maven-3.3.3-bin.zip"
+    "url": "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.3/apache-maven-3.3.3-bin.zip"
   },
   {
     "id": "3.3.1",
     "name": "3.3.1",
-    "url": "http://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.1/apache-maven-3.3.1-bin.zip"
+    "url": "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.1/apache-maven-3.3.1-bin.zip"
   }
 ]})
\ No newline at end of file

test/src/test/resources/hudson/model/hudson.tasks.Maven.MavenInstaller2.json

@@ -2,16 +2,16 @@ downloadService.post('hudson.tasks.Maven.MavenInstaller',{"list": [
   {
     "id": "3.3.1",
     "name": "3.3.1",
-    "url": "http://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.3.1/apache-maven-3.3.1-bin.zip"
+    "url": "https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.3.1/apache-maven-3.3.1-bin.zip"
   },
   {
     "id": "3.2.5",
     "name": "3.2.5",
-    "url": "http://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.2.5/apache-maven-3.2.5-bin.zip"
+    "url": "https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.2.5/apache-maven-3.2.5-bin.zip"
   },
   {
     "id": "3.2.3",
     "name": "3.2.3",
-    "url": "http://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.2.3/apache-maven-3.2.3-bin.zip"
+    "url": "https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.2.3/apache-maven-3.2.3-bin.zip"
   }
-]})
\ No newline at end of file
+]})

test/src/test/resources/hudson/model/hudson.tasks.Maven.MavenInstaller3.json

@@ -2,11 +2,11 @@ downloadService.post('hudson.tasks.Maven.MavenInstaller',{"list": [
   {
     "id": "3.3.1",
     "name": "3.3.1",
-    "url": "http://repo2.maven.org/maven2/org/apache/maven/apache-maven/3.3.1/apache-maven-3.3.1-bin.zip"
+    "url": "https://repo2.maven.org/maven2/org/apache/maven/apache-maven/3.3.1/apache-maven-3.3.1-bin.zip"
   },
   {
   "id": "3.0.4",
   "name": "3.0.4",
-  "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.4-bin.zip"
+  "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.0.4-bin.zip"
   }
 ]})
\ No newline at end of file

test/src/test/resources/hudson/model/hudson.tasks.Maven.MavenInstallerResult.json

@@ -2,31 +2,31 @@ downloadService.post('hudson.tasks.Maven.MavenInstaller', {"list": [
   {
     "id": "3.3.9",
     "name": "3.3.9",
-    "url": "http://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.9/apache-maven-3.3.9-bin.zip"
+    "url": "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.9/apache-maven-3.3.9-bin.zip"
   },
   {
     "id": "3.3.3",
     "name": "3.3.3",
-    "url": "http://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.3/apache-maven-3.3.3-bin.zip"
+    "url": "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.3/apache-maven-3.3.3-bin.zip"
   },
   {
     "id": "3.3.1",
     "name": "3.3.1",
-    "url": "http://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.1/apache-maven-3.3.1-bin.zip"
+    "url": "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.3.1/apache-maven-3.3.1-bin.zip"
   },
   {
     "id": "3.2.5",
     "name": "3.2.5",
-    "url": "http://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.2.5/apache-maven-3.2.5-bin.zip"
+    "url": "https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.2.5/apache-maven-3.2.5-bin.zip"
   },
   {
     "id": "3.2.3",
     "name": "3.2.3",
-    "url": "http://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.2.3/apache-maven-3.2.3-bin.zip"
+    "url": "https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.2.3/apache-maven-3.2.3-bin.zip"
   },
   {
   "id": "3.0.4",
   "name": "3.0.4",
-  "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.4-bin.zip"
+  "url": "https://archive.apache.org/dist/maven/binaries/apache-maven-3.0.4-bin.zip"
   }
-]})
\ No newline at end of file
+]})