提交 6c2fffb2 编写于 作者: O Oleg Nenashev

Fixed annotations in hudson/Util.java according to the discussion with @jglick and @kutzi

Signed-off-by: NOleg Nenashev <o.v.nenashev@gmail.com>
上级 48cc7e03
...@@ -75,6 +75,7 @@ import static hudson.util.jna.GNUCLibrary.LIBC; ...@@ -75,6 +75,7 @@ import static hudson.util.jna.GNUCLibrary.LIBC;
import java.security.DigestInputStream; import java.security.DigestInputStream;
import javax.annotation.CheckForNull; import javax.annotation.CheckForNull;
import javax.annotation.Nonnull; import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import org.apache.commons.codec.digest.DigestUtils; import org.apache.commons.codec.digest.DigestUtils;
/** /**
...@@ -126,7 +127,7 @@ public class Util { ...@@ -126,7 +127,7 @@ public class Util {
* Unlike shell, undefined variables are left as-is (this behavior is the same as Ant.) * Unlike shell, undefined variables are left as-is (this behavior is the same as Ant.)
* *
*/ */
@CheckForNull @Nullable
public static String replaceMacro( @CheckForNull String s, @Nonnull Map<String,String> properties) { public static String replaceMacro( @CheckForNull String s, @Nonnull Map<String,String> properties) {
return replaceMacro(s,new VariableResolver.ByMap<String>(properties)); return replaceMacro(s,new VariableResolver.ByMap<String>(properties));
} }
...@@ -137,7 +138,7 @@ public class Util { ...@@ -137,7 +138,7 @@ public class Util {
* <p> * <p>
* Unlike shell, undefined variables are left as-is (this behavior is the same as Ant.) * Unlike shell, undefined variables are left as-is (this behavior is the same as Ant.)
*/ */
@CheckForNull @Nullable
public static String replaceMacro(@CheckForNull String s, @Nonnull VariableResolver<String> resolver) { public static String replaceMacro(@CheckForNull String s, @Nonnull VariableResolver<String> resolver) {
if (s == null) { if (s == null) {
return null; return null;
...@@ -548,7 +549,7 @@ public class Util { ...@@ -548,7 +549,7 @@ public class Util {
* case subject was null and subject + suffix otherwise. * case subject was null and subject + suffix otherwise.
* @since 1.505 * @since 1.505
*/ */
@CheckForNull @Nullable
public static String ensureEndsWith(@CheckForNull String subject, @CheckForNull String suffix) { public static String ensureEndsWith(@CheckForNull String subject, @CheckForNull String suffix) {
if (subject == null) return null; if (subject == null) return null;
...@@ -1410,8 +1411,9 @@ public class Util { ...@@ -1410,8 +1411,9 @@ public class Util {
/** /**
* Null-safe String intern method. * Null-safe String intern method.
* @return A canonical representation for the string object. Null for null input strings
*/ */
@CheckForNull @Nullable
public static String intern(@CheckForNull String s) { public static String intern(@CheckForNull String s) {
return s==null ? s : s.intern(); return s==null ? s : s.intern();
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册