Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
LinuxSuRen
jenkins
提交
4d754c49
J
jenkins
项目概览
LinuxSuRen
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
4d754c49
编写于
12月 02, 2015
作者:
C
chris.arnott@softwire.com
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
JENKINS-29059: Update to use FormValidation.aggregate()
上级
cbf46fc3
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
12 addition
and
267 deletion
+12
-267
core/src/main/java/hudson/triggers/TimerTrigger.java
core/src/main/java/hudson/triggers/TimerTrigger.java
+12
-18
core/src/main/java/hudson/util/ResponseObject.java
core/src/main/java/hudson/util/ResponseObject.java
+0
-67
test/src/test/java/hudson/util/ResponseObjectTest.java
test/src/test/java/hudson/util/ResponseObjectTest.java
+0
-182
未找到文件。
core/src/main/java/hudson/triggers/TimerTrigger.java
浏览文件 @
4d754c49
...
...
@@ -34,8 +34,10 @@ import hudson.scheduler.CronTabList;
import
hudson.scheduler.Hash
;
import
hudson.util.FormValidation
;
import
java.text.DateFormat
;
import
java.util.ArrayList
;
import
java.util.Calendar
;
import
hudson.util.ResponseObject
;
import
java.util.Collection
;
import
org.kohsuke.stapler.AncestorInPath
;
import
org.kohsuke.stapler.DataBoundConstructor
;
import
org.kohsuke.stapler.QueryParameter
;
...
...
@@ -84,14 +86,10 @@ public class TimerTrigger extends Trigger<BuildableItem> {
public
FormValidation
doCheckSpec
(
@QueryParameter
String
value
,
@AncestorInPath
Item
item
)
{
try
{
CronTabList
ctl
=
CronTabList
.
create
(
fixNull
(
value
),
item
!=
null
?
Hash
.
from
(
item
.
getFullName
())
:
null
);
ResponseObject
response
=
new
ResponseObject
();
response
=
getResponseForSanity
(
response
,
ctl
);
response
=
getResponseForNextRun
(
response
,
ctl
);
if
(
response
.
hasWarning
())
{
return
FormValidation
.
warning
(
response
.
getWarningAndMessge
());
}
else
{
return
FormValidation
.
ok
(
response
.
getMessage
());
}
Collection
<
FormValidation
>
validations
=
new
ArrayList
<>();
updateValidationsForSanity
(
validations
,
ctl
);
updateValidationsForNextRun
(
validations
,
ctl
);
return
FormValidation
.
aggregate
(
validations
);
}
catch
(
ANTLRException
e
)
{
if
(
value
.
trim
().
indexOf
(
'\n'
)==-
1
&&
value
.
contains
(
"**"
))
return
FormValidation
.
error
(
Messages
.
TimerTrigger_MissingWhitespace
());
...
...
@@ -99,23 +97,19 @@ public class TimerTrigger extends Trigger<BuildableItem> {
}
}
private
ResponseObject
getResponseForSanity
(
ResponseObject
response
,
CronTabList
ctl
)
{
private
void
updateValidationsForSanity
(
Collection
<
FormValidation
>
validations
,
CronTabList
ctl
)
{
String
msg
=
ctl
.
checkSanity
();
if
(
msg
!=
null
)
{
return
response
.
withExtraWarning
(
msg
);
}
else
{
return
response
;
}
if
(
msg
!=
null
)
validations
.
add
(
FormValidation
.
warning
(
msg
));
}
private
ResponseObject
getResponseForNextRun
(
ResponseObject
response
,
CronTabList
ctl
)
{
private
void
updateValidationsForNextRun
(
Collection
<
FormValidation
>
validations
,
CronTabList
ctl
)
{
Calendar
prev
=
ctl
.
previous
();
Calendar
next
=
ctl
.
next
();
if
(
prev
!=
null
&&
next
!=
null
)
{
DateFormat
fmt
=
DateFormat
.
getDateTimeInstance
(
DateFormat
.
FULL
,
DateFormat
.
FULL
);
return
response
.
withExtraMessage
(
Messages
.
TimerTrigger_would_last_have_run_at_would_next_run_at
(
fmt
.
format
(
prev
.
getTime
()),
fmt
.
format
(
next
.
getTime
(
))));
validations
.
add
(
FormValidation
.
ok
(
Messages
.
TimerTrigger_would_last_have_run_at_would_next_run_at
(
fmt
.
format
(
prev
.
getTime
()),
fmt
.
format
(
next
.
getTime
()
))));
}
else
{
return
response
.
withExtraWarning
(
Messages
.
TimerTrigger_no_schedules_so_will_never_run
(
));
validations
.
add
(
FormValidation
.
warning
(
Messages
.
TimerTrigger_no_schedules_so_will_never_run
()
));
}
}
}
...
...
core/src/main/java/hudson/util/ResponseObject.java
已删除
100644 → 0
浏览文件 @
cbf46fc3
package
hudson.util
;
/**
* A class used to contain types of string response. Extra messages and warnings
* can be appended to the class until a response is required.
* The purpose of this class is to allow methods to update the message or
* warning response without needing to return the entire response, allowing more
* complex responses to be constructed.
*/
public
class
ResponseObject
{
private
final
String
message
;
private
final
String
warning
;
public
ResponseObject
()
{
message
=
""
;
warning
=
""
;
}
public
ResponseObject
(
String
message
,
String
warning
)
{
this
.
message
=
message
;
this
.
warning
=
warning
;
}
public
boolean
hasMessage
()
{
return
!
message
.
isEmpty
();
}
public
boolean
hasWarning
()
{
return
!
warning
.
isEmpty
();
}
public
String
getMessage
()
{
return
message
;
}
public
String
getWarning
()
{
return
warning
;
}
public
String
getWarningAndMessge
()
{
if
(
hasWarning
()
&&
hasMessage
())
{
return
warning
+
"; "
+
message
;
}
else
{
return
warning
+
message
;
}
}
public
ResponseObject
withExtraMessage
(
String
message
)
{
String
updatedMessage
;
if
(
this
.
hasMessage
())
{
updatedMessage
=
this
.
message
+
"; "
+
message
;
}
else
{
updatedMessage
=
message
;
}
return
new
ResponseObject
(
updatedMessage
,
warning
);
}
public
ResponseObject
withExtraWarning
(
String
warning
)
{
String
updatedWarning
;
if
(
this
.
hasWarning
())
{
updatedWarning
=
this
.
warning
+
"; "
+
warning
;
}
else
{
updatedWarning
=
warning
;
}
return
new
ResponseObject
(
message
,
updatedWarning
);
}
}
test/src/test/java/hudson/util/ResponseObjectTest.java
已删除
100644 → 0
浏览文件 @
cbf46fc3
package
hudson.util
;
import
org.junit.Test
;
import
static
org
.
junit
.
Assert
.*;
public
class
ResponseObjectTest
{
@Test
public
void
emptyMessageReportsAsEmpty
()
throws
Exception
{
// given
ResponseObject
response
=
new
ResponseObject
();
// when
boolean
hasMessage
=
response
.
hasMessage
();
// then
assertFalse
(
hasMessage
);
}
@Test
public
void
emptyWarningReportsAsEmpty
()
throws
Exception
{
// given
ResponseObject
response
=
new
ResponseObject
();
// when
boolean
hasWarning
=
response
.
hasWarning
();
// then
assertFalse
(
hasWarning
);
}
@Test
public
void
nonEmptyMessageReportsAsNonEmpty
()
throws
Exception
{
// given
ResponseObject
response
=
new
ResponseObject
(
"test"
,
""
);
// when
boolean
hasMessage
=
response
.
hasMessage
();
// then
assertTrue
(
hasMessage
);
}
@Test
public
void
nonEmptWarningReportsAsNonEmpty
()
throws
Exception
{
// given
ResponseObject
response
=
new
ResponseObject
(
""
,
"test"
);
// when
boolean
hasWarning
=
response
.
hasWarning
();
// then
assertTrue
(
hasWarning
);
}
@Test
public
void
messageIsReturned
()
throws
Exception
{
// given
String
expected
=
"test123"
;
ResponseObject
response
=
new
ResponseObject
(
expected
,
""
);
// when
String
actual
=
response
.
getMessage
();
// then
assertEquals
(
expected
,
actual
);
}
@Test
public
void
warningIsReturned
()
throws
Exception
{
// given
String
expected
=
"test123"
;
ResponseObject
response
=
new
ResponseObject
(
""
,
expected
);
// when
String
actual
=
response
.
getWarning
();
// then
assertEquals
(
expected
,
actual
);
}
@Test
public
void
emptyMessageIsUpdatedCorrectly
()
throws
Exception
{
// given
String
expected
=
"test123"
;
ResponseObject
response
=
new
ResponseObject
();
// when
ResponseObject
newResponse
=
response
.
withExtraMessage
(
expected
);
String
actual
=
newResponse
.
getMessage
();
// then
assertEquals
(
expected
,
actual
);
}
@Test
public
void
emptyWarningIsUpdatedCorrectly
()
throws
Exception
{
// given
String
expected
=
"test123"
;
ResponseObject
response
=
new
ResponseObject
();
// when
ResponseObject
newResponse
=
response
.
withExtraWarning
(
expected
);
String
actual
=
newResponse
.
getWarning
();
// then
assertEquals
(
expected
,
actual
);
}
@Test
public
void
nonEmptyMessageIsUpdatedCorrectly
()
throws
Exception
{
// given
String
extra
=
"123"
;
String
initial
=
"test"
;
ResponseObject
response
=
new
ResponseObject
(
initial
,
""
);
// when
ResponseObject
newResponse
=
response
.
withExtraMessage
(
extra
);
String
actual
=
newResponse
.
getMessage
();
// then
String
expected
=
initial
+
"; "
+
extra
;
assertEquals
(
expected
,
actual
);
}
@Test
public
void
nonEmptyWarningIsUpdatedCorrectly
()
throws
Exception
{
// given
String
extra
=
"123"
;
String
initial
=
"test"
;
ResponseObject
response
=
new
ResponseObject
(
""
,
initial
);
// when
ResponseObject
newResponse
=
response
.
withExtraWarning
(
extra
);
String
actual
=
newResponse
.
getWarning
();
// then
String
expected
=
initial
+
"; "
+
extra
;
assertEquals
(
expected
,
actual
);
}
@Test
public
void
warningAndMessageAreSeparated
()
throws
Exception
{
// given
String
warning
=
"warning"
;
String
message
=
"message"
;
ResponseObject
response
=
new
ResponseObject
(
message
,
warning
);
// when
String
actual
=
response
.
getWarningAndMessge
();
// then
String
expected
=
warning
+
"; "
+
message
;
assertEquals
(
expected
,
actual
);
}
@Test
public
void
onlyWarningNotSeparated
()
throws
Exception
{
// given
String
warning
=
"warning"
;
ResponseObject
response
=
new
ResponseObject
(
""
,
warning
);
// when
String
actual
=
response
.
getWarningAndMessge
();
// then
assertEquals
(
warning
,
actual
);
}
@Test
public
void
onlyMessageNotSeparated
()
throws
Exception
{
// given
String
message
=
"message"
;
ResponseObject
response
=
new
ResponseObject
(
message
,
""
);
// when
String
actual
=
response
.
getWarningAndMessge
();
// then
assertEquals
(
message
,
actual
);
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录