Do not fail startup in case ListView.includeRegex was syntactically malformed.

changelog.html

@@ -64,6 +64,8 @@ Upcoming changes</a>
   <li class='major bug'>
     Errors searching build records when builds were misordered.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-15652">issue 15652</a>)
+  <li class=bug>
+    Do not fail startup in case <code>ListView.includeRegex</code> was syntactically malformed.
   <li class=bug>
     CSS stylesheets misrendered in Chrome due to caching.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-17684">issue 17684</a>)

core/src/main/java/hudson/model/ListView.java

@@ -26,6 +26,7 @@ package hudson.model;
 
 import hudson.Extension;
 import hudson.Util;
+import hudson.diagnosis.OldDataMonitor;
 import hudson.model.Descriptor.FormException;
 import hudson.util.CaseInsensitiveComparator;
 import hudson.util.DescribableList;
@@ -36,6 +37,7 @@ import hudson.views.ViewJobFilter;
 
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.SortedSet;
@@ -106,8 +108,14 @@ public class ListView extends View implements Saveable {
     }
 
     private Object readResolve() {
-        if(includeRegex!=null)
-            includePattern = Pattern.compile(includeRegex);
+        if(includeRegex!=null) {
+            try {
+                includePattern = Pattern.compile(includeRegex);
+            } catch (PatternSyntaxException x) {
+                includeRegex = null;
+                OldDataMonitor.report(this, Collections.<Throwable>singleton(x));
+            }
+        }
         if (jobNames == null) {
             jobNames = new TreeSet<String>(CaseInsensitiveComparator.INSTANCE);
         }