Ryan reported a dead lock caused by getView(String), so removing synchronized...

Ryan reported a dead lock caused by getView(String), so removing synchronized and requiring the list be concurrently iterable.

core/src/main/java/hudson/model/ViewGroupMixIn.java

@@ -61,6 +61,9 @@ import java.util.List;
 public abstract class ViewGroupMixIn {
     private final ViewGroup owner;
 
+    /**
+     * Returns all the views. This list must be concurrently iterable.
+     */
     protected abstract List<View> views();
     protected abstract String primaryView();
     protected abstract void primaryView(String newName);
@@ -86,7 +89,7 @@ public abstract class ViewGroupMixIn {
         owner.save();
     }
 
-    public synchronized View getView(String name) {
+    public View getView(String name) {
         for (View v : views()) {
             if(v.getViewName().equals(name))
                 return v;
@@ -104,7 +107,7 @@ public abstract class ViewGroupMixIn {
      * Gets the read-only list of all {@link View}s.
      */
     @Exported
-    public synchronized Collection<View> getViews() {
+    public Collection<View> getViews() {
         List<View> copy = new ArrayList<View>(views());
         Collections.sort(copy, View.SORTER);
         return copy;

core/src/main/java/jenkins/model/Jenkins.java

@@ -1350,7 +1350,7 @@ public class Jenkins extends AbstractCIBase implements ModifiableItemGroup<TopLe
         return names;
     }
 
-    public synchronized View getView(String name) {
+    public View getView(String name) {
         return viewGroupMixIn.getView(name);
     }