- 27 5月, 2020 9 次提交
-
-
由 Jesse Jafa 提交于
Per https://github.com/zeit/next.js/issues/12964 Removed redundant react imports from next.js/examples/with-overmind
-
由 Joe Haddad 提交于
-
由 Joe Haddad 提交于
The experimental modern mode runs the type checking plugin twice, which **occasionally** suffers from a race condition that hangs the build. This PR fixes type checking to only be run once. While this test cannot 100% reproduce/capture the race condition, I don't feel strongly about the test case: - We're planning on eliminating this type checking plugin ASAP (for a faster alternative) - Modern mode implementation as-is will probably go away with webpack 5
-
由 Christian Stuff 提交于
Closes #9990 by collecting all paths with errors during `next export` and reporting them sorted in the error summary at the end. It will produce an output similar to: ``` Error: Export encountered errors on following paths: /nested/page /page /page-1 /page-10 /page-11 /page-12 /page-13 /page-2 /page-3 /page-4 /page-5 /page-6 /page-7 /page-8 /page-9 at _default (/app/next.js/packages/next/dist/export/index.js:19:788) at process._tickCallback (internal/process/next_tick.js:68:7) ``` I tested the output with the `handle-export-errors` integration test suite, but I'm not sure how to gracefully test this added output. I thought of collecting all page source files with [recursiveReaddirSync](https://github.com/zeit/next.js/blob/2ba352da39ee00b6595aecdc9ffb2f103e803a85/packages/next/next-server/server/lib/recursive-readdir-sync.ts) but it seems I can't import it in js test files: ``` SyntaxError: /app/next.js/packages/next/next-server/server/lib/recursive-readdir-sync.ts: Unexpected token, expected "," (11:5) 9 | */ 10 | export function recursiveReadDirSync( > 11 | dir: string, | ^ 12 | arr: string[] = [], 13 | rootDir = dir 14 | ): string[] { ``` The test itself could look like: ```js it('Reports failing paths', async () => { const { stderr } = await nextBuild(appDir, [], { stdout: true, stderr: true, }) const pages = [] // collect pages to be ['/page', '/page-1', ... etc.] pages.forEach(page => { expect(stderr).toContain(page) }) }) ```
-
由 JJ Kasper 提交于
As discussed this adds bundling of `.env` files in `serverless` mode so that the environment values are also available when deploying with this target closes: https://github.com/zeit/next.js/issues/13332
-
-
由 Joe Haddad 提交于
x-ref: #12313
-
由 Joe Haddad 提交于
Previous referencing the incorrect `Error` global.
-
由 Marco Moretti 提交于
fix #12136 I add a prompt if there is an error when trying to download example files. Maybe could be better to add an error class and in create-app.ts on every "console.error" trow a new Exception and manage it in catch. What you think ?
👯
-
- 26 5月, 2020 15 次提交
-
-
由 Jesse Jafa 提交于
Per https://github.com/zeit/next.js/issues/12964 * with-ant-design * with-dynamic-import * with-iron-session * with-monaco-editor * with-next-page-transitions * with-react-with-styles * with-style-sheet * with-why-did-you-render Tested each example, working as intended, no additional issues presented
-
由 JJ Kasper 提交于
-
由 Jan Potoms 提交于
URL paths are case sensitive, MacOS file system is case insensitive. This PR makes sure development mode doesn't find pages that don't have the casing as specified in the URL. Will clean up and write a test when agreed on this approach. Fixes https://github.com/zeit/next.js/issues/8825 Fixes https://github.com/zeit/next.js/issues/8847 Fixes https://github.com/zeit/next.js/issues/9080
-
由 TodorTotev 提交于
-
由 Jesse Jafa 提交于
Co-authored-by: Nkodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
由 Jesse Jafa 提交于
Co-authored-by: Nkodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
-
由 Jan Potoms 提交于
This is purely adding types except for the line: ```js params = getRouteMatcher(getRouteRegex(page))(path) || undefined ``` Also added a couple of `@ts-ignore` as to avoid having to make any more functional changes
-
由 Daniel Paz 提交于
Changed the URLs inside the Monaco Editor Example: https://github.com/zeit/next.js/tree/canary/examples/with-monaco-editor Converted the worker URL to start with the base URL. The reason is if you use the Monaco example anywhere but in the main `pages` folder, it won't work since it uses a relative URL instead. For example if we'll move the code to `pages/room/index.js` it won't work since it will try to search for the files inside `room/_next/_static/` instead of `_next/_static/`. The base URL I added fixes the problem.
-
由 Jan Potoms 提交于
Added a few extra types here and there while I was digging through the code
-
由 Erik 提交于
* set up with-ts-eslint-jest example app * eslint ignore new app bc it has a conflicting eslintrc * make eslint + husky setup manual * clarify app README setup notes * move page tests out of pages/ dir * Simplifying configs * extend "prettier" * format fix * Updated rules * Added husky configs and removed debug option * Removed notes and configuration * Updated pages * Added links to readme * Added example to .prettierignore * Updated snap * Make the lint work Co-authored-by: NLuis Alvarez D <luis@vercel.com>
-
由 TodorTotev 提交于
Related to [11014](https://github.com/zeit/next.js/issues/11014) First and most important, removed the getInitialProps and used getStaticProps. Then, I refactored Counter, DataList and Examples components. I have refactored them from class-based components to functional. Also in each component the redux implementation was refactored using the new hooks API, which resulted in ~40% less code. If you want me to change anything or you are not satisfied with any given change, I'm open to suggestions.
-
由 Giuseppe 提交于
-
由 TodorTotev 提交于
Related to [11014](https://github.com/zeit/next.js/issues/11014) 1. I have changed the component from class to functional. 2. I have removed the getInitialProps and used getStaticProps instead. 3. I have removed the redundant connect to redux @ the index page, due to the fact that now we can dispatch the action with the required hook. If you want me to change anything or you are not satisfied with any given change, I'm open to suggestions.
-
由 TodorTotev 提交于
Related to [11014](https://github.com/zeit/next.js/issues/11014) Upgraded all the packages from package.json, removed the saga-wrapper package since it is totally outdated to today's use. I have refactored the whole example using the new API of the next-redux-wrapper package, using their new support of "getStaticProps". All of the class components were converted to functional, using the new redux hooks API. If you want me to change anything or you are not satisfied with any given change, I'm open to suggestions.
-
由 Ayhan 提交于
-
- 25 5月, 2020 4 次提交
-
-
由 Ty Mick 提交于
https://vercel.com/blog/oss redirects to https://vercel.com. Is https://vercel.com/oss the right URL?
-
由 Jan Potoms 提交于
-
由 Takumasa Sakao 提交于
* Replace blog-starter to blog-starter-typescript * Fix unnecessary replacement
-
由 Maxi Gimenez 提交于
-
- 24 5月, 2020 12 次提交
-
-
由 Joe Haddad 提交于
* Fix method return shape * adjust type Co-authored-by: NTim Neutkens <tim@timneutkens.nl>
-
由 Joe Haddad 提交于
-
由 Joe Haddad 提交于
Noticed these tests failed for Windows on `canary`, then traced down the cause.
-
由 Maël Nison 提交于
Next is currently removing useful information from the PnP error messages. Before: ``` Module not found: Something that got detected as your top-level application (because it doesn't seem to belong to any package) tried to access a package that is not declared in your dependencies ``` After: ``` Module not found: Something that got detected as your top-level application (because it doesn't seem to belong to any package) tried to access a package that is not declared in your dependencies Required package: foo (via "foo/components/Avatar") Required by: /home/arcanis/foo/bar.tsx ```
-
由 James Mosier 提交于
This addresses #11910 in which `-e default` was not working because there was no example with the name `default`. This PR checks if a user inputted `default` as the example argument for `create-next-app` and if so it will use the local `default` template in the create-next-app directory. Closes #11910
-
由 Mohsen Azimi 提交于
My [draft PR was merged](https://github.com/zeit/next.js/pull/13193) so let's at least keep the code in canary in a working state.
-
由 Joe Haddad 提交于
This waits for the render to be committed to DOM before we render the route change complete event (no longer sync in new React). We have tests that ensure this resolves. --- Closes #12938
-
由 Joe Haddad 提交于
Closes #13254
-
由 Joe Haddad 提交于
-
由 Shu Uesugi 提交于
* Update debugging docs * typo * Update docs/debugging.md Co-authored-by: NLuis Alvarez D. <luis@vercel.com> * Update docs/debugging.md Co-authored-by: NLuis Alvarez D. <luis@vercel.com> * Clarify * Move to advanced features Co-authored-by: NLuis Alvarez D. <luis@vercel.com>
-
由 Gerald Monaco 提交于
-
由 JJ Kasper 提交于
This continues https://github.com/zeit/next.js/pull/12501 and resolves the merge conflicts since we aren't able to update that branch and would like to land this change Closes: https://github.com/zeit/next.js/pull/12501
-