Linting should be strict (#9418)

This configures our linting to exit without a success status code when warnings are found

examples/with-graphql-faunadb/components/Footer.js

@@ -14,7 +14,7 @@ export default props => (
       <div
         className={`${footerColumn.className} ${footerColumnFirst.className}`}
       >
-        <a href="https://fauna.com" target="_blank">
+        <a href="https://fauna.com" target="_blank" rel="noopener noreferrer">
           <img src="/static/fauna-logo-white.png" height="35px" width="auto" />
         </a>
         <p>
@@ -39,6 +39,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://fauna.com/faunadb"
             >
               FaunaDB
@@ -48,6 +49,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://fauna.com/pricing"
             >
               Pricing
@@ -57,6 +59,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://fauna.com/resources"
             >
               Resources
@@ -66,6 +69,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://fauna.com/blog"
             >
               Blog
@@ -80,6 +84,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://fauna.com/team"
             >
               Company
@@ -89,6 +94,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://fauna.com/press"
             >
               Press
@@ -98,6 +104,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://fauna.com/careers"
             >
               Careers
@@ -107,6 +114,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="http://www2.fauna.com/contact-us"
             >
               Contact
@@ -121,6 +129,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://community-invite.fauna.com/"
             >
               Community Slack
@@ -130,6 +139,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://support.fauna.com/"
             >
               Support
@@ -139,6 +149,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://dashboard.fauna.com/"
             >
               Login
@@ -148,6 +159,7 @@ export default props => (
             <a
               className={footerColumnListURL.className}
               target="_blank"
+              rel="noopener noreferrer"
               href="https://dashboard.fauna.com/accounts/register"
             >
               Signup

examples/with-graphql-faunadb/components/GuestbookEntry.js

@@ -19,6 +19,7 @@ export default props => (
         <div className={guestbookEntryUserDetailAvatar.className}>
           <a
             target="_blank"
+            rel="noopener noreferrer"
             href={`https://twitter.com/${props.twitter_handle}/`}
           >
             <img
@@ -30,6 +31,7 @@ export default props => (
         <a
           className={guestbookEntryUserDetailBiolink.className}
           target="_blank"
+          rel="noopener noreferrer"
           href={`https://twitter.com/${props.twitter_handle}/`}
         >
           {props.twitter_handle}
@@ -49,6 +51,7 @@ export default props => (
         )}&hashtags=graphql,nextjs
                     `}
         target="_blank"
+        rel="noopener noreferrer"
         className={guestbookEntryShareTwitterButton.className}
       >
         <img

examples/with-graphql-faunadb/components/Header.js

@@ -2,7 +2,7 @@ import { headerBanner, headerTitle } from '../styles/header'
 
 export default props => (
   <>
-    <a href="https://fauna.com" target="_blank">
+    <a href="https://fauna.com" target="_blank" rel="noopener noreferrer">
       <img
         className={headerBanner.className}
         src="/static/fauna-logo-blue.png"

package.json

@@ -15,8 +15,8 @@
     "git-clean": "git clean -d -x -e node_modules -e packages -f",
     "test-take2": "yarn git-reset && yarn git-clean && yarn testall",
     "test": "yarn run testall || yarn run test-take2",
-    "lint": "lerna run typescript && yarn prettier-check && eslint . --ext js,jsx,ts,tsx",
-    "lint-fix": "yarn prettier-fix && eslint . --ext js,jsx,ts,tsx --fix",
+    "lint": "lerna run typescript && yarn prettier-check && eslint . --ext js,jsx,ts,tsx --max-warnings=0",
+    "lint-fix": "yarn prettier-fix && eslint . --ext js,jsx,ts,tsx --fix --max-warnings=0",
     "prettier-check": "prettier --check \"**/*.{js,jsx,json,ts,tsx,md,mdx,css,html,yml,yaml,scss,sass}\"",
     "prettier-fix": "prettier --write \"**/*.{js,jsx,json,ts,tsx,md,mdx,css,html,yml,yaml,scss,sass}\"",
     "types": "lerna run types --stream",