• O
    Update/fix "examples/with-firebase-hosting-and-typescript" (#5864) · 4345343d
    Oscar Busk 提交于
    There were several issues with the example [examples/with-firebase-hosting-and-typescript](https://github.com/zeit/next.js/tree/canary/examples/with-firebase-hosting-and-typescript)
    * `npm run serve`
      * Has no `pre` task that actually builds the app. Requires manual running of all build scripts.
      * Will choke on windows because trying to set environment variables with `NODE_ENV=production`
    * Outdated Typescript and Tslint
    * Not being able to deploy because `firebase-tools` being of a deprecated version.
    * Structure, which I understand is based on `firebase-tools` generation, is confising with `src/functions/src` being generally bad structuring.
    
    I remedied this and also improved some other factors:
    
    * Remove dependency `prettier` as it is unused (f4d6f54)
    * Upgrade all dependencies (09a9193)
      * Use upgraded firebase dependencies to deploy to node 8 environment (87e1e09, 7d8055b)
      * Remove deprecated tslint rule `no-unused-variable` (9392162)
    * Flattened filestructure in `src/functions` (097a25a)
    * Use ES import when importing next (6c99adb)
    * Fixed incorrect name and added somewhat to the description in package.json.
      `with-firebase-hosting` → `with-firebase-hosting-and-typescript` (1ffa0b5)
    * Fixed `serve` script by building before running, using [`cross-env`](https://www.npmjs.com/package/cross-env) to set environment variables and remove unecessary flag. (3a1e221, 422ccee, 8811e44)
    * Add `.firebase` cache to `.gitignore` (4d7cbe4)
    * Add `-C` (clean) flag when copying dependency files `copy-deps` (0826708)
    * Use `strict: true` in the functions tsconfig (229b04f)
    
    This was tested by running serve on windows and linx(WSL) and deploy on linux(WSL)
    
    ---
    
    This is based on #5819 but correctly based from `canary`
    4345343d
README.md 3.1 KB