Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
CoCo_Code_Op2
brakeman
提交
cf2735cf
B
brakeman
项目概览
CoCo_Code_Op2
/
brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
cf2735cf
编写于
7月 16, 2013
作者:
J
Justin Collins
浏览文件
操作
浏览文件
下载
差异文件
Merge remote-tracking branch 'themetric/check_model_attr_accessible'
Add check for potentially dangerous attributes in attr_accessible
上级
791e3ede
673db9a2
变更
7
隐藏空白更改
内联
并排
Showing
7 changed file
with
97 addition
and
3 deletion
+97
-3
CHANGES
CHANGES
+1
-0
lib/brakeman/checks/check_model_attr_accessible.rb
lib/brakeman/checks/check_model_attr_accessible.rb
+48
-0
test/apps/rails3.2/app/models/account.rb
test/apps/rails3.2/app/models/account.rb
+1
-0
test/apps/rails3.2/app/models/no_protection.rb
test/apps/rails3.2/app/models/no_protection.rb
+3
-0
test/apps/rails3.2/app/models/user.rb
test/apps/rails3.2/app/models/user.rb
+1
-1
test/tests/rails32.rb
test/tests/rails32.rb
+42
-1
test/tests/rescanner.rb
test/tests/rescanner.rb
+1
-1
未找到文件。
CHANGES
浏览文件 @
cf2735cf
# Unreleased
* Check for dangerous model attributes defined in attr_accessible (Paul Deardorff)
* Update to ruby_parser 3.2.2
* Add brakeman-min gemspec
* Load gem dependencies on-demand
...
...
lib/brakeman/checks/check_model_attr_accessible.rb
0 → 100644
浏览文件 @
cf2735cf
require
'brakeman/checks/base_check'
# Author: Paul Deardorff (themetric)
# Checks models to see if important foreign keys
# or attributes are exposed as attr_accessible when
# they probably shouldn't be.
class
Brakeman::CheckModelAttrAccessible
<
Brakeman
::
BaseCheck
Brakeman
::
Checks
.
add
self
@description
=
"Reports models which have dangerous attributes defined under the attr_accessible whitelist."
SUSP_ATTRS
=
{
/admin/
=>
CONFIDENCE
[
:high
],
# Very dangerous unless some Rails authorization used
/role/
=>
CONFIDENCE
[
:med
],
/banned/
=>
CONFIDENCE
[
:med
],
:account_id
=>
CONFIDENCE
[
:high
],
/\S*_id(s?)\z/
=>
CONFIDENCE
[
:low
]
# All other foreign keys have weak/low confidence
}
def
run_check
check_models
do
|
name
,
model
|
accessible_attrs
=
model
[
:attr_accessible
]
accessible_attrs
.
each
do
|
attribute
|
SUSP_ATTRS
.
each
do
|
susp_attr
,
confidence
|
if
susp_attr
.
is_a?
(
Regexp
)
and
susp_attr
=~
attribute
.
to_s
or
susp_attr
==
attribute
warn
:model
=>
name
,
:file
=>
model
[
:file
],
:warning_type
=>
"Mass Assignment"
,
:warning_code
=>
:mass_assign_call
,
:message
=>
"Potentially dangerous attribute
#{
attribute
}
available for mass assignment."
,
:confidence
=>
confidence
break
# Prevent from matching single attr multiple times
end
end
end
end
end
def
check_models
tracker
.
models
.
each
do
|
name
,
model
|
if
!
model
[
:attr_accessible
].
nil?
yield
name
,
model
end
end
end
end
test/apps/rails3.2/app/models/account.rb
浏览文件 @
cf2735cf
class
Account
<
ActiveRecord
::
Base
attr_accessible
:plan_id
,
:banned
end
test/apps/rails3.2/app/models/no_protection.rb
0 → 100644
浏览文件 @
cf2735cf
class
NoProtection
<
ActiveRecord
::
Base
# Leave this class empty for Rescanner tests
end
test/apps/rails3.2/app/models/user.rb
浏览文件 @
cf2735cf
class
User
<
ActiveRecord
::
Base
attr_accessible
:bio
,
:name
attr_accessible
:bio
,
:name
,
:account_id
,
:admin
,
:status_id
end
test/tests/rails32.rb
浏览文件 @
cf2735cf
...
...
@@ -9,7 +9,7 @@ class Rails32Tests < Test::Unit::TestCase
def
expected
@expected
||=
{
:controller
=>
0
,
:model
=>
0
,
:model
=>
5
,
:template
=>
11
,
:warning
=>
7
}
...
...
@@ -212,4 +212,45 @@ class Rails32Tests < Test::Unit::TestCase
:confidence
=>
0
,
:file
=>
/secret_token\.rb/
end
def
test_model_attr_accessible_admin
assert_warning
:type
=>
:model
,
:warning_type
=>
"Mass Assignment"
,
:message
=>
/^Potentially\ dangerous\ attribute\ admin/
,
:confidence
=>
0
,
#HIGH
:file
=>
/user\.rb/
end
def
test_model_attr_accessible_account_id
assert_warning
:type
=>
:model
,
:warning_type
=>
"Mass Assignment"
,
:message
=>
/^Potentially\ dangerous\ attribute\ account_id/
,
:confidence
=>
0
,
:file
=>
/user\.rb/
end
def
test_model_attr_accessible_account_banned
assert_warning
:type
=>
:model
,
:warning_type
=>
"Mass Assignment"
,
:message
=>
/^Potentially\ dangerous\ attribute\ banned/
,
:confidence
=>
1
,
#MED
:file
=>
/account\.rb/
end
def
test_model_attr_accessible_status_id
assert_warning
:type
=>
:model
,
:warning_type
=>
"Mass Assignment"
,
:message
=>
/^Potentially\ dangerous\ attribute\ status_id/
,
:confidence
=>
2
,
#LOW
:file
=>
/user\.rb/
end
def
test_model_attr_accessible_plan_id
assert_warning
:type
=>
:model
,
:warning_type
=>
"Mass Assignment"
,
:message
=>
/^Potentially\ dangerous\ attribute\ plan_id/
,
:confidence
=>
2
,
:file
=>
/account\.rb/
end
end
test/tests/rescanner.rb
浏览文件 @
cf2735cf
...
...
@@ -151,7 +151,7 @@ class RescannerTests < Test::Unit::TestCase
assert_reindex
:templates
,
:models
,
:controllers
assert_changes
assert_new
7
#User is no longer a model, causing MORE warnings
assert_fixed
4
assert_fixed
7
end
def
test_add_method_to_model
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录