Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
CoCo_Code_Op2
brakeman
提交
ad1c7ad7
B
brakeman
项目概览
CoCo_Code_Op2
/
brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
ad1c7ad7
编写于
8月 21, 2013
作者:
J
Justin Collins
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Make ModelAttrAccessible check consistent in 1.8
上级
d4c6cda8
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
22 addition
and
23 deletion
+22
-23
lib/brakeman/checks/check_model_attr_accessible.rb
lib/brakeman/checks/check_model_attr_accessible.rb
+22
-23
未找到文件。
lib/brakeman/checks/check_model_attr_accessible.rb
浏览文件 @
ad1c7ad7
require
'brakeman/checks/base_check'
# Author: Paul Deardorff (themetric)
# Checks models to see if important foreign keys
# or attributes are exposed as attr_accessible when
# they probably shouldn't be.
# Author: Paul Deardorff (themetric)
# Checks models to see if important foreign keys
# or attributes are exposed as attr_accessible when
# they probably shouldn't be.
class
Brakeman::CheckModelAttrAccessible
<
Brakeman
::
BaseCheck
Brakeman
::
Checks
.
add
self
@description
=
"Reports models which have dangerous attributes defined under the attr_accessible whitelist."
SUSP_ATTRS
=
{
/admin/
=>
CONFIDENCE
[
:high
],
# Very dangerous unless some Rails authorization used
/role/
=>
CONFIDENCE
[
:med
],
/banned/
=>
CONFIDENCE
[
:med
],
:account_id
=>
CONFIDENCE
[
:high
],
/\S*_id(s?)\z/
=>
CONFIDENCE
[
:low
]
# All other foreign keys have weak/low confidence
}
SUSP_ATTRS
=
[
[
/admin/
,
CONFIDENCE
[
:high
]],
# Very dangerous unless some Rails authorization used
[
/role/
,
CONFIDENCE
[
:med
]],
[
/banned/
,
CONFIDENCE
[
:med
]],
[
:account_id
,
CONFIDENCE
[
:high
]],
[
/\S*_id(s?)\z/
,
CONFIDENCE
[
:low
]]
# All other foreign keys have weak/low confidence
]
def
run_check
check_models
do
|
name
,
model
|
accessible_attrs
=
model
[
:attr_accessible
]
accessible_attrs
.
each
do
|
attribute
|
SUSP_ATTRS
.
each
do
|
susp_attr
,
confidence
|
if
susp_attr
.
is_a?
(
Regexp
)
and
susp_attr
=~
attribute
.
to_s
or
susp_attr
==
attribute
warn
:model
=>
name
,
:file
=>
model
[
:file
],
:warning_type
=>
"Mass Assignment"
,
:warning_code
=>
:mass_assign_call
,
:message
=>
"Potentially dangerous attribute
#{
attribute
}
available for mass assignment."
,
:confidence
=>
confidence
break
# Prevent from matching single attr multiple times
end
end
end
if
susp_attr
.
is_a?
(
Regexp
)
and
susp_attr
=~
attribute
.
to_s
or
susp_attr
==
attribute
warn
:model
=>
name
,
:file
=>
model
[
:file
],
:warning_type
=>
"Mass Assignment"
,
:message
=>
"Potentially dangerous attribute
#{
attribute
}
available for mass assignment."
,
:confidence
=>
confidence
break
# Prevent from matching single attr multiple times
end
end
end
end
end
...
...
@@ -44,5 +43,5 @@ class Brakeman::CheckModelAttrAccessible < Brakeman::BaseCheck
end
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录