Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
CoCo_Code_Op2
brakeman
提交
2f8f55ce
B
brakeman
项目概览
CoCo_Code_Op2
/
brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
2f8f55ce
编写于
5月 12, 2013
作者:
J
Justin Collins
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add test for duplicate send() warnings
上级
d7f00569
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
11 addition
and
2 deletion
+11
-2
test/apps/rails2/app/controllers/home_controller.rb
test/apps/rails2/app/controllers/home_controller.rb
+2
-2
test/apps/rails2/app/views/home/test_send_target.html.erb
test/apps/rails2/app/views/home/test_send_target.html.erb
+1
-0
test/tests/test_rails2.rb
test/tests/test_rails2.rb
+8
-0
未找到文件。
test/apps/rails2/app/controllers/home_controller.rb
浏览文件 @
2f8f55ce
...
...
@@ -81,10 +81,10 @@ class HomeController < ApplicationController
def
test_send_first_param
method
=
params
[
"method"
]
@result
=
User
.
send
(
method
.
to_sym
)
do_something_with
@result
# don't warn on this line
end
# not that safe
def
test_send_target
def
test_send_target
# not that safe
table
=
params
[
"table"
]
model
=
table
.
classify
.
constantize
@result
=
model
.
send
(
:method
)
...
...
test/apps/rails2/app/views/home/test_send_target.html.erb
0 → 100644
浏览文件 @
2f8f55ce
<%=
h
@result
%>
should not warn about send() because it warns in controller where it happens.
test/tests/test_rails2.rb
浏览文件 @
2f8f55ce
...
...
@@ -855,6 +855,14 @@ class Rails2Tests < Test::Unit::TestCase
:file
=>
/home_controller\.rb/
,
:relative_path
=>
"app/controllers/home_controller.rb"
assert_no_warning
:type
=>
:warning
,
:warning_code
=>
23
,
:warning_type
=>
"Dangerous Send"
,
:line
=>
84
,
:message
=>
/^User\ controlled\ method\ execution/
,
:confidence
=>
0
,
:relative_path
=>
"app/controllers/home_controller.rb"
assert_no_warning
:type
=>
:warning
,
:warning_type
=>
"Dangerous Send"
,
:line
=>
90
,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录