Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
BaiXuePrincess
milvus
提交
d418f54e
milvus
项目概览
BaiXuePrincess
/
milvus
与 Fork 源项目一致
从无法访问的项目Fork
通知
7
Star
4
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
milvus
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
d418f54e
编写于
8月 24, 2020
作者:
C
Cai Yudong
提交者:
GitHub
8月 24, 2020
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
update clang-tidy rules (#3416)
Signed-off-by:
N
yudong.cai
<
yudong.cai@zilliz.com
>
上级
e89a707d
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
14 addition
and
8 deletion
+14
-8
.clang-tidy
.clang-tidy
+7
-1
core/src/metrics/SystemInfo.cpp
core/src/metrics/SystemInfo.cpp
+2
-2
core/src/server/grpc_impl/GrpcRequestHandler.cpp
core/src/server/grpc_impl/GrpcRequestHandler.cpp
+1
-1
core/src/utils/Status.cpp
core/src/utils/Status.cpp
+2
-2
core/src/utils/Status.h
core/src/utils/Status.h
+2
-2
未找到文件。
.clang-tidy
浏览文件 @
d418f54e
...
@@ -20,7 +20,13 @@ Checks: >
...
@@ -20,7 +20,13 @@ Checks: >
-*, clang-diagnostic-*, -clang-diagnostic-error,
-*, clang-diagnostic-*, -clang-diagnostic-error,
clang-analyzer-*, -clang-analyzer-alpha*,
clang-analyzer-*, -clang-analyzer-alpha*,
google-*, -google-runtime-references, -google-readability-todo,
google-*, -google-runtime-references, -google-readability-todo,
modernize-*, -modernize-pass-by-value, -modernize-use-equals-default
modernize-*, -modernize-pass-by-value, -modernize-use-equals-default,
performance-faster-string-find, performance-for-range-copy,
performance-implicit-conversion-in-loop, performance-inefficient-algorithm,
performance-trivially-destructible, performance-inefficient-vector-operation,
performance-move-const-arg, performance-move-constructor-init,
performance-noexcept-move-constructor, performance-no-automatic-move,
performance-type-promotion-in-math-fn
# produce HeaderFilterRegex from core/build-support/lint_exclusions.txt with:
# produce HeaderFilterRegex from core/build-support/lint_exclusions.txt with:
# echo -n '^?!('; sed -e 's/*/\.*/g' core/build-support/lint_exclusions.txt | tr '\n' '|'; echo ')$'
# echo -n '^?!('; sed -e 's/*/\.*/g' core/build-support/lint_exclusions.txt | tr '\n' '|'; echo ')$'
...
...
core/src/metrics/SystemInfo.cpp
浏览文件 @
d418f54e
...
@@ -370,10 +370,10 @@ SystemInfo::Octets() {
...
@@ -370,10 +370,10 @@ SystemInfo::Octets() {
lastline
=
line
;
lastline
=
line
;
}
}
std
::
vector
<
size_t
>
space_position
;
std
::
vector
<
size_t
>
space_position
;
size_t
space_pos
=
lastline
.
find
(
" "
);
size_t
space_pos
=
lastline
.
find
(
' '
);
while
(
space_pos
!=
std
::
string
::
npos
)
{
while
(
space_pos
!=
std
::
string
::
npos
)
{
space_position
.
push_back
(
space_pos
);
space_position
.
push_back
(
space_pos
);
space_pos
=
lastline
.
find
(
" "
,
space_pos
+
1
);
space_pos
=
lastline
.
find
(
' '
,
space_pos
+
1
);
}
}
// InOctets is between 6th and 7th " " and OutOctets is between 7th and 8th " "
// InOctets is between 6th and 7th " " and OutOctets is between 7th and 8th " "
size_t
inoctets_begin
=
space_position
[
6
]
+
1
;
size_t
inoctets_begin
=
space_position
[
6
]
+
1
;
...
...
core/src/server/grpc_impl/GrpcRequestHandler.cpp
浏览文件 @
d418f54e
...
@@ -1323,7 +1323,7 @@ GrpcRequestHandler::Insert(::grpc::ServerContext* context, const ::milvus::grpc:
...
@@ -1323,7 +1323,7 @@ GrpcRequestHandler::Insert(::grpc::ServerContext* context, const ::milvus::grpc:
auto
grpc_float_size
=
request
->
fields
(
i
).
attr_record
().
float_value_size
();
auto
grpc_float_size
=
request
->
fields
(
i
).
attr_record
().
float_value_size
();
auto
grpc_double_size
=
request
->
fields
(
i
).
attr_record
().
double_value_size
();
auto
grpc_double_size
=
request
->
fields
(
i
).
attr_record
().
double_value_size
();
const
auto
&
field
=
request
->
fields
(
i
);
const
auto
&
field
=
request
->
fields
(
i
);
auto
field_name
=
field
.
field_name
();
auto
&
field_name
=
field
.
field_name
();
std
::
vector
<
uint8_t
>
temp_data
;
std
::
vector
<
uint8_t
>
temp_data
;
if
(
grpc_int32_size
>
0
)
{
if
(
grpc_int32_size
>
0
)
{
...
...
core/src/utils/Status.cpp
浏览文件 @
d418f54e
...
@@ -38,7 +38,7 @@ Status::Status(const Status& s) {
...
@@ -38,7 +38,7 @@ Status::Status(const Status& s) {
CopyFrom
(
s
);
CopyFrom
(
s
);
}
}
Status
::
Status
(
Status
&&
s
)
{
Status
::
Status
(
Status
&&
s
)
noexcept
{
MoveFrom
(
s
);
MoveFrom
(
s
);
}
}
...
@@ -49,7 +49,7 @@ Status::operator=(const Status& s) {
...
@@ -49,7 +49,7 @@ Status::operator=(const Status& s) {
}
}
Status
&
Status
&
Status
::
operator
=
(
Status
&&
s
)
{
Status
::
operator
=
(
Status
&&
s
)
noexcept
{
MoveFrom
(
s
);
MoveFrom
(
s
);
return
*
this
;
return
*
this
;
}
}
...
...
core/src/utils/Status.h
浏览文件 @
d418f54e
...
@@ -36,13 +36,13 @@ class Status {
...
@@ -36,13 +36,13 @@ class Status {
Status
(
const
Status
&
s
);
Status
(
const
Status
&
s
);
Status
(
Status
&&
s
);
Status
(
Status
&&
s
)
noexcept
;
Status
&
Status
&
operator
=
(
const
Status
&
s
);
operator
=
(
const
Status
&
s
);
Status
&
Status
&
operator
=
(
Status
&&
s
);
operator
=
(
Status
&&
s
)
noexcept
;
static
Status
static
Status
OK
()
{
OK
()
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录