提交 38161c4d 编写于 作者: W wxyu

MS-417 YAML sequence load disable cause scheduler startup failed


Former-commit-id: e1929059c6e5554a329a717b490beb3efa2c97bb
上级 c195ed70
...@@ -8,6 +8,7 @@ Please mark all change in change log and use the ticket from JIRA. ...@@ -8,6 +8,7 @@ Please mark all change in change log and use the ticket from JIRA.
- MS-411 - Fix metric unittest linking error - MS-411 - Fix metric unittest linking error
- MS-412 - Fix gpu cache logical error - MS-412 - Fix gpu cache logical error
- MS-416 - ExecutionEngineImpl::GpuCache has not return value cause crash - MS-416 - ExecutionEngineImpl::GpuCache has not return value cause crash
- MS-417 - YAML sequence load disable cause scheduler startup failed
## Improvement ## Improvement
- MS-327 - Clean code for milvus - MS-327 - Clean code for milvus
......
...@@ -73,19 +73,19 @@ YamlConfigMgr::SetChildConfig(const YAML::Node& node, ...@@ -73,19 +73,19 @@ YamlConfigMgr::SetChildConfig(const YAML::Node& node,
return false; return false;
} }
//bool bool
//YamlConfigMgr::SetSequence(const YAML::Node &node, YamlConfigMgr::SetSequence(const YAML::Node &node,
// const std::string &child_name, const std::string &child_name,
// ConfigNode &config) { ConfigNode &config) {
// if(node[child_name].IsDefined ()) { if(node[child_name].IsDefined ()) {
// size_t cnt = node[child_name].size(); size_t cnt = node[child_name].size();
// for(size_t i = 0; i < cnt; i++){ for(size_t i = 0; i < cnt; i++){
// config.AddSequenceItem(child_name, node[child_name][i].as<std::string>()); config.AddSequenceItem(child_name, node[child_name][i].as<std::string>());
// } }
// return true; return true;
// } }
// return false; return false;
//} }
void void
YamlConfigMgr::LoadConfigNode(const YAML::Node& node, ConfigNode& config) { YamlConfigMgr::LoadConfigNode(const YAML::Node& node, ConfigNode& config) {
...@@ -98,8 +98,8 @@ YamlConfigMgr::LoadConfigNode(const YAML::Node& node, ConfigNode& config) { ...@@ -98,8 +98,8 @@ YamlConfigMgr::LoadConfigNode(const YAML::Node& node, ConfigNode& config) {
SetConfigValue(node, key, config); SetConfigValue(node, key, config);
} else if(node[key].IsMap()){ } else if(node[key].IsMap()){
SetChildConfig(node, key, config); SetChildConfig(node, key, config);
// } else if(node[key].IsSequence()){ } else if(node[key].IsSequence()){
// SetSequence(node, key, config); SetSequence(node, key, config);
} }
} }
} }
......
...@@ -33,10 +33,10 @@ class YamlConfigMgr : public IConfigMgr { ...@@ -33,10 +33,10 @@ class YamlConfigMgr : public IConfigMgr {
const std::string &name, const std::string &name,
ConfigNode &config); ConfigNode &config);
// bool bool
// SetSequence(const YAML::Node &node, SetSequence(const YAML::Node &node,
// const std::string &child_name, const std::string &child_name,
// ConfigNode &config); ConfigNode &config);
void LoadConfigNode(const YAML::Node& node, ConfigNode& config); void LoadConfigNode(const YAML::Node& node, ConfigNode& config);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册