check_op_desc.py 12.9 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16
# Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import json
import sys
17 18
from paddle.utils import OpLastCheckpointChecker
from paddle.fluid.core import OpUpdateType
19 20 21 22 23 24 25

SAME = 0

INPUTS = "Inputs"
OUTPUTS = "Outputs"
ATTRS = "Attrs"

26 27 28 29 30 31
# The constant `ADD` means that an item has been added. In particular,
# we use `ADD_WITH_DEFAULT` to mean adding attributes with default
# attributes, and `ADD_DISPENSABLE` to mean adding optional inputs or
# outputs.
ADD_WITH_DEFAULT = "Add_with_default"
ADD_DISPENSABLE = "Add_dispensable"
32
ADD = "Add"
33

34 35 36 37 38 39 40 41 42 43 44 45 46
DELETE = "Delete"
CHANGE = "Change"

DUPLICABLE = "duplicable"
INTERMEDIATE = "intermediate"
DISPENSABLE = "dispensable"

TYPE = "type"
GENERATED = "generated"
DEFAULT_VALUE = "default_value"

error = False

47 48 49 50 51 52 53 54 55 56 57 58 59
version_update_map = {
    INPUTS: {
        ADD: OpUpdateType.kNewInput,
    },
    OUTPUTS: {
        ADD: OpUpdateType.kNewOutput,
    },
    ATTRS: {
        ADD: OpUpdateType.kNewAttr,
        CHANGE: OpUpdateType.kModifyAttr,
    },
}

60 61 62 63 64

def diff_vars(origin_vars, new_vars):
    global error
    var_error = False
    var_changed_error_massage = {}
65 66
    var_add_massage = []
    var_add_dispensable_massage = []
67 68 69 70 71 72 73
    var_deleted_error_massage = []

    common_vars_name = set(origin_vars.keys()) & set(new_vars.keys())
    vars_name_only_in_origin = set(origin_vars.keys()) - set(new_vars.keys())
    vars_name_only_in_new = set(new_vars.keys()) - set(origin_vars.keys())

    for var_name in common_vars_name:
74
        if cmp(origin_vars.get(var_name), new_vars.get(var_name)) == SAME:
75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90
            continue
        else:
            error, var_error = True, True
            var_changed_error_massage[var_name] = {}
            for arg_name in origin_vars.get(var_name):
                new_arg_value = new_vars.get(var_name, {}).get(arg_name)
                origin_arg_value = origin_vars.get(var_name, {}).get(arg_name)
                if new_arg_value != origin_arg_value:
                    var_changed_error_massage[var_name][arg_name] = (
                        origin_arg_value, new_arg_value)

    for var_name in vars_name_only_in_origin:
        error, var_error = True, True
        var_deleted_error_massage.append(var_name)

    for var_name in vars_name_only_in_new:
91
        var_add_massage.append(var_name)
92
        if not new_vars.get(var_name).get(DISPENSABLE):
93
            error, var_error = True, True
94
            var_add_dispensable_massage.append(var_name)
95 96

    var_diff_message = {}
97 98 99 100
    if var_add_massage:
        var_diff_message[ADD] = var_add_massage
    if var_add_dispensable_massage:
        var_diff_message[ADD_DISPENSABLE] = var_add_dispensable_massage
101 102 103 104 105 106 107 108 109 110 111 112 113 114
    if var_changed_error_massage:
        var_diff_message[CHANGE] = var_changed_error_massage
    if var_deleted_error_massage:
        var_diff_message[DELETE] = var_deleted_error_massage

    return var_error, var_diff_message


def diff_attr(ori_attrs, new_attrs):
    global error
    attr_error = False

    attr_changed_error_massage = {}
    attr_added_error_massage = []
115
    attr_added_def_error_massage = []
116 117 118 119 120 121 122
    attr_deleted_error_massage = []

    common_attrs = set(ori_attrs.keys()) & set(new_attrs.keys())
    attrs_only_in_origin = set(ori_attrs.keys()) - set(new_attrs.keys())
    attrs_only_in_new = set(new_attrs.keys()) - set(ori_attrs.keys())

    for attr_name in common_attrs:
123
        if cmp(ori_attrs.get(attr_name), new_attrs.get(attr_name)) == SAME:
124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139
            continue
        else:
            error, attr_error = True, True
            attr_changed_error_massage[attr_name] = {}
            for arg_name in ori_attrs.get(attr_name):
                new_arg_value = new_attrs.get(attr_name, {}).get(arg_name)
                origin_arg_value = ori_attrs.get(attr_name, {}).get(arg_name)
                if new_arg_value != origin_arg_value:
                    attr_changed_error_massage[attr_name][arg_name] = (
                        origin_arg_value, new_arg_value)

    for attr_name in attrs_only_in_origin:
        error, attr_error = True, True
        attr_deleted_error_massage.append(attr_name)

    for attr_name in attrs_only_in_new:
140
        attr_added_error_massage.append(attr_name)
141
        if new_attrs.get(attr_name).get(DEFAULT_VALUE) == None:
142
            error, attr_error = True, True
143
            attr_added_def_error_massage.append(attr_name)
144 145 146 147

    attr_diff_message = {}
    if attr_added_error_massage:
        attr_diff_message[ADD] = attr_added_error_massage
148 149
    if attr_added_def_error_massage:
        attr_diff_message[ADD_WITH_DEFAULT] = attr_added_def_error_massage
150 151 152 153 154 155 156 157
    if attr_changed_error_massage:
        attr_diff_message[CHANGE] = attr_changed_error_massage
    if attr_deleted_error_massage:
        attr_diff_message[DELETE] = attr_deleted_error_massage

    return attr_error, attr_diff_message


158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181
def check_io_registry(io_type, op, diff):
    checker = OpLastCheckpointChecker()
    results = {}
    for update_type in [ADD]:
        for item in diff.get(update_type, {}):
            infos = checker.filter_updates(
                op, version_update_map[io_type][update_type], item)
            if not infos:
                results[update_type] = (op, item, io_type)
    return results


def check_attr_registry(op, diff):
    checker = OpLastCheckpointChecker()
    results = {}
    for update_type in [ADD, CHANGE]:
        for item in diff.get(update_type, {}):
            infos = checker.filter_updates(
                op, version_update_map[ATTRS][update_type], item)
            if not infos:
                results[update_type] = (op, item)
    return results


182 183 184
def compare_op_desc(origin_op_desc, new_op_desc):
    origin = json.loads(origin_op_desc)
    new = json.loads(new_op_desc)
185 186
    desc_error_message = {}
    version_error_message = {}
187
    if cmp(origin_op_desc, new_op_desc) == SAME:
188
        return desc_error_message, version_error_message
189 190 191 192 193 194 195 196 197 198 199 200

    for op_type in origin:
        # no need to compare if the operator is deleted
        if op_type not in new:
            continue

        origin_info = origin.get(op_type, {})
        new_info = new.get(op_type, {})

        origin_inputs = origin_info.get(INPUTS, {})
        new_inputs = new_info.get(INPUTS, {})
        ins_error, ins_diff = diff_vars(origin_inputs, new_inputs)
201
        ins_version_errors = check_io_registry(INPUTS, op_type, ins_diff)
202 203 204 205

        origin_outputs = origin_info.get(OUTPUTS, {})
        new_outputs = new_info.get(OUTPUTS, {})
        outs_error, outs_diff = diff_vars(origin_outputs, new_outputs)
206
        outs_version_errors = check_io_registry(OUTPUTS, op_type, outs_diff)
207 208 209 210

        origin_attrs = origin_info.get(ATTRS, {})
        new_attrs = new_info.get(ATTRS, {})
        attrs_error, attrs_diff = diff_attr(origin_attrs, new_attrs)
211
        attrs_version_errors = check_attr_registry(op_type, attrs_diff)
212

213
        if ins_error:
214
            desc_error_message.setdefault(op_type, {})[INPUTS] = ins_diff
215
        if outs_error:
216
            desc_error_message.setdefault(op_type, {})[OUTPUTS] = outs_diff
217
        if attrs_error:
218
            desc_error_message.setdefault(op_type, {})[ATTRS] = attrs_diff
219

220 221 222 223 224 225 226 227 228
        if ins_version_errors:
            version_error_message.setdefault(op_type,
                                             {})[INPUTS] = ins_version_errors
        if outs_version_errors:
            version_error_message.setdefault(op_type,
                                             {})[OUTPUTS] = outs_version_errors
        if attrs_version_errors:
            version_error_message.setdefault(op_type,
                                             {})[ATTRS] = attrs_version_errors
229

230
    return desc_error_message, version_error_message
231

232 233 234 235

def print_desc_error_message(error_message):
    print("\n======================= \n"
          "Op desc error for the changes of Inputs/Outputs/Attrs of OPs:\n")
236 237 238 239 240
    for op_name in error_message:
        print("For OP '{}':".format(op_name))

        # 1. print inputs error message
        Inputs_error = error_message.get(op_name, {}).get(INPUTS, {})
241
        for name in Inputs_error.get(ADD_DISPENSABLE, {}):
242
            print(" * The added Input '{}' is not dispensable.".format(name))
243 244

        for name in Inputs_error.get(DELETE, {}):
245
            print(" * The Input '{}' is deleted.".format(name))
246 247 248 249 250 251

        for name in Inputs_error.get(CHANGE, {}):
            changed_args = Inputs_error.get(CHANGE, {}).get(name, {})
            for arg in changed_args:
                ori_value, new_value = changed_args.get(arg)
                print(
252
                    " * The arg '{}' of Input '{}' is changed: from '{}' to '{}'.".
253 254 255 256
                    format(arg, name, ori_value, new_value))

        # 2. print outputs error message
        Outputs_error = error_message.get(op_name, {}).get(OUTPUTS, {})
257
        for name in Outputs_error.get(ADD_DISPENSABLE, {}):
258
            print(" * The added Output '{}' is not dispensable.".format(name))
259 260

        for name in Outputs_error.get(DELETE, {}):
261
            print(" * The Output '{}' is deleted.".format(name))
262 263 264 265 266 267

        for name in Outputs_error.get(CHANGE, {}):
            changed_args = Outputs_error.get(CHANGE, {}).get(name, {})
            for arg in changed_args:
                ori_value, new_value = changed_args.get(arg)
                print(
268
                    " * The arg '{}' of Output '{}' is changed: from '{}' to '{}'.".
269 270 271 272
                    format(arg, name, ori_value, new_value))

        # 3. print attrs error message
        attrs_error = error_message.get(op_name, {}).get(ATTRS, {})
273
        for name in attrs_error.get(ADD_WITH_DEFAULT, {}):
274 275
            print(" * The added attr '{}' doesn't set default value.".format(
                name))
276 277

        for name in attrs_error.get(DELETE, {}):
278
            print(" * The attr '{}' is deleted.".format(name))
279 280 281 282 283 284

        for name in attrs_error.get(CHANGE, {}):
            changed_args = attrs_error.get(CHANGE, {}).get(name, {})
            for arg in changed_args:
                ori_value, new_value = changed_args.get(arg)
                print(
285
                    " * The arg '{}' of attr '{}' is changed: from '{}' to '{}'.".
286 287 288
                    format(arg, name, ori_value, new_value))


289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322
def print_version_error_message(error_message):
    print(
        "\n======================= \n"
        "Operator registration error for the changes of Inputs/Outputs/Attrs of OPs:\n"
    )
    for op_name in error_message:
        print("For OP '{}':".format(op_name))

        # 1. print inputs error message
        inputs_error = error_message.get(op_name, {}).get(INPUTS, {})
        tuple = inputs_error.get(ADD, {})
        if tuple:
            print(" * The added input '{}' is not yet registered.".format(tuple[
                1]))

        # 2. print inputs error message
        outputs_error = error_message.get(op_name, {}).get(OUTPUTS, {})
        tuple = outputs_error.get(ADD, {})
        if tuple:
            print(" * The added output '{}' is not yet registered.".format(
                tuple[1]))

        #3. print attrs error message
        attrs_error = error_message.get(op_name, {}).get(ATTRS, {})
        tuple = attrs_error.get(ADD, {})
        if tuple:
            print(" * The added attribute '{}' is not yet registered.".format(
                tuple[1]))
        tuple = attrs_error.get(CHANGE, {})
        if tuple:
            print(" * The change of attribute '{}' is not yet registered.".
                  format(tuple[1]))


323 324 325 326 327 328 329 330 331 332 333 334 335
def print_repeat_process():
    print(
        "Tips:"
        " If you want to repeat the process, please follow these steps:\n"
        "\t1. Compile and install paddle from develop branch \n"
        "\t2. Run: python tools/print_op_desc.py  > OP_DESC_DEV.spec \n"
        "\t3. Compile and install paddle from PR branch \n"
        "\t4. Run: python tools/print_op_desc.py  > OP_DESC_PR.spec \n"
        "\t5. Run: python tools/check_op_desc.py OP_DESC_DEV.spec OP_DESC_PR.spec"
    )


if len(sys.argv) == 3:
336 337 338 339 340 341 342 343 344 345
    '''
    Compare op_desc files generated by branch DEV and branch PR.
    And print error message.
    '''
    with open(sys.argv[1], 'r') as f:
        origin_op_desc = f.read()

    with open(sys.argv[2], 'r') as f:
        new_op_desc = f.read()

346 347
    desc_error_message, version_error_message = compare_op_desc(origin_op_desc,
                                                                new_op_desc)
348
    if error:
349
        print("-" * 30)
350 351
        print_desc_error_message(desc_error_message)
        print_version_error_message(version_error_message)
352
        print("-" * 30)
353
else:
354
    print("Usage: python check_op_desc.py OP_DESC_DEV.spec OP_DESC_PR.spec")