Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
Annlix
ShellCheck
提交
5adfce72
S
ShellCheck
项目概览
Annlix
/
ShellCheck
与 Fork 源项目一致
Fork自
镜像 / koalaman / ShellCheck
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
ShellCheck
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
5adfce72
编写于
4月 27, 2018
作者:
S
Stefan Knudsen
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Warn about invalid arguments to sudo
上级
12b3fdf6
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
18 addition
and
0 deletion
+18
-0
CHANGELOG.md
CHANGELOG.md
+1
-0
src/ShellCheck/Analytics.hs
src/ShellCheck/Analytics.hs
+17
-0
未找到文件。
CHANGELOG.md
浏览文件 @
5adfce72
## Latest - ???
### Added
-
SC2232: Warn about invalid arguments to sudo
-
SC2231: Suggest quoting expansions in for loop globs
-
SC2229: Warn about 'read $var'
-
SC2227: Warn about redirections in the middle of 'find' commands
...
...
src/ShellCheck/Analytics.hs
浏览文件 @
5adfce72
...
...
@@ -121,6 +121,7 @@ nodeChecks = [
,
checkTestRedirects
,
checkIndirectExpansion
,
checkSudoRedirect
,
checkSudoArgs
,
checkPS1Assignments
,
checkBackticks
,
checkInexplicablyUnquoted
...
...
@@ -1306,6 +1307,22 @@ checkSudoRedirect _ (T_Redirecting _ redirs cmd) | cmd `isCommand` "sudo" =
special
file
=
concat
(
oversimplify
file
)
==
"/dev/null"
checkSudoRedirect
_
_
=
return
()
prop_checkSudoArgs1
=
verify
checkSudoArgs
"sudo cd /root"
prop_checkSudoArgs2
=
verify
checkSudoArgs
"sudo export x=3"
prop_checkSudoArgs3
=
verifyNot
checkSudoArgs
"sudo ls /usr/local/protected"
prop_checkSudoArgs4
=
verifyNot
checkSudoArgs
"sudo ls && export x=3"
prop_checkSudoArgs5
=
verifyNot
checkSudoArgs
"sudo echo ls"
checkSudoArgs
_
t
@
(
T_SimpleCommand
_
_
(
_
:
rest
))
|
t
`
isCommand
`
"sudo"
=
checkArgs
args
where
checkArgs
(
x
:
xs
)
|
x
`
elem
`
prohibitedArguments
=
warn
(
getId
t
)
2232
$
"Can't use sudo with "
++
x
|
x
`
elem
`
commonCommands
=
return
()
|
otherwise
=
checkArgs
xs
checkArgs
[]
=
return
()
args
=
map
onlyLiteralString
$
concat
$
map
getWordParts
rest
prohibitedArguments
=
[
"cd"
,
"export"
]
checkSudoArgs
_
_
=
return
()
prop_checkPS11
=
verify
checkPS1Assignments
"PS1='
\\
033[1;35m
\\
$ '"
prop_checkPS11a
=
verify
checkPS1Assignments
"export PS1='
\\
033[1;35m
\\
$ '"
prop_checkPSf2
=
verify
checkPS1Assignments
"PS1='
\\
h
\\
e[0m
\\
$ '"
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录