Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
社会瑞弟呀
brakeman
提交
f1ac8eea
B
brakeman
项目概览
社会瑞弟呀
/
brakeman
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
B
brakeman
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f1ac8eea
编写于
5月 07, 2013
作者:
J
Justin Collins
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix link_to logic messed up during refactoring
and add test for it so it won't happen again
上级
e62cf7e8
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
18 addition
and
5 deletion
+18
-5
lib/brakeman/checks/check_link_to.rb
lib/brakeman/checks/check_link_to.rb
+1
-1
test/apps/rails2/app/views/home/test_link_to.html.erb
test/apps/rails2/app/views/home/test_link_to.html.erb
+2
-0
test/tests/test_rails2.rb
test/tests/test_rails2.rb
+15
-4
未找到文件。
lib/brakeman/checks/check_link_to.rb
浏览文件 @
f1ac8eea
...
...
@@ -89,7 +89,7 @@ class Brakeman::CheckLinkTo < Brakeman::CheckCrossSiteScripting
# Check if we should warn about the matched result
def
check_matched
(
result
,
matched
=
nil
)
return
false
unless
matched
return
false
if
matched
.
type
==
:model
and
not
tracker
.
options
[
:ignore_model_output
]
return
false
if
matched
.
type
==
:model
and
tracker
.
options
[
:ignore_model_output
]
message
=
"Unescaped
#{
friendly_type_of
matched
}
in link_to"
...
...
test/apps/rails2/app/views/home/test_link_to.html.erb
浏览文件 @
f1ac8eea
...
...
@@ -5,3 +5,5 @@
<%
end
%>
<%=
link_to
params
[
:evil
],
"http://brakemanscanner.org"
%>
<%=
link_to
make_awesome
(
User
.
find
(
1
).
name
),
"http://google.com"
%>
test/tests/test_rails2.rb
浏览文件 @
f1ac8eea
...
...
@@ -11,13 +11,13 @@ class Rails2Tests < Test::Unit::TestCase
@expected
||=
{
:controller
=>
1
,
:model
=>
3
,
:template
=>
4
3
,
:template
=>
4
4
,
:warning
=>
46
}
else
@expected
||=
{
:controller
=>
1
,
:model
=>
3
,
:template
=>
4
3
,
:template
=>
4
4
,
:warning
=>
47
}
end
end
...
...
@@ -427,6 +427,17 @@ class Rails2Tests < Test::Unit::TestCase
:relative_path
=>
"app/views/home/test_model.html.erb"
end
def
test_indirect_model_in_link_to
assert_warning
:type
=>
:template
,
:warning_code
=>
3
,
:fingerprint
=>
"8941c902e7c71d0df4ebb1888c8ed9ac99affaf385be657838452ac3eefe563c"
,
:warning_type
=>
"Cross Site Scripting"
,
:line
=>
9
,
:message
=>
/^Unescaped\ model\ attribute\ in\ l/
,
:confidence
=>
1
,
:relative_path
=>
"app/views/home/test_link_to.html.erb"
end
def
test_escaped_parameter_in_link_to
assert_no_warning
:type
=>
:template
,
:warning_type
=>
"Cross Site Scripting"
,
...
...
@@ -1158,13 +1169,13 @@ class Rails2WithOptionsTests < Test::Unit::TestCase
@expected
||=
{
:controller
=>
1
,
:model
=>
4
,
:template
=>
4
3
,
:template
=>
4
4
,
:warning
=>
46
}
else
@expected
||=
{
:controller
=>
1
,
:model
=>
4
,
:template
=>
4
3
,
:template
=>
4
4
,
:warning
=>
47
}
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录