From 7c60a0116032375916e94f6d82623155226353ac Mon Sep 17 00:00:00 2001 From: Justin Collins Date: Fri, 21 Sep 2012 09:51:44 -0700 Subject: [PATCH] Output message for OutputProcessor errors instead of just an empty string. This should happen almost never, but hopefully this will prompt people to report bugs if it does happen instead of hiding them. --- lib/brakeman/processors/output_processor.rb | 2 +- test/tests/test_output_processor.rb | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/brakeman/processors/output_processor.rb b/lib/brakeman/processors/output_processor.rb index 81635691..821188cf 100644 --- a/lib/brakeman/processors/output_processor.rb +++ b/lib/brakeman/processors/output_processor.rb @@ -10,7 +10,7 @@ class Brakeman::OutputProcessor < Ruby2Ruby #Copies +exp+ and then formats it. def format exp - process(exp.deep_clone) || "" + process(exp.deep_clone) || "[Format Error]" end alias process_safely format diff --git a/test/tests/test_output_processor.rb b/test/tests/test_output_processor.rb index b4345dea..37b12bfd 100644 --- a/test/tests/test_output_processor.rb +++ b/test/tests/test_output_processor.rb @@ -6,19 +6,19 @@ class OutputProcessorTests < Test::Unit::TestCase end def test_output_nil - assert_output "", nil + assert_output "[Format Error]", nil end def test_output_empty_sexp - assert_output "", Sexp.new + assert_output "[Format Error]", Sexp.new end def test_output_missing_node_type - assert_output "", Sexp.new(Sexp.new(:str, 'x')) + assert_output "[Format Error]", Sexp.new(Sexp.new(:str, 'x')) end def test_output_bad_node_type - assert_output "", Sexp.new(:bad_node_type) + assert_output "[Format Error]", Sexp.new(:bad_node_type) end def test_output_local_variable -- GitLab