From 2f6fb06d3ab55df0adf6a6052c9da50d75054ec1 Mon Sep 17 00:00:00 2001
From: Justin Collins <collins@twitter.com>
Date: Thu, 1 Mar 2012 17:47:44 -0800
Subject: [PATCH] Add test for select vulnerability in Rails 3

---
 test/apps/rails3.1/app/views/users/edit.html.erb |  2 ++
 test/tests/test_rails31.rb                       | 11 ++++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/test/apps/rails3.1/app/views/users/edit.html.erb b/test/apps/rails3.1/app/views/users/edit.html.erb
index 99bd4cc5..4bbb4185 100644
--- a/test/apps/rails3.1/app/views/users/edit.html.erb
+++ b/test/apps/rails3.1/app/views/users/edit.html.erb
@@ -1,5 +1,7 @@
 <h1>Editing user</h1>
 
+<%= select('post', 'author_id', "<option value='#{@user.id}'>#{@user.name}</option>") %>
+
 <%= render 'form' %>
 
 <%= link_to 'Show', @user %> |
diff --git a/test/tests/test_rails31.rb b/test/tests/test_rails31.rb
index e9f0f537..3679b0c2 100644
--- a/test/tests/test_rails31.rb
+++ b/test/tests/test_rails31.rb
@@ -13,7 +13,7 @@ class Rails31Tests < Test::Unit::TestCase
   def expected
     @expected ||= {
       :model => 0,
-      :template => 0,
+      :template => 1,
       :controller => 1,
       :warning => 7 }
   end
@@ -97,4 +97,13 @@ class Rails31Tests < Test::Unit::TestCase
       :confidence => 1,
       :file => /user\.rb/
   end
+
+  def test_select_vulnerability
+    assert_warning :type => :template,
+      :warning_type => "Cross Site Scripting",
+      :line => 2,
+      :message => /^Upgrade to Rails 3.1.4, 3.1.0 select\(\) helper is vulnerable/,
+      :confidence => 0,
+      :file => /edit\.html\.erb/
+  end
 end
-- 
GitLab