From 20ac9c448d8b761f4856449e7087cf3e40496ea4 Mon Sep 17 00:00:00 2001
From: Justin Collins <justin@presidentbeef.com>
Date: Mon, 8 Jul 2013 09:22:58 -0700
Subject: [PATCH] Track calls with blocks in CallIndex

---
 lib/brakeman/processors/lib/find_all_calls.rb | 59 ++++++++++++++-----
 1 file changed, 43 insertions(+), 16 deletions(-)

diff --git a/lib/brakeman/processors/lib/find_all_calls.rb b/lib/brakeman/processors/lib/find_all_calls.rb
index 17e0ba5b..127f4367 100644
--- a/lib/brakeman/processors/lib/find_all_calls.rb
+++ b/lib/brakeman/processors/lib/find_all_calls.rb
@@ -37,28 +37,33 @@ class Brakeman::FindAllCalls < Brakeman::BaseProcessor
   end
 
   def process_call exp
-    target = get_target exp.target
-    
-    if call? target
-      already_in_target = @in_target
-      @in_target = true
-      process target
-      @in_target = already_in_target
-    end
+    @calls << create_call_hash(exp)
+    exp
+  end
 
-    method = exp.method
-    process_call_args exp
+  def process_call_with_block exp
+    call = exp.block_call
 
-    @calls << { :target => target,
-                :method => method,
-                :call => exp,
-                :nested => @in_target,
-                :chain => get_chain(exp),
-                :location => make_location }
+    if call.node_type == :call
+      call_hash = create_call_hash(call)
+
+      call_hash[:block] = exp.block
+      call_hash[:block_args] = exp.block_args
+
+      @calls << call_hash
+
+      process exp.block
+    else
+      #Probably a :render call with block
+      process call
+      process exp.block
+    end
 
     exp
   end
 
+  alias process_iter process_call_with_block
+
   #Calls to render() are converted to s(:render, ...) but we would
   #like them in the call cache still for speed
   def process_render exp
@@ -155,4 +160,26 @@ class Brakeman::FindAllCalls < Brakeman::BaseProcessor
     end
 
   end
+
+  #Return info hash for a call Sexp
+  def create_call_hash exp
+    target = get_target exp.target
+
+    if call? target
+      already_in_target = @in_target
+      @in_target = true
+      process target
+      @in_target = already_in_target
+    end
+
+    method = exp.method
+    process_call_args exp
+
+    { :target => target,
+      :method => method,
+      :call => exp,
+      :nested => @in_target,
+      :chain => get_chain(exp),
+      :location => make_location }
+  end
 end
-- 
GitLab