From 56b195e4c596b1d2e0991b93aefb9a035b6e6c6e Mon Sep 17 00:00:00 2001 From: lepdou Date: Fri, 14 Jul 2017 10:45:00 +0800 Subject: [PATCH] Bugfix: check application namespace existed --- .../apollo/portal/service/AppNamespaceService.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppNamespaceService.java b/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppNamespaceService.java index 04f34c689..680018aae 100644 --- a/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppNamespaceService.java +++ b/apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppNamespaceService.java @@ -46,18 +46,19 @@ public class AppNamespaceService { @Transactional public void createDefaultAppNamespace(String appId) { - if (!isAppNamespaceNameUnique(appId, appId)) { - throw new ServiceException("appnamespace not unique"); + if (!isAppNamespaceNameUnique(appId, ConfigConsts.NAMESPACE_APPLICATION)) { + throw new BadRequestException(String.format("App already has application namespace. AppId = %s", appId)); } + AppNamespace appNs = new AppNamespace(); appNs.setAppId(appId); appNs.setName(ConfigConsts.NAMESPACE_APPLICATION); appNs.setComment("default app namespace"); appNs.setFormat(ConfigFileFormat.Properties.getValue()); - String userId = userInfoHolder.getUser().getUserId(); appNs.setDataChangeCreatedBy(userId); appNs.setDataChangeLastModifiedBy(userId); + appNamespaceRepository.save(appNs); } -- GitLab