From f5e6b42bed3f7ed734663fc4ee936533b1602f27 Mon Sep 17 00:00:00 2001 From: Miguel Ruiz Date: Tue, 4 Jan 2022 11:07:04 +0100 Subject: [PATCH] Activiti/Activiti#3765 Add Process Runtime coverage for category field (#3785) * Activiti/Activiti#3765 Add Process Runtime coverage for category field * Remove redundant null check * Improve test * Rearrage test code * Improve test syntax --- .../spring/boot/process/ProcessRuntimeIT.java | 16 ++++++++++++++++ .../processes/categorize-human.bpmn20.xml | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/activiti-core/activiti-spring-boot-starter/src/test/java/org/activiti/spring/boot/process/ProcessRuntimeIT.java b/activiti-core/activiti-spring-boot-starter/src/test/java/org/activiti/spring/boot/process/ProcessRuntimeIT.java index 31f60ab876..15734da54c 100644 --- a/activiti-core/activiti-spring-boot-starter/src/test/java/org/activiti/spring/boot/process/ProcessRuntimeIT.java +++ b/activiti-core/activiti-spring-boot-starter/src/test/java/org/activiti/spring/boot/process/ProcessRuntimeIT.java @@ -24,6 +24,7 @@ import java.math.BigDecimal; import java.time.LocalDate; import java.time.LocalDateTime; import java.util.List; +import java.util.Objects; import java.util.stream.Collectors; import org.activiti.api.model.shared.model.VariableInstance; import org.activiti.api.process.model.Deployment; @@ -75,6 +76,7 @@ public class ProcessRuntimeIT { private static final String SUPER_PROCESS = "superProcess"; private static final Pageable PAGEABLE = Pageable.of(0, 50); + public static final String CATEGORIZE_HUMAN_PROCESS_CATEGORY = "test-category"; @Autowired private ProcessRuntime processRuntime; @@ -186,6 +188,20 @@ public class ProcessRuntimeIT { ONE_STEP_PROCESS); } + @Test + public void should_allProcessDefinitionsHaveCategoriesSet_when_fetchingProcessDefinitions() { + //when + List processDefinitionList = processRuntime.processDefinitions(PAGEABLE) + .getContent(); + + //then + assertThat(processDefinitionList) + .extracting(ProcessDefinition::getCategory) + .contains(CATEGORIZE_HUMAN_PROCESS_CATEGORY) + .allMatch(Objects::nonNull); + + } + @Test public void shouldGetAvailableLatestDeployments() { diff --git a/activiti-core/activiti-spring-boot-starter/src/test/resources/processes/categorize-human.bpmn20.xml b/activiti-core/activiti-spring-boot-starter/src/test/resources/processes/categorize-human.bpmn20.xml index 5a3e732305..50af06981a 100644 --- a/activiti-core/activiti-spring-boot-starter/src/test/resources/processes/categorize-human.bpmn20.xml +++ b/activiti-core/activiti-spring-boot-starter/src/test/resources/processes/categorize-human.bpmn20.xml @@ -1,5 +1,5 @@ - + SequenceFlow_14mnde3 -- GitLab