From ebc21c65a9d768a137d83b1ec19e7983e76e7bd0 Mon Sep 17 00:00:00 2001
From: kohsuke <kohsuke@71c3de6d-444a-0410-be80-ed276b4c234a>
Date: Thu, 20 Sep 2007 21:37:43 +0000
Subject: [PATCH] escape URL unsafe names.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@4854 71c3de6d-444a-0410-be80-ed276b4c234a
---
 core/src/main/java/hudson/tasks/junit/CaseResult.java  | 4 ++--
 core/src/main/java/hudson/tasks/junit/SuiteResult.java | 2 +-
 core/src/main/java/hudson/tasks/junit/TestObject.java  | 7 +++++++
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/core/src/main/java/hudson/tasks/junit/CaseResult.java b/core/src/main/java/hudson/tasks/junit/CaseResult.java
index 770029f755..77066c92aa 100644
--- a/core/src/main/java/hudson/tasks/junit/CaseResult.java
+++ b/core/src/main/java/hudson/tasks/junit/CaseResult.java
@@ -37,8 +37,8 @@ public final class CaseResult extends TestObject implements Comparable<CaseResul
         //    cn = parent.getName();
 
         String cn = parent.getName();
-        className = cn.replace('/','_');    // avoid unsafe chars
-        testName = testCase.attributeValue("name").replace('/','_');
+        className = safe(cn);
+        testName = safe(testCase.attributeValue("name"));
         errorStackTrace = getError(testCase);
     }
 
diff --git a/core/src/main/java/hudson/tasks/junit/SuiteResult.java b/core/src/main/java/hudson/tasks/junit/SuiteResult.java
index d68693bc0b..0a8d06c037 100644
--- a/core/src/main/java/hudson/tasks/junit/SuiteResult.java
+++ b/core/src/main/java/hudson/tasks/junit/SuiteResult.java
@@ -42,7 +42,7 @@ public final class SuiteResult implements Serializable {
             // some user reported that name is null in their environment.
             // see http://www.nabble.com/Unexpected-Null-Pointer-Exception-in-Hudson-1.131-tf4314802.html
             name = '('+xmlReport.getName()+')';
-        this.name = name;
+        this.name = TestObject.safe(name);
 
         stdout = root.elementText("system-out");
         stderr = root.elementText("system-err");
diff --git a/core/src/main/java/hudson/tasks/junit/TestObject.java b/core/src/main/java/hudson/tasks/junit/TestObject.java
index 8398c7059f..27dd04959c 100644
--- a/core/src/main/java/hudson/tasks/junit/TestObject.java
+++ b/core/src/main/java/hudson/tasks/junit/TestObject.java
@@ -20,4 +20,11 @@ public abstract class TestObject implements ModelObject, Serializable {
      *      if no such counter part exists.
      */
     public abstract TestObject getPreviousResult();
+
+    /**
+     * Replaces URL-unasfe characters.
+     */
+    protected static String safe(String s) {
+        return s.replace('/','_').replace(':','_');
+    }
 }
-- 
GitLab