From 5c65527ceb32f77ddace8c35fd04881cc20a21a9 Mon Sep 17 00:00:00 2001 From: dty Date: Wed, 14 Oct 2009 04:21:38 +0000 Subject: [PATCH] The visibility rules for top level test results and test suite results were not consistent with the recent changes to test case results. Added visibility attributes to @Exported annotations so that stdout and stderr can be filtered out of the remote API. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22735 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/tasks/junit/SuiteResult.java | 10 +++++----- core/src/main/java/hudson/tasks/junit/TestResult.java | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/core/src/main/java/hudson/tasks/junit/SuiteResult.java b/core/src/main/java/hudson/tasks/junit/SuiteResult.java index 06fb1d001b..8180dac205 100644 --- a/core/src/main/java/hudson/tasks/junit/SuiteResult.java +++ b/core/src/main/java/hudson/tasks/junit/SuiteResult.java @@ -52,7 +52,7 @@ import org.kohsuke.stapler.export.ExportedBean; */ @ExportedBean public final class SuiteResult implements Serializable { - private final String file; + private final String file; private final String name; private final String stdout; private final String stderr; @@ -157,12 +157,12 @@ public final class SuiteResult implements Serializable { duration += cr.getDuration(); } - @Exported + @Exported(visibility=9) public String getName() { return name; } - @Exported + @Exported(visibility=9) public float getDuration() { return duration; } @@ -200,12 +200,12 @@ public final class SuiteResult implements Serializable { return parent; } - @Exported + @Exported(visibility=9) public String getTimestamp() { return timestamp; } - @Exported(inline=true) + @Exported(inline=true,visibility=9) public List getCases() { return cases; } diff --git a/core/src/main/java/hudson/tasks/junit/TestResult.java b/core/src/main/java/hudson/tasks/junit/TestResult.java index 425d5e8a49..4b27ebb3e5 100644 --- a/core/src/main/java/hudson/tasks/junit/TestResult.java +++ b/core/src/main/java/hudson/tasks/junit/TestResult.java @@ -230,7 +230,7 @@ public final class TestResult extends MetaTabulatedResult { return Messages.TestResult_getChildTitle(); } - // TODO once stapler 1.60 is released: @Exported + @Exported(visibility=999) public float getDuration() { return duration; } @@ -247,7 +247,7 @@ public final class TestResult extends MetaTabulatedResult { return failedTests.size(); } - @Exported + @Exported(visibility=999) @Override public int getSkipCount() { return skippedTests; @@ -263,7 +263,7 @@ public final class TestResult extends MetaTabulatedResult { return byPackages.values(); } - @Exported(inline=true) + @Exported(inline=true,visibility=9) public Collection getSuites() { return suites; } -- GitLab