From 50295317091c52dfc7443ad6ad7657cfc252fa96 Mon Sep 17 00:00:00 2001
From: kohsuke <kohsuke@71c3de6d-444a-0410-be80-ed276b4c234a>
Date: Tue, 24 Jun 2008 00:27:22 +0000
Subject: [PATCH] Renaming "foo" to "Foo" shouldn't cause an error. See
 http://www.nabble.com/error-on-renaming-project-tt18061629.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@10363 71c3de6d-444a-0410-be80-ed276b4c234a
---
 core/src/main/java/hudson/model/Job.java | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/core/src/main/java/hudson/model/Job.java b/core/src/main/java/hudson/model/Job.java
index 643014a1e2..e1fbe9f339 100644
--- a/core/src/main/java/hudson/model/Job.java
+++ b/core/src/main/java/hudson/model/Job.java
@@ -373,7 +373,11 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
                 // sanity check
                 if (newName == null)
                     throw new IllegalArgumentException("New name is not given");
-                if (parent.getItem(newName) != null)
+                TopLevelItem existing = parent.getItem(newName);
+                if (existing != null && existing!=this)
+                    // the look up is case insensitive, so we need "existing!=this"
+                    // to allow people to rename "Foo" to "foo", for example.
+                    // see http://www.nabble.com/error-on-renaming-project-tt18061629.html
                     throw new IllegalArgumentException("Job " + newName
                             + " already exists");
 
-- 
GitLab