From 36a60e2c3c1987b4221a256fa9945863a6b9e9ed Mon Sep 17 00:00:00 2001 From: kohsuke Date: Wed, 28 Mar 2007 01:23:51 +0000 Subject: [PATCH] added a regression test. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2736 71c3de6d-444a-0410-be80-ed276b4c234a --- .../main/java/hudson/scm/SubversionSCM.java | 4 ++-- .../java/hudson/scm/SubversionSCMTest.java | 20 +++++++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 core/src/test/java/hudson/scm/SubversionSCMTest.java diff --git a/core/src/main/java/hudson/scm/SubversionSCM.java b/core/src/main/java/hudson/scm/SubversionSCM.java index c1fe148c07..068c249be0 100644 --- a/core/src/main/java/hudson/scm/SubversionSCM.java +++ b/core/src/main/java/hudson/scm/SubversionSCM.java @@ -696,8 +696,6 @@ public class SubversionSCM extends SCM implements Serializable { }.process(); } - private static final Pattern URL_PATTERN = Pattern.compile("(https?|svn(\\+\\w+)?|file)://.+"); - /** * validate the value for a local location (local checkout directory). */ @@ -730,6 +728,8 @@ public class SubversionSCM extends SCM implements Serializable { } } + static final Pattern URL_PATTERN = Pattern.compile("(https?|svn(\\+[a-z0-9]+)?|file)://.+"); + private static final long serialVersionUID = 1L; private static final Logger logger = Logger.getLogger(SubversionSCM.class.getName()); diff --git a/core/src/test/java/hudson/scm/SubversionSCMTest.java b/core/src/test/java/hudson/scm/SubversionSCMTest.java new file mode 100644 index 0000000000..3b8d3a5890 --- /dev/null +++ b/core/src/test/java/hudson/scm/SubversionSCMTest.java @@ -0,0 +1,20 @@ +package hudson.scm; + +import junit.framework.TestCase; + +/** + * @author Kohsuke Kawaguchi + */ +public class SubversionSCMTest extends TestCase { + public void test1() { + check("http://foobar/"); + check("https://foobar/"); + check("file://foobar/"); + check("svn://foobar/"); + check("svn+ssh://foobar/"); + } + + private void check(String url) { + assertTrue(SubversionSCM.URL_PATTERN.matcher(url).matches()); + } +} -- GitLab