/*--------------------------------------------------------------------------------------------- * Copyright (c) Microsoft Corporation. All rights reserved. * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ 'use strict'; import * as path from 'path'; import * as objects from 'vs/base/common/objects'; import { stopProfiling } from 'vs/base/node/profiler'; import nls = require('vs/nls'); import URI from 'vs/base/common/uri'; import { IStorageService } from 'vs/platform/storage/node/storage'; import { shell, screen, BrowserWindow, systemPreferences, app } from 'electron'; import { TPromise, TValueCallback } from 'vs/base/common/winjs.base'; import { IEnvironmentService, ParsedArgs } from 'vs/platform/environment/common/environment'; import { ILogService } from 'vs/platform/log/common/log'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { parseArgs } from 'vs/platform/environment/node/argv'; import product from 'vs/platform/node/product'; import pkg from 'vs/platform/node/package'; import { IWindowSettings, MenuBarVisibility, IWindowConfiguration, ReadyState } from 'vs/platform/windows/common/windows'; import { IDisposable, dispose } from 'vs/base/common/lifecycle'; import { KeyboardLayoutMonitor } from 'vs/code/electron-main/keyboard'; import { isLinux, isMacintosh, isWindows } from 'vs/base/common/platform'; import { ICodeWindow } from 'vs/platform/windows/electron-main/windows'; import { IWorkspaceIdentifier, IWorkspacesMainService } from 'vs/platform/workspaces/common/workspaces'; import { IBackupMainService } from 'vs/platform/backup/common/backup'; export interface IWindowState { width?: number; height?: number; x?: number; y?: number; mode?: WindowMode; display?: number; } export interface IWindowCreationOptions { state: IWindowState; extensionDevelopmentPath?: string; isExtensionTestHost?: boolean; } export enum WindowMode { Maximized, Normal, Minimized, // not used anymore, but also cannot remove due to existing stored UI state (needs migration) Fullscreen } export const defaultWindowState = function (mode = WindowMode.Normal): IWindowState { return { width: 1024, height: 768, mode }; }; interface IWorkbenchEditorConfiguration { workbench: { editor: { swipeToNavigate: boolean } }; } export class CodeWindow implements ICodeWindow { public static themeStorageKey = 'theme'; public static themeBackgroundStorageKey = 'themeBackground'; private static DEFAULT_BG_LIGHT = '#FFFFFF'; private static DEFAULT_BG_DARK = '#1E1E1E'; private static DEFAULT_BG_HC_BLACK = '#000000'; private static MIN_WIDTH = 200; private static MIN_HEIGHT = 120; private hiddenTitleBarStyle: boolean; private showTimeoutHandle: any; private _id: number; private _win: Electron.BrowserWindow; private _lastFocusTime: number; private _readyState: ReadyState; private windowState: IWindowState; private currentMenuBarVisibility: MenuBarVisibility; private toDispose: IDisposable[]; private representedFilename: string; private whenReadyCallbacks: TValueCallback[]; private currentConfig: IWindowConfiguration; private pendingLoadConfig: IWindowConfiguration; constructor( config: IWindowCreationOptions, @ILogService private logService: ILogService, @IEnvironmentService private environmentService: IEnvironmentService, @IConfigurationService private configurationService: IConfigurationService, @IStorageService private storageService: IStorageService, @IWorkspacesMainService private workspaceService: IWorkspacesMainService, @IBackupMainService private backupService: IBackupMainService ) { this._lastFocusTime = -1; this._readyState = ReadyState.NONE; this.whenReadyCallbacks = []; this.toDispose = []; // create browser window this.createBrowserWindow(config); // respect configured menu bar visibility this.onConfigurationUpdated(); // Eventing this.registerListeners(); } private createBrowserWindow(config: IWindowCreationOptions): void { // Load window state this.windowState = this.restoreWindowState(config.state); // in case we are maximized or fullscreen, only show later after the call to maximize/fullscreen (see below) const isFullscreenOrMaximized = (this.windowState.mode === WindowMode.Maximized || this.windowState.mode === WindowMode.Fullscreen); let backgroundColor = this.getBackgroundColor(); if (isMacintosh && backgroundColor.toUpperCase() === CodeWindow.DEFAULT_BG_DARK) { backgroundColor = '#171717'; // https://github.com/electron/electron/issues/5150 } const options: Electron.BrowserWindowConstructorOptions = { width: this.windowState.width, height: this.windowState.height, x: this.windowState.x, y: this.windowState.y, backgroundColor, minWidth: CodeWindow.MIN_WIDTH, minHeight: CodeWindow.MIN_HEIGHT, show: !isFullscreenOrMaximized, title: product.nameLong, webPreferences: { 'backgroundThrottling': false, // by default if Code is in the background, intervals and timeouts get throttled, disableBlinkFeatures: 'Auxclick' // disable auxclick events (see https://developers.google.com/web/updates/2016/10/auxclick) } }; if (isLinux) { options.icon = path.join(this.environmentService.appRoot, 'resources/linux/code.png'); // Windows and Mac are better off using the embedded icon(s) } const windowConfig = this.configurationService.getConfiguration('window'); let useNativeTabs = false; if (windowConfig && windowConfig.nativeTabs) { options.tabbingIdentifier = product.nameShort; // this opts in to sierra tabs useNativeTabs = true; } let useCustomTitleStyle = false; if (isMacintosh && (!windowConfig || !windowConfig.titleBarStyle || windowConfig.titleBarStyle === 'custom')) { const isDev = !this.environmentService.isBuilt || !!config.extensionDevelopmentPath; if (!isDev) { useCustomTitleStyle = true; // not enabled when developing due to https://github.com/electron/electron/issues/3647 } } if (useNativeTabs) { useCustomTitleStyle = false; // native tabs on sierra do not work with custom title style } if (useCustomTitleStyle) { options.titleBarStyle = 'hidden'; this.hiddenTitleBarStyle = true; } // Create the browser window. this._win = new BrowserWindow(options); this._id = this._win.id; if (useCustomTitleStyle) { this._win.setSheetOffset(22); // offset dialogs by the height of the custom title bar if we have any } // Set relaunch command if (isWindows && product.win32AppUserModelId && typeof this._win.setAppDetails === 'function') { this._win.setAppDetails({ appId: product.win32AppUserModelId, relaunchCommand: `"${process.execPath}" -n`, relaunchDisplayName: product.nameLong }); } if (isFullscreenOrMaximized) { this._win.maximize(); if (this.windowState.mode === WindowMode.Fullscreen) { this._win.setFullScreen(true); } if (!this._win.isVisible()) { this._win.show(); // to reduce flicker from the default window size to maximize, we only show after maximize } } this._lastFocusTime = Date.now(); // since we show directly, we need to set the last focus time too } public hasHiddenTitleBarStyle(): boolean { return this.hiddenTitleBarStyle; } public get isExtensionDevelopmentHost(): boolean { return !!this.config.extensionDevelopmentPath; } public get isExtensionTestHost(): boolean { return !!this.config.extensionTestsPath; } public get extensionDevelopmentPath(): string { return this.config.extensionDevelopmentPath; } public get config(): IWindowConfiguration { return this.currentConfig; } public get id(): number { return this._id; } public get win(): Electron.BrowserWindow { return this._win; } public setRepresentedFilename(filename: string): void { if (isMacintosh) { this.win.setRepresentedFilename(filename); } else { this.representedFilename = filename; } } public getRepresentedFilename(): string { if (isMacintosh) { return this.win.getRepresentedFilename(); } return this.representedFilename; } public focus(): void { if (!this._win) { return; } if (this._win.isMinimized()) { this._win.restore(); } this._win.focus(); } public get lastFocusTime(): number { return this._lastFocusTime; } public get backupPath(): string { return this.currentConfig ? this.currentConfig.backupPath : void 0; } public get openedWorkspace(): IWorkspaceIdentifier { return this.currentConfig ? this.currentConfig.workspace : void 0; } public get openedFolderPath(): string { return this.currentConfig ? this.currentConfig.folderPath : void 0; } public get openedFilePath(): string { return this.currentConfig && this.currentConfig.filesToOpen && this.currentConfig.filesToOpen[0] && this.currentConfig.filesToOpen[0].filePath; } public setReady(): void { this._readyState = ReadyState.READY; // inform all waiting promises that we are ready now while (this.whenReadyCallbacks.length) { this.whenReadyCallbacks.pop()(this); } } public ready(): TPromise { return new TPromise((c) => { if (this._readyState === ReadyState.READY) { return c(this); } // otherwise keep and call later when we are ready this.whenReadyCallbacks.push(c); }); } public get readyState(): ReadyState { return this._readyState; } private registerListeners(): void { const urls = ['https://marketplace.visualstudio.com/*', 'https://*.vsassets.io/*']; const headers = { 'X-Market-Client-Id': `VSCode ${pkg.version}`, 'User-Agent': `VSCode ${pkg.version}`, 'X-Market-User-Id': this.environmentService.machineUUID }; this._win.webContents.session.webRequest.onBeforeSendHeaders({ urls }, (details, cb) => { cb({ cancel: false, requestHeaders: objects.assign(details.requestHeaders, headers) }); }); // Prevent loading of svgs this._win.webContents.session.webRequest.onBeforeRequest(null, (details, callback) => { if (details.url.indexOf('.svg') > 0) { const uri = URI.parse(details.url); if (uri && !uri.scheme.match(/file/i) && (uri.path as any).endsWith('.svg')) { return callback({ cancel: true }); } } return callback({}); }); this._win.webContents.session.webRequest.onHeadersReceived(null, (details, callback) => { const contentType: string[] = (details.responseHeaders['content-type'] || details.responseHeaders['Content-Type']) as any; if (contentType && Array.isArray(contentType) && contentType.some(x => x.toLowerCase().indexOf('image/svg') >= 0)) { return callback({ cancel: true }); } return callback({ cancel: false, responseHeaders: details.responseHeaders }); }); // Remember that we loaded this._win.webContents.on('did-finish-load', () => { this._readyState = ReadyState.LOADING; // Associate properties from the load request if provided if (this.pendingLoadConfig) { this.currentConfig = this.pendingLoadConfig; this.pendingLoadConfig = null; } // To prevent flashing, we set the window visible after the page has finished to load but before Code is loaded if (!this._win.isVisible()) { if (this.windowState.mode === WindowMode.Maximized) { this._win.maximize(); } if (!this._win.isVisible()) { // maximize also makes visible this._win.show(); } } }); // App commands support this.registerNavigationListenerOn('app-command', 'browser-backward', 'browser-forward', false); // Handle code that wants to open links this._win.webContents.on('new-window', (event: Event, url: string) => { event.preventDefault(); shell.openExternal(url); }); // Window Focus this._win.on('focus', () => { this._lastFocusTime = Date.now(); }); // Window Fullscreen this._win.on('enter-full-screen', () => { this.sendWhenReady('vscode:enterFullScreen'); }); this._win.on('leave-full-screen', () => { this.sendWhenReady('vscode:leaveFullScreen'); }); // Window Failed to load this._win.webContents.on('did-fail-load', (event: Electron.Event, errorCode: number, errorDescription: string, validatedURL: string, isMainFrame: boolean) => { this.logService.warn('[electron event]: fail to load, ', errorDescription); }); // Prevent any kind of navigation triggered by the user! // But do not touch this in dev version because it will prevent "Reload" from dev tools if (this.environmentService.isBuilt) { this._win.webContents.on('will-navigate', (event: Event) => { if (event) { event.preventDefault(); } }); } // Handle configuration changes this.toDispose.push(this.configurationService.onDidUpdateConfiguration(e => this.onConfigurationUpdated())); // Handle Workspace events this.toDispose.push(this.workspaceService.onUntitledWorkspaceDeleted(e => this.onUntitledWorkspaceDeleted(e))); } private onUntitledWorkspaceDeleted(workspace: IWorkspaceIdentifier): void { // Make sure to update our workspace config if we detect that it // was deleted if (this.openedWorkspace && this.openedWorkspace.id === workspace.id) { this.currentConfig.workspace = void 0; } } private onConfigurationUpdated(): void { const newMenuBarVisibility = this.getMenuBarVisibility(); if (newMenuBarVisibility !== this.currentMenuBarVisibility) { this.currentMenuBarVisibility = newMenuBarVisibility; this.setMenuBarVisibility(newMenuBarVisibility); } // Swipe command support (macOS) if (isMacintosh) { const config = this.configurationService.getConfiguration(); if (config && config.workbench && config.workbench.editor && config.workbench.editor.swipeToNavigate) { this.registerNavigationListenerOn('swipe', 'left', 'right', true); } else { this._win.removeAllListeners('swipe'); } } }; private registerNavigationListenerOn(command: 'swipe' | 'app-command', back: 'left' | 'browser-backward', forward: 'right' | 'browser-forward', acrossEditors: boolean) { this._win.on(command as 'swipe' /* | 'app-command' */, (e: Electron.Event, cmd: string) => { if (this.readyState !== ReadyState.READY) { return; // window must be ready } if (cmd === back) { this.send('vscode:runAction', acrossEditors ? 'workbench.action.openPreviousRecentlyUsedEditor' : 'workbench.action.navigateBack'); } else if (cmd === forward) { this.send('vscode:runAction', acrossEditors ? 'workbench.action.openNextRecentlyUsedEditor' : 'workbench.action.navigateForward'); } }); } public load(config: IWindowConfiguration, isReload?: boolean): void { // If this is the first time the window is loaded, we associate the paths // directly with the window because we assume the loading will just work if (this.readyState === ReadyState.NONE) { this.currentConfig = config; } // Otherwise, the window is currently showing a folder and if there is an // unload handler preventing the load, we cannot just associate the paths // because the loading might be vetoed. Instead we associate it later when // the window load event has fired. else { this.pendingLoadConfig = config; this._readyState = ReadyState.NAVIGATING; } // Clear Document Edited if needed if (isMacintosh && this._win.isDocumentEdited()) { if (!isReload || !this.backupService.isHotExitEnabled()) { this._win.setDocumentEdited(false); } } // Clear Title and Filename if needed if (!isReload) { if (this.getRepresentedFilename()) { this.setRepresentedFilename(''); } this._win.setTitle(product.nameLong); } // Load URL this._win.loadURL(this.getUrl(config)); // Make window visible if it did not open in N seconds because this indicates an error // Only do this when running out of sources and not when running tests if (!this.environmentService.isBuilt && !this.environmentService.extensionTestsPath) { this.showTimeoutHandle = setTimeout(() => { if (this._win && !this._win.isVisible() && !this._win.isMinimized()) { this._win.show(); this._win.focus(); this._win.webContents.openDevTools(); } }, 10000); } // (--prof-startup) save profile to disk const { profileStartup } = this.environmentService; if (profileStartup) { stopProfiling(profileStartup.dir, profileStartup.prefix).done(undefined, err => this.logService.error(err)); } } public reload(configuration?: IWindowConfiguration, cli?: ParsedArgs): void { // If config is not provided, copy our current one if (!configuration) { configuration = objects.mixin({}, this.currentConfig); } // Delete some properties we do not want during reload delete configuration.filesToOpen; delete configuration.filesToCreate; delete configuration.filesToDiff; // Some configuration things get inherited if the window is being reloaded and we are // in extension development mode. These options are all development related. if (this.isExtensionDevelopmentHost && cli) { configuration.verbose = cli.verbose; configuration.debugPluginHost = cli.debugPluginHost; configuration.debugBrkPluginHost = cli.debugBrkPluginHost; configuration.debugId = cli.debugId; configuration['extensions-dir'] = cli['extensions-dir']; } configuration.isInitialStartup = false; // since this is a reload // Load config this.load(configuration, true); } private getUrl(windowConfiguration: IWindowConfiguration): string { // Set zoomlevel const windowConfig = this.configurationService.getConfiguration('window'); const zoomLevel = windowConfig && windowConfig.zoomLevel; if (typeof zoomLevel === 'number') { windowConfiguration.zoomLevel = zoomLevel; } // Set fullscreen state windowConfiguration.fullscreen = this._win.isFullScreen(); // Set Accessibility Config windowConfiguration.highContrast = isWindows && systemPreferences.isInvertedColorScheme() && (!windowConfig || windowConfig.autoDetectHighContrast); windowConfiguration.accessibilitySupport = app.isAccessibilitySupportEnabled(); // Set Keyboard Config windowConfiguration.isISOKeyboard = KeyboardLayoutMonitor.INSTANCE.isISOKeyboard(); // Theme windowConfiguration.baseTheme = this.getBaseTheme(); windowConfiguration.backgroundColor = this.getBackgroundColor(); // Perf Counters windowConfiguration.perfStartTime = global.perfStartTime; windowConfiguration.perfAppReady = global.perfAppReady; windowConfiguration.perfWindowLoadTime = Date.now(); // Config (combination of process.argv and window configuration) const environment = parseArgs(process.argv); const config = objects.assign(environment, windowConfiguration); for (let key in config) { if (!config[key]) { delete config[key]; // only send over properties that have a true value } } return `${require.toUrl('vs/workbench/electron-browser/bootstrap/index.html')}?config=${encodeURIComponent(JSON.stringify(config))}`; } private getBaseTheme(): string { if (isWindows && systemPreferences.isInvertedColorScheme()) { return 'hc-black'; } const theme = this.storageService.getItem(CodeWindow.themeStorageKey, 'vs-dark'); return theme.split(' ')[0]; } private getBackgroundColor(): string { if (isWindows && systemPreferences.isInvertedColorScheme()) { return CodeWindow.DEFAULT_BG_HC_BLACK; } const background = this.storageService.getItem(CodeWindow.themeBackgroundStorageKey, null); if (!background) { const baseTheme = this.getBaseTheme(); return baseTheme === 'hc-black' ? CodeWindow.DEFAULT_BG_HC_BLACK : (baseTheme === 'vs' ? CodeWindow.DEFAULT_BG_LIGHT : CodeWindow.DEFAULT_BG_DARK); } return background; } public serializeWindowState(): IWindowState { // fullscreen gets special treatment if (this._win.isFullScreen()) { const display = screen.getDisplayMatching(this.getBounds()); return { mode: WindowMode.Fullscreen, display: display ? display.id : void 0, // still carry over window dimensions from previous sessions! width: this.windowState.width, height: this.windowState.height, x: this.windowState.x, y: this.windowState.y }; } const state: IWindowState = Object.create(null); let mode: WindowMode; // get window mode if (!isMacintosh && this._win.isMaximized()) { mode = WindowMode.Maximized; } else { mode = WindowMode.Normal; } // we don't want to save minimized state, only maximized or normal if (mode === WindowMode.Maximized) { state.mode = WindowMode.Maximized; } else { state.mode = WindowMode.Normal; } // only consider non-minimized window states if (mode === WindowMode.Normal || mode === WindowMode.Maximized) { const bounds = this.getBounds(); state.x = bounds.x; state.y = bounds.y; state.width = bounds.width; state.height = bounds.height; } return state; } private restoreWindowState(state?: IWindowState): IWindowState { if (state) { try { state = this.validateWindowState(state); } catch (err) { this.logService.log(`Unexpected error validating window state: ${err}\n${err.stack}`); // somehow display API can be picky about the state to validate } } if (!state) { state = defaultWindowState(); } return state; } private validateWindowState(state: IWindowState): IWindowState { if (!state) { return null; } if ([state.x, state.y, state.width, state.height].some(n => typeof n !== 'number')) { return null; } if (state.width <= 0 || state.height <= 0) { return null; } const displays = screen.getAllDisplays(); // Single Monitor: be strict about x/y positioning if (displays.length === 1) { const displayBounds = displays[0].bounds; // Careful with maximized: in that mode x/y can well be negative! if (state.mode !== WindowMode.Maximized && displayBounds.width > 0 && displayBounds.height > 0 /* Linux X11 sessions sometimes report wrong display bounds */) { if (state.x < displayBounds.x) { state.x = displayBounds.x; // prevent window from falling out of the screen to the left } if (state.y < displayBounds.y) { state.y = displayBounds.y; // prevent window from falling out of the screen to the top } if (state.x > (displayBounds.x + displayBounds.width)) { state.x = displayBounds.x; // prevent window from falling out of the screen to the right } if (state.y > (displayBounds.y + displayBounds.height)) { state.y = displayBounds.y; // prevent window from falling out of the screen to the bottom } if (state.width > displayBounds.width) { state.width = displayBounds.width; // prevent window from exceeding display bounds width } if (state.height > displayBounds.height) { state.height = displayBounds.height; // prevent window from exceeding display bounds height } } if (state.mode === WindowMode.Maximized) { return defaultWindowState(WindowMode.Maximized); // when maximized, make sure we have good values when the user restores the window } return state; } // Multi Montior (fullscreen): try to find the previously used display if (state.display && state.mode === WindowMode.Fullscreen) { const display = displays.filter(d => d.id === state.display)[0]; if (display && display.bounds && typeof display.bounds.x === 'number' && typeof display.bounds.y === 'number') { const defaults = defaultWindowState(WindowMode.Fullscreen); // make sure we have good values when the user restores the window defaults.x = display.bounds.x; // carefull to use displays x/y position so that the window ends up on the correct monitor defaults.y = display.bounds.y; return defaults; } } // Multi Monitor (non-fullscreen): be less strict because metrics can be crazy const bounds = { x: state.x, y: state.y, width: state.width, height: state.height }; const display = screen.getDisplayMatching(bounds); if (display && display.bounds.x + display.bounds.width > bounds.x && display.bounds.y + display.bounds.height > bounds.y) { if (state.mode === WindowMode.Maximized) { const defaults = defaultWindowState(WindowMode.Maximized); // when maximized, make sure we have good values when the user restores the window defaults.x = state.x; // carefull to keep x/y position so that the window ends up on the correct monitor defaults.y = state.y; return defaults; } return state; } return null; } public getBounds(): Electron.Rectangle { const pos = this._win.getPosition(); const dimension = this._win.getSize(); return { x: pos[0], y: pos[1], width: dimension[0], height: dimension[1] }; } public toggleFullScreen(): void { const willBeFullScreen = !this._win.isFullScreen(); // set fullscreen flag on window this._win.setFullScreen(willBeFullScreen); // respect configured menu bar visibility or default to toggle if not set this.setMenuBarVisibility(this.currentMenuBarVisibility, false); } private getMenuBarVisibility(): MenuBarVisibility { const windowConfig = this.configurationService.getConfiguration('window'); if (!windowConfig || !windowConfig.menuBarVisibility) { return 'default'; } let menuBarVisibility = windowConfig.menuBarVisibility; if (['visible', 'toggle', 'hidden'].indexOf(menuBarVisibility) < 0) { menuBarVisibility = 'default'; } return menuBarVisibility; } public setMenuBarVisibility(visibility: MenuBarVisibility, notify: boolean = true): void { if (isMacintosh) { return; // ignore for macOS platform } const isFullscreen = this._win.isFullScreen(); switch (visibility) { case ('default'): this._win.setMenuBarVisibility(!isFullscreen); this._win.setAutoHideMenuBar(isFullscreen); break; case ('visible'): this._win.setMenuBarVisibility(true); this._win.setAutoHideMenuBar(false); break; case ('toggle'): this._win.setMenuBarVisibility(false); this._win.setAutoHideMenuBar(true); if (notify) { this.send('vscode:showInfoMessage', nls.localize('hiddenMenuBar', "You can still access the menu bar by pressing the **Alt** key.")); }; break; case ('hidden'): // for some weird reason that I have no explanation for, the menu bar is not hiding when calling // this without timeout (see https://github.com/Microsoft/vscode/issues/19777). there seems to be // a timing issue with us opening the first window and the menu bar getting created. somehow the // fact that we want to hide the menu without being able to bring it back via Alt key makes Electron // still show the menu. Unable to reproduce from a simple Hello World application though... setTimeout(() => { this._win.setMenuBarVisibility(false); this._win.setAutoHideMenuBar(false); }); break; }; } public onWindowTitleDoubleClick(): void { // Respect system settings on mac with regards to title click on windows title if (isMacintosh) { const action = systemPreferences.getUserDefault('AppleActionOnDoubleClick', 'string'); switch (action) { case 'Minimize': this.win.minimize(); break; case 'None': break; case 'Maximize': default: this.win.maximize(); } } // Linux/Windows: just toggle maximize/minimized state else { if (this.win.isMaximized()) { this.win.unmaximize(); } else { this.win.maximize(); } } } public close(): void { if (this._win) { this._win.close(); } } public sendWhenReady(channel: string, ...args: any[]): void { this.ready().then(() => { this.send(channel, ...args); }); } public send(channel: string, ...args: any[]): void { this._win.webContents.send(channel, ...args); } public dispose(): void { if (this.showTimeoutHandle) { clearTimeout(this.showTimeoutHandle); } this.toDispose = dispose(this.toDispose); this._win = null; // Important to dereference the window object to allow for GC } }