Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
fe361082
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
fe361082
编写于
4月 04, 2020
作者:
D
Daniel Imms
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add dispose checks to env var collections
Fixes #94066
上级
7464576c
变更
1
显示空白变更内容
内联
并排
Showing
1 changed file
with
21 addition
and
2 deletion
+21
-2
src/vs/workbench/api/common/extHostTerminalService.ts
src/vs/workbench/api/common/extHostTerminalService.ts
+21
-2
未找到文件。
src/vs/workbench/api/common/extHostTerminalService.ts
浏览文件 @
fe361082
...
...
@@ -645,6 +645,8 @@ export abstract class BaseExtHostTerminalService implements IExtHostTerminalServ
export
class
EnvironmentVariableCollection
implements
vscode
.
EnvironmentVariableCollection
{
readonly
map
:
Map
<
string
,
vscode
.
EnvironmentVariableMutator
>
=
new
Map
();
private
_disposed
=
false
;
protected
readonly
_onDidChangeCollection
:
Emitter
<
void
>
=
new
Emitter
<
void
>
();
get
onDidChangeCollection
():
Event
<
void
>
{
return
this
.
_onDidChangeCollection
&&
this
.
_onDidChangeCollection
.
event
;
}
...
...
@@ -656,18 +658,22 @@ export class EnvironmentVariableCollection implements vscode.EnvironmentVariable
}
get
size
():
number
{
this
.
_checkDisposed
();
return
this
.
map
.
size
;
}
replace
(
variable
:
string
,
value
:
string
):
void
{
this
.
_checkDisposed
();
this
.
_setIfDiffers
(
variable
,
{
value
,
type
:
EnvironmentVariableMutatorType
.
Replace
});
}
append
(
variable
:
string
,
value
:
string
):
void
{
this
.
_checkDisposed
();
this
.
_setIfDiffers
(
variable
,
{
value
,
type
:
EnvironmentVariableMutatorType
.
Append
});
}
prepend
(
variable
:
string
,
value
:
string
):
void
{
this
.
_checkDisposed
();
this
.
_setIfDiffers
(
variable
,
{
value
,
type
:
EnvironmentVariableMutatorType
.
Prepend
});
}
...
...
@@ -680,27 +686,40 @@ export class EnvironmentVariableCollection implements vscode.EnvironmentVariable
}
get
(
variable
:
string
):
vscode
.
EnvironmentVariableMutator
|
undefined
{
this
.
_checkDisposed
();
return
this
.
map
.
get
(
variable
);
}
forEach
(
callback
:
(
variable
:
string
,
mutator
:
vscode
.
EnvironmentVariableMutator
,
collection
:
vscode
.
EnvironmentVariableCollection
)
=>
any
,
thisArg
?:
any
):
void
{
this
.
_checkDisposed
();
this
.
map
.
forEach
((
value
,
key
)
=>
callback
(
key
,
value
,
this
));
}
delete
(
variable
:
string
):
void
{
this
.
_checkDisposed
();
this
.
map
.
delete
(
variable
);
this
.
_onDidChangeCollection
.
fire
();
}
clear
():
void
{
this
.
_checkDisposed
();
this
.
map
.
clear
();
this
.
_onDidChangeCollection
.
fire
();
}
dispose
():
void
{
if
(
!
this
.
_disposed
)
{
this
.
_disposed
=
true
;
this
.
map
.
clear
();
this
.
_onDidChangeCollection
.
fire
();
}
}
protected
_checkDisposed
()
{
if
(
this
.
_disposed
)
{
throw
new
Error
(
'
EnvironmentVariableCollection has already been disposed
'
);
}
}
}
export
class
WorkerExtHostTerminalService
extends
BaseExtHostTerminalService
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录