From fc54f4b15d752c18311255c12ab186361406afb7 Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Wed, 14 Sep 2016 17:54:39 +0200 Subject: [PATCH] use opener service in extension editor fixes #11309 --- .../extensions/electron-browser/extensionEditor.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts index 195c970b017..ab5fab917dd 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts @@ -42,6 +42,7 @@ import { Keybinding } from 'vs/base/common/keyCodes'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { DomScrollableElement } from 'vs/base/browser/ui/scrollbar/scrollableElement'; import { IMessageService } from 'vs/platform/message/common/message'; +import { IOpenerService } from 'vs/platform/opener/common/opener'; function renderBody(body: string): string { return ` @@ -140,7 +141,8 @@ export class ExtensionEditor extends BaseEditor { @IThemeService private themeService: IThemeService, @IWorkbenchEditorService private editorService: IWorkbenchEditorService, @IKeybindingService private keybindingService: IKeybindingService, - @IMessageService private messageService: IMessageService + @IMessageService private messageService: IMessageService, + @IOpenerService private openerService: IOpenerService ) { super(ExtensionEditor.ID, telemetryService); this._highlight = null; @@ -276,9 +278,9 @@ export class ExtensionEditor extends BaseEditor { webview.style(this.themeService.getColorTheme()); webview.contents = [body]; - const linkListener = webview.onDidClickLink(link => shell.openExternal(link.toString(true))); - const themeListener = this.themeService.onDidColorThemeChange(themeId => webview.style(themeId)); - this.contentDisposables.push(webview, linkListener, themeListener); + webview.onDidClickLink(link => this.openerService.open(link), null, this.contentDisposables); + this.themeService.onDidColorThemeChange(themeId => webview.style(themeId), null, this.contentDisposables); + this.contentDisposables.push(webview); }) .then(null, () => { const p = append(this.content, $('p')); -- GitLab