From fa9f4138de6c4240d3ed14d2338c91f945cc4c25 Mon Sep 17 00:00:00 2001 From: PM Extra Date: Mon, 24 Feb 2020 01:38:58 +0800 Subject: [PATCH] Fix a small bug of JsonValidation The origin condition expression `(!strings.startsWith(uri, 'https:/') && strings.startsWith(uri, 'https:/'))` is always false. According to the context code, it should be `(!strings.startsWith(uri, 'http://') && !strings.startsWith(uri, 'https://'))` instead. --- src/vs/workbench/api/common/jsonValidationExtensionPoint.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/api/common/jsonValidationExtensionPoint.ts b/src/vs/workbench/api/common/jsonValidationExtensionPoint.ts index 66b60ca3743..99c5c717bcc 100644 --- a/src/vs/workbench/api/common/jsonValidationExtensionPoint.ts +++ b/src/vs/workbench/api/common/jsonValidationExtensionPoint.ts @@ -69,7 +69,7 @@ export class JSONValidationExtensionPoint { } catch (e) { collector.error(nls.localize('invalid.url.fileschema', "'configuration.jsonValidation.url' is an invalid relative URL: {0}", e.message)); } - } else if (!strings.startsWith(uri, 'https:/') && strings.startsWith(uri, 'https:/')) { + } else if (!strings.startsWith(uri, 'http://') && !strings.startsWith(uri, 'https://')) { collector.error(nls.localize('invalid.url.schema', "'configuration.jsonValidation.url' must start with 'http:', 'https:' or './' to reference schemas located in the extension")); return; } -- GitLab