diff --git a/extensions/emmet/npm-shrinkwrap.json b/extensions/emmet/npm-shrinkwrap.json index d05e049a4c5873552ac70e2fd758db19aac22f85..d3f6f8d12fbf036a85b3f143694bbbfce6d8f378 100644 --- a/extensions/emmet/npm-shrinkwrap.json +++ b/extensions/emmet/npm-shrinkwrap.json @@ -38,9 +38,9 @@ "resolved": "https://registry.npmjs.org/image-size/-/image-size-0.5.5.tgz" }, "vscode-emmet-helper": { - "version": "1.0.12", - "from": "vscode-emmet-helper@>=1.0.12 <2.0.0", - "resolved": "https://registry.npmjs.org/vscode-emmet-helper/-/vscode-emmet-helper-1.0.12.tgz" + "version": "1.0.13", + "from": "vscode-emmet-helper@>=1.0.13 <2.0.0", + "resolved": "https://registry.npmjs.org/vscode-emmet-helper/-/vscode-emmet-helper-1.0.13.tgz" }, "vscode-languageserver-types": { "version": "3.3.0", diff --git a/extensions/emmet/package.json b/extensions/emmet/package.json index 866c77d69c8ebc5e521188fad65e089765cc47c4..7415c94e07c6deb4d572aea0e0f3872fc6e4ae52 100644 --- a/extensions/emmet/package.json +++ b/extensions/emmet/package.json @@ -212,7 +212,7 @@ "@emmetio/html-matcher": "^0.3.1", "@emmetio/css-parser": "^0.4.0", "@emmetio/math-expression": "^0.1.1", - "vscode-emmet-helper": "^1.0.12", + "vscode-emmet-helper": "^1.0.13", "vscode-languageserver-types": "^3.0.3", "image-size": "^0.5.2", "vscode-nls": "2.0.2" diff --git a/extensions/emmet/src/abbreviationActions.ts b/extensions/emmet/src/abbreviationActions.ts index e9a0a636ecd92bb61d470a00dd8c900eaae38c00..1300495162c0662e954ed9d1b673f216c73ce6a3 100644 --- a/extensions/emmet/src/abbreviationActions.ts +++ b/extensions/emmet/src/abbreviationActions.ts @@ -134,17 +134,6 @@ export function expandEmmetAbbreviation(args): Thenable { } } - // Dont try to expand abbreviations when cursor is before/after ; or : or in the middle of a word - // Fix for https://github.com/Microsoft/vscode/issues/1623 in new emmet - if (isStyleSheet(syntax) && !/\s!$/.test(textTillPosition)) { - const charAtPosition = currentLine.substr(position.character, 1); - if (textTillPosition.endsWith(':') - || textTillPosition.endsWith(';') - || (charAtPosition && !/\s/.test(charAtPosition))) { - return [null, '', []]; - } - } - let extractedResults = extractAbbreviation(editor.document, position); if (!extractedResults) { return [null, '', []]; diff --git a/extensions/emmet/src/defaultCompletionProvider.ts b/extensions/emmet/src/defaultCompletionProvider.ts index 7fd535a341855a42d7a5ee3a8bc147cfcd37f989..28adbadfb7a8ce0088e26d35b089b01798941d2d 100644 --- a/extensions/emmet/src/defaultCompletionProvider.ts +++ b/extensions/emmet/src/defaultCompletionProvider.ts @@ -33,7 +33,7 @@ export class DefaultCompletionItemProvider implements vscode.CompletionItemProvi let result: vscode.CompletionList = doComplete(document, position, syntax, getEmmetConfiguration()); let newItems: vscode.CompletionItem[] = []; - if (result.items) { + if (result && result.items) { result.items.forEach(item => { let newItem = new vscode.CompletionItem(item.label); newItem.documentation = item.documentation;