From f9a2ff4ef865ebe5731aaf6b450f45a65dc96548 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Moreno?= Date: Mon, 22 Aug 2016 17:51:41 +0200 Subject: [PATCH] proper uri usage fixes #10609 --- .../extensionManagement/node/extensionManagementService.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/vs/platform/extensionManagement/node/extensionManagementService.ts b/src/vs/platform/extensionManagement/node/extensionManagementService.ts index e52a58d8daa..4ca370603ef 100644 --- a/src/vs/platform/extensionManagement/node/extensionManagementService.ts +++ b/src/vs/platform/extensionManagement/node/extensionManagementService.ts @@ -19,6 +19,7 @@ import { Limiter } from 'vs/base/common/async'; import Event, { Emitter } from 'vs/base/common/event'; import * as semver from 'semver'; import { groupBy, values } from 'vs/base/common/collections'; +import URI from 'vs/base/common/uri'; function parseManifest(raw: string): TPromise<{ manifest: IExtensionManifest; metadata: IGalleryMetadata; }> { return new Promise((c, e) => { @@ -144,7 +145,7 @@ export class ExtensionManagementService implements IExtensionManagementService { .then(({ manifest }) => { return pfs.readdir(extensionPath).then(children => { const readme = children.filter(child => /^readme(\.txt|\.md|)$/i.test(child))[0]; - const readmeUrl = readme ? `file://${ extensionPath }/${ readme }` : null; + const readmeUrl = readme ? URI.file(path.join(extensionPath, readme)).toString() : null; const local: ILocalExtension = { id, manifest, metadata, path: extensionPath, readmeUrl }; const rawManifest = assign(manifest, { __metadata: metadata }); @@ -196,7 +197,7 @@ export class ExtensionManagementService implements IExtensionManagementService { const each = () => pfs.readdir(extensionPath).then(children => { const readme = children.filter(child => /^readme(\.txt|\.md|)$/i.test(child))[0]; - const readmeUrl = readme ? `file://${ extensionPath }/${ readme }` : null; + const readmeUrl = readme ? URI.file(path.join(extensionPath, readme)).toString() : null; return pfs.readFile(path.join(extensionPath, 'package.json'), 'utf8') .then(raw => parseManifest(raw)) -- GitLab