From f9383959360a8d17c5ff6a10ce68a61938828435 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Tue, 11 Feb 2020 16:59:11 +0100 Subject: [PATCH] build - linux cannot run playwright in docker containers, so disable it --- .../linux/product-build-linux.yml | 34 ++++++++++++------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/build/azure-pipelines/linux/product-build-linux.yml b/build/azure-pipelines/linux/product-build-linux.yml index fe7781b481e..46e112b79d2 100644 --- a/build/azure-pipelines/linux/product-build-linux.yml +++ b/build/azure-pipelines/linux/product-build-linux.yml @@ -104,12 +104,16 @@ steps: displayName: Run unit tests (Electron) condition: and(succeeded(), eq(variables['VSCODE_STEP_ON_IT'], 'false')) -- script: | - set -e - DISPLAY=:10 yarn test-browser --build --browser chromium - continueOnError: true - displayName: Run unit tests (Browser) - condition: and(succeeded(), eq(variables['VSCODE_STEP_ON_IT'], 'false')) +# Playwright currently does not run on the Linux docker container we use +# given our dependencies. Someone with some energy should follow up and +# find out what is still missing to get Chrome started in the container. +# Refs: https://github.com/microsoft/vscode-linux-build-agent/blob/master/x64/Dockerfile +# +# - script: | +# set -e +# DISPLAY=:10 yarn test-browser --build --browser chromium +# displayName: Run unit tests (Browser) +# condition: and(succeeded(), eq(variables['VSCODE_STEP_ON_IT'], 'false')) - script: | # Figure out the full absolute path of the product we just built @@ -124,13 +128,17 @@ steps: displayName: Run integration tests (Electron) condition: and(succeeded(), eq(variables['VSCODE_STEP_ON_IT'], 'false')) -- script: | - set -e - VSCODE_REMOTE_SERVER_PATH="$(agent.builddirectory)/vscode-reh-web-linux-x64" \ - DISPLAY=:10 ./resources/server/test/test-web-integration.sh --browser chromium - continueOnError: true - displayName: Run integration tests (Browser) - condition: and(succeeded(), eq(variables['VSCODE_STEP_ON_IT'], 'false')) +# Playwright currently does not run on the Linux docker container we use +# given our dependencies. Someone with some energy should follow up and +# find out what is still missing to get Chrome started in the container. +# Refs: https://github.com/microsoft/vscode-linux-build-agent/blob/master/x64/Dockerfile +# - script: | +# set -e +# VSCODE_REMOTE_SERVER_PATH="$(agent.builddirectory)/vscode-reh-web-linux-x64" \ +# DISPLAY=:10 ./resources/server/test/test-web-integration.sh --browser chromium +# continueOnError: true +# displayName: Run integration tests (Browser) +# condition: and(succeeded(), eq(variables['VSCODE_STEP_ON_IT'], 'false')) - script: | set -e -- GitLab