Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
f6b128d8
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f6b128d8
编写于
1月 26, 2018
作者:
R
Ramya Achutha Rao
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Avoid querying gallery when not configured fixes #42204
上级
96022b64
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
24 addition
and
5 deletion
+24
-5
src/vs/workbench/parts/extensions/electron-browser/extensionTipsService.ts
...parts/extensions/electron-browser/extensionTipsService.ts
+8
-1
src/vs/workbench/parts/extensions/test/electron-browser/extensionsTipsService.test.ts
...sions/test/electron-browser/extensionsTipsService.test.ts
+16
-4
未找到文件。
src/vs/workbench/parts/extensions/electron-browser/extensionTipsService.ts
浏览文件 @
f6b128d8
...
...
@@ -71,7 +71,7 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
)
{
super
();
if
(
!
this
.
_galleryService
.
isEnabled
()
||
this
.
environmentService
.
extensionDevelopmentPath
)
{
if
(
!
this
.
isEnabled
()
)
{
return
;
}
...
...
@@ -85,6 +85,10 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
this
.
_register
(
this
.
contextService
.
onDidChangeWorkspaceFolders
(
e
=>
this
.
onWorkspaceFoldersChanged
(
e
)));
}
private
isEnabled
():
boolean
{
return
this
.
_galleryService
.
isEnabled
()
&&
!
this
.
environmentService
.
extensionDevelopmentPath
;
}
getAllRecommendationsWithReason
():
{
[
id
:
string
]:
string
;
}
{
let
output
:
{
[
id
:
string
]:
string
;
}
=
Object
.
create
(
null
);
this
.
_allWorkspaceRecommendedExtensions
.
forEach
(
x
=>
output
[
x
.
toLowerCase
()]
=
localize
(
'
workspaceRecommendation
'
,
"
This extension is recommended by users of the current workspace.
"
));
...
...
@@ -94,6 +98,9 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
}
getWorkspaceRecommendations
():
TPromise
<
string
[]
>
{
if
(
!
this
.
isEnabled
())
{
return
TPromise
.
as
([]);
}
const
workspace
=
this
.
contextService
.
getWorkspace
();
return
TPromise
.
join
([
this
.
resolveWorkspaceRecommendations
(
workspace
),
...
workspace
.
folders
.
map
(
workspaceFolder
=>
this
.
resolveWorkspaceFolderRecommendations
(
workspaceFolder
))])
.
then
(
recommendations
=>
{
...
...
src/vs/workbench/parts/extensions/test/electron-browser/extensionsTipsService.test.ts
浏览文件 @
f6b128d8
...
...
@@ -268,22 +268,34 @@ suite('ExtensionsTipsService Test', () => {
function
testNoPromptForValidRecommendations
(
recommendations
:
string
[])
{
return
setUpFolderWorkspace
(
'
myFolder
'
,
recommendations
).
then
(()
=>
{
testObject
=
instantiationService
.
createInstance
(
ExtensionTipsService
);
const
promise
=
testObject
.
promptWorkspaceRecommendationsPromise
||
testObject
.
getWorkspaceRecommendations
();
return
promise
.
then
(()
=>
{
return
testObject
.
promptWorkspaceRecommendationsPromise
.
then
(()
=>
{
assert
.
equal
(
Object
.
keys
(
testObject
.
getAllRecommendationsWithReason
()).
length
,
recommendations
.
length
);
assert
.
ok
(
!
prompted
);
});
});
}
function
testNoPromptOrRecommendationsForValidRecommendations
(
recommendations
:
string
[])
{
return
setUpFolderWorkspace
(
'
myFolder
'
,
mockTestData
.
validRecommendedExtensions
).
then
(()
=>
{
testObject
=
instantiationService
.
createInstance
(
ExtensionTipsService
);
assert
.
equal
(
!
testObject
.
promptWorkspaceRecommendationsPromise
,
true
);
assert
.
ok
(
!
prompted
);
return
testObject
.
getWorkspaceRecommendations
().
then
(()
=>
{
assert
.
equal
(
Object
.
keys
(
testObject
.
getAllRecommendationsWithReason
()).
length
,
0
);
assert
.
ok
(
!
prompted
);
});
});
}
test
(
'
ExtensionTipsService: No Prompt for valid workspace recommendations when galleryService is absent
'
,
()
=>
{
instantiationService
.
stub
(
IExtensionGalleryService
,
'
isEnabled
'
,
false
);
return
testNoPromptForValidRecommendations
(
mockTestData
.
validRecommendedExtensions
);
return
testNoPrompt
OrRecommendations
ForValidRecommendations
(
mockTestData
.
validRecommendedExtensions
);
});
test
(
'
ExtensionTipsService: No Prompt for valid workspace recommendations during extension development
'
,
()
=>
{
instantiationService
.
stub
(
IEnvironmentService
,
{
extensionDevelopmentPath
:
true
});
return
testNoPromptForValidRecommendations
(
mockTestData
.
validRecommendedExtensions
);
return
testNoPrompt
OrRecommendations
ForValidRecommendations
(
mockTestData
.
validRecommendedExtensions
);
});
test
(
'
ExtensionTipsService: No workspace recommendations or prompts when extensions.json has empty array
'
,
()
=>
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录