From f59bbd4235e4a65e062cad367362768a5830b49e Mon Sep 17 00:00:00 2001 From: Ryan Clarke Date: Thu, 22 Oct 2020 07:07:41 -0400 Subject: [PATCH] Add enum key to description when there are labels --- .../preferences/browser/settingsTree.ts | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/vs/workbench/contrib/preferences/browser/settingsTree.ts b/src/vs/workbench/contrib/preferences/browser/settingsTree.ts index da55e02ffb8..42f98915c9f 100644 --- a/src/vs/workbench/contrib/preferences/browser/settingsTree.ts +++ b/src/vs/workbench/contrib/preferences/browser/settingsTree.ts @@ -1328,17 +1328,20 @@ export class SettingEnumRenderer extends AbstractSettingRenderer implements ITre const displayOptions = dataElement.setting.enum! .map(String) .map(escapeInvisibleChars) - .map((data, index) => { - text: enumItemLabels && enumItemLabels[index] ? enumItemLabels[index] : data, - description: (enumDescriptions && enumDescriptions[index] && (enumDescriptionsAreMarkdown ? fixSettingLinks(enumDescriptions[index], false) : enumDescriptions[index])), - descriptionIsMarkdown: enumDescriptionsAreMarkdown, - descriptionMarkdownActionHandler: { - callback: (content) => { - this._openerService.open(content).catch(onUnexpectedError); + .map((data, index) => { + const description = (enumDescriptions && enumDescriptions[index] && (enumDescriptionsAreMarkdown ? fixSettingLinks(enumDescriptions[index], false) : enumDescriptions[index])); + return { + text: enumItemLabels && enumItemLabels[index] ? enumItemLabels[index] : data, + description: enumItemLabels && enumItemLabels[index] ? `[${data}] ${description}` : description, + descriptionIsMarkdown: enumDescriptionsAreMarkdown, + descriptionMarkdownActionHandler: { + callback: (content) => { + this._openerService.open(content).catch(onUnexpectedError); + }, + disposeables: disposables }, - disposeables: disposables - }, - decoratorRight: (data === dataElement.defaultValue ? localize('settings.Default', "default") : '') + decoratorRight: (data === dataElement.defaultValue ? localize('settings.Default', "default") : '') + }; }); template.selectBox.setOptions(displayOptions); -- GitLab