diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsViewlet.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsViewlet.ts index 563664eed0c4c4dd060c3049646a37cf8be85efc..8aa56caa2ed2e65ddd4e688a40b4d37e49f01f74 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionsViewlet.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsViewlet.ts @@ -116,7 +116,7 @@ export class ExtensionsViewlet extends Viewlet implements IExtensionsViewlet { chain(this.list.onSelectionChange) .map(e => e.elements[0]) .filter(e => !!e) - .on(this.openExtension, this, this.disposables); + .on(this.extensionsWorkbenchService.open, this, this.disposables); return TPromise.as(null); } @@ -296,11 +296,6 @@ export class ExtensionsViewlet extends Viewlet implements IExtensionsViewlet { .then(result => new PagedModel(result)); } - private openExtension(extension: IExtension): void { - this.editorService.openEditor(this.instantiationService.createInstance(ExtensionsInput, extension)) - .done(null, err => this.onError(err)); - } - private onEnter(): void { this.list.setSelection(...this.list.getFocus()); } diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts index 918aafc03a16690c98f0b4720756c7bcee8b66d5..1f7616f5410f8e14c79dc3858f051d3c6d51be7f 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts @@ -368,6 +368,11 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService { }); } + open(extension: IExtension): void { + this.editorService.openEditor(this.instantiationService.createInstance(ExtensionsInput, extension)) + .done(null, err => this.onError(err)); + } + private fromGallery(gallery: IGalleryExtension): Extension { const installedByGalleryId = index(this.installed, e => e.local.metadata ? e.local.metadata.id : ''); const id = gallery.id; @@ -620,15 +625,10 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService { } const extension = result.firstPage[0]; - this.openExtension(extension); + this.open(extension); }); } - private openExtension(extension: IExtension): void { - this.editorService.openEditor(this.instantiationService.createInstance(ExtensionsInput, extension)) - .done(null, err => this.onError(err)); - } - dispose(): void { this.disposables = dispose(this.disposables); }