From f478f3e0fe19775d78a330b9b42687c2521698f5 Mon Sep 17 00:00:00 2001
From: isidor <inikolic@microsoft.com>
Date: Fri, 30 Nov 2018 16:01:38 +0100
Subject: [PATCH] debug trees: minor polish

---
 .../parts/debug/electron-browser/variablesView.ts        | 9 ++-------
 .../parts/debug/electron-browser/watchExpressionsView.ts | 2 +-
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/vs/workbench/parts/debug/electron-browser/variablesView.ts b/src/vs/workbench/parts/debug/electron-browser/variablesView.ts
index b22db68a531..62271136f01 100644
--- a/src/vs/workbench/parts/debug/electron-browser/variablesView.ts
+++ b/src/vs/workbench/parts/debug/electron-browser/variablesView.ts
@@ -32,9 +32,6 @@ import { onUnexpectedError } from 'vs/base/common/errors';
 
 const $ = dom.$;
 
-// TODO@Isidor Remember expanded elements when there are some (otherwise don't override/erase the previous ones)
-// Just give the identity provider to the tree and that should solve it
-
 export const variableSetEmitter = new Emitter<void>();
 
 export class VariablesView extends ViewletPanel {
@@ -126,10 +123,9 @@ export class VariablesView extends ViewletPanel {
 	}
 
 	private onMouseDblClick(e: ITreeMouseEvent<IExpression | IScope>): void {
-		const element = e.element;
 		const session = this.debugService.getViewModel().focusedSession;
-		if (element instanceof Variable && session.capabilities.supportsSetVariable) {
-			this.debugService.getViewModel().setSelectedExpression(element);
+		if (e.element instanceof Variable && session.capabilities.supportsSetVariable) {
+			this.debugService.getViewModel().setSelectedExpression(e.element);
 		}
 	}
 
@@ -258,7 +254,6 @@ export class VariablesRenderer extends AbstractExpressionsRenderer {
 }
 
 class VariablesAccessibilityProvider implements IAccessibilityProvider<IExpression | IScope> {
-
 	getAriaLabel(element: IExpression | IScope): string {
 		if (element instanceof Scope) {
 			return nls.localize('variableScopeAriaLabel', "Scope {0}, variables, debug", element.name);
diff --git a/src/vs/workbench/parts/debug/electron-browser/watchExpressionsView.ts b/src/vs/workbench/parts/debug/electron-browser/watchExpressionsView.ts
index e5f1e5b6f23..b02c2204b80 100644
--- a/src/vs/workbench/parts/debug/electron-browser/watchExpressionsView.ts
+++ b/src/vs/workbench/parts/debug/electron-browser/watchExpressionsView.ts
@@ -195,7 +195,7 @@ class WatchExpressionsDataSource implements IDataSource<IExpression> {
 			return true;
 		}
 
-		return (<IExpression>element).hasChildren;
+		return element.hasChildren;
 	}
 
 	getChildren(element: IExpression | null): Thenable<(IExpression)[]> {
-- 
GitLab