From f063ff93f4a4128e21f4803ee72a38ee41b5d6bb Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Wed, 2 Sep 2020 18:45:59 +0200 Subject: [PATCH] Fix #103238 --- .../workbench/contrib/userDataSync/browser/userDataSync.ts | 5 ++++- .../userDataSync/browser/userDataSyncWorkbenchService.ts | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/userDataSync/browser/userDataSync.ts b/src/vs/workbench/contrib/userDataSync/browser/userDataSync.ts index d8625ab699d..2ef431e97d4 100644 --- a/src/vs/workbench/contrib/userDataSync/browser/userDataSync.ts +++ b/src/vs/workbench/contrib/userDataSync/browser/userDataSync.ts @@ -431,6 +431,9 @@ export class UserDataSyncWorkbenchContribution extends Disposable implements IWo private async turnOn(): Promise { try { + if (!this.userDataSyncWorkbenchService.authenticationProviders.length) { + throw new Error(localize('no authentication providers', "No authentication providers available.")); + } if (!this.storageService.getBoolean('sync.donotAskPreviewConfirmation', StorageScope.GLOBAL, false)) { if (!await this.askForConfirmation()) { return; @@ -478,7 +481,7 @@ export class UserDataSyncWorkbenchContribution extends Disposable implements IWo return; } } - this.notificationService.error(localize('turn on failed', "Error while starting Sync: {0}", toErrorMessage(e))); + this.notificationService.error(localize('turn on failed', "Error while starting Settings Sync: {0}", toErrorMessage(e))); } } diff --git a/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts b/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts index 1da15d98d11..08683bbd249 100644 --- a/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts +++ b/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts @@ -246,6 +246,9 @@ export class UserDataSyncWorkbenchService extends Disposable implements IUserDat } async turnOn(): Promise { + if (!this.authenticationProviders.length) { + throw new Error(localize('no authentication providers', "Settings sync cannot be turned on because there are no authentication providers available.")); + } if (this.userDataAutoSyncService.isEnabled()) { return; } -- GitLab