From ecc72791823257c61127d824652628e73d5f0bf7 Mon Sep 17 00:00:00 2001
From: Matt Bierner <matb@microsoft.com>
Date: Mon, 26 Feb 2018 17:59:50 -0800
Subject: [PATCH] Remove `resourceColumn` logic for markdown previews

Makes dynamic markdown previews always sync to any markdown document that is active instead of only ones that become active in  a specific column. The old behavior became very confusing once you start moving markdown previews about
---
 extensions/markdown/src/features/previewContentProvider.ts | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/extensions/markdown/src/features/previewContentProvider.ts b/extensions/markdown/src/features/previewContentProvider.ts
index cbe08910e2e..5ed47f1d85d 100644
--- a/extensions/markdown/src/features/previewContentProvider.ts
+++ b/extensions/markdown/src/features/previewContentProvider.ts
@@ -292,7 +292,6 @@ class MarkdownPreview {
 
 	constructor(
 		private _resource: vscode.Uri,
-		public resourceColumn: vscode.ViewColumn,
 		previewColumn: vscode.ViewColumn,
 		public readonly pinned: boolean,
 		private readonly contentProvider: MarkdownContentProvider,
@@ -493,7 +492,7 @@ export class MarkdownPreviewManager {
 
 			if (editor && editor.editorType === 'texteditor') {
 				if (isMarkdownFile(editor.document)) {
-					for (const preview of this.previews.filter(preview => !preview.pinned && preview.resourceColumn === editor.viewColumn)) {
+					for (const preview of this.previews.filter(preview => !preview.pinned)) {
 						preview.update(editor.document.uri);
 					}
 				}
@@ -524,10 +523,9 @@ export class MarkdownPreviewManager {
 	): void {
 		let preview = this.getExistingPreview(resource, previewSettings);
 		if (preview) {
-			preview.resourceColumn = previewSettings.resourceColumn;
 			preview.show(previewSettings.previewColumn);
 		} else {
-			preview = new MarkdownPreview(resource, previewSettings.resourceColumn, previewSettings.previewColumn, previewSettings.pinned, this.contentProvider, this.previewConfigurations, this.logger);
+			preview = new MarkdownPreview(resource, previewSettings.previewColumn, previewSettings.pinned, this.contentProvider, this.previewConfigurations, this.logger);
 			preview.onDispose(() => {
 				const existing = this.previews.indexOf(preview!);
 				if (existing >= 0) {
-- 
GitLab