From e90887a7c004b9312f001f77c5b08fcf250c2ddb Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Thu, 27 Sep 2018 15:35:31 +0200 Subject: [PATCH] point macos users failing update to our github link related to #57664 --- src/vs/workbench/parts/update/electron-browser/update.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/update/electron-browser/update.ts b/src/vs/workbench/parts/update/electron-browser/update.ts index d4568c6bbc1..31dcac4387f 100644 --- a/src/vs/workbench/parts/update/electron-browser/update.ts +++ b/src/vs/workbench/parts/update/electron-browser/update.ts @@ -271,6 +271,8 @@ export class UpdateContribution implements IGlobalActivity { this.storageService.remove('update/lastKnownVersion', StorageScope.GLOBAL); this.storageService.remove('update/updateNotificationTime', StorageScope.GLOBAL); } + + this.onError('The application is on a read-only volume. Please move the application and try again. If you\'re on macOS Sierra or later, you\'ll need to move the application out of the Downloads directory. See https://github.com/Squirrel/Squirrel.Mac/issues/182 for more information.'); } private onUpdateStateChange(state: UpdateState): void { @@ -320,7 +322,7 @@ export class UpdateContribution implements IGlobalActivity { } private onError(error: string): void { - error = error.replace(/See (.*) for more information/, 'See [this link]($1) for more information'); + error = error.replace(/See https:\/\/github\.com\/Squirrel\/Squirrel\.Mac\/issues\/182 for more information/, 'See [this link](https://github.com/Microsoft/vscode/issues/7426#issuecomment-425093469) for more information'); this.notificationService.notify({ severity: Severity.Error, -- GitLab