storage - disable automated integrity check for now

src/vs/platform/storage/node/storageService.ts

@@ -198,7 +198,7 @@ export class StorageService extends Disposable implements IStorageService {
 				workspaceItemsParsed.set(key, safeParse(value));
 			});
 
-			console.group(`Storage: Global (check: ${result[2]}, load: ${getDuration('willInitGlobalStorage', 'didInitGlobalStorage')}, path: ${this.globalStorageWorkspacePath})`);
+			console.group(`Storage: Global (integrity: ${result[2]}, load: ${getDuration('willInitGlobalStorage', 'didInitGlobalStorage')}, path: ${this.globalStorageWorkspacePath})`);
 			let globalValues = [];
 			globalItems.forEach((value, key) => {
 				globalValues.push({ key, value });
@@ -208,7 +208,7 @@ export class StorageService extends Disposable implements IStorageService {
 
 			console.log(globalItemsParsed);
 
-			console.group(`Storage: Workspace (check: ${result[3]}, load: ${getDuration('willInitWorkspaceStorage', 'didInitWorkspaceStorage')}, path: ${this.workspaceStoragePath})`);
+			console.group(`Storage: Workspace (integrity: ${result[3]}, load: ${getDuration('willInitWorkspaceStorage', 'didInitWorkspaceStorage')}, path: ${this.workspaceStoragePath})`);
 			let workspaceValues = [];
 			workspaceItems.forEach((value, key) => {
 				workspaceValues.push({ key, value });

src/vs/workbench/electron-browser/shell.ts

@@ -297,8 +297,6 @@ export class WorkbenchShell extends Disposable {
 		const workbenchLoadDuration = perf.getDuration('willLoadWorkbenchMain', 'didLoadWorkbenchMain');
 		const localStorageDuration = perf.getDuration('willReadLocalStorage', 'didReadLocalStorage');
 
-		let workspaceIntegrity = 'unresolved';
-
 		// Handle errors (avoid duplicates to reduce spam)
 		const loggedStorageErrors = new Set<string>();
 		this._register(this.storageService.storage.onStorageError(error => {
@@ -320,7 +318,6 @@ export class WorkbenchShell extends Disposable {
 						"workbenchRequireTime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
 						"workspaceKeys" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
 						"startupKind": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
-						"integrityWorkspace" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
 						"storageError": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
 					}
 				*/
@@ -336,19 +333,11 @@ export class WorkbenchShell extends Disposable {
 					'workbenchRequireTime': workbenchLoadDuration,
 					'workspaceKeys': this.storageService.storage.getSize(StorageScope.WORKSPACE),
 					'startupKind': this.lifecycleService.startupKind,
-					'integrityWorkspace': workspaceIntegrity,
 					'storageError': errorStr
 				});
 			}
 		}));
 
-		perf.mark('willCheckWorkspaceStorageIntegrity');
-		this.storageService.storage.checkIntegrity(StorageScope.WORKSPACE, false).then(integrity => {
-			perf.mark('didCheckWorkspaceStorageIntegrity');
-
-			if (integrity) {
-				workspaceIntegrity = integrity;
-			}
 
 		if (this.storageService.storage.hasErrors) {
 			return; // do not log performance numbers when errors occured
@@ -368,8 +357,6 @@ export class WorkbenchShell extends Disposable {
 				"workspaceSchemaTime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
 				"workspaceReadTime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
 				"localStorageTime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
-					"integrityWorkspace" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
-					"workspaceIntegrityCheckTime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
 				"workbenchRequireTime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
 				"workspaceKeys" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
 				"startupKind": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }
@@ -384,13 +371,10 @@ export class WorkbenchShell extends Disposable {
 			'workspaceSchemaTime': workspaceStorageSchemaDuration,
 			'workspaceReadTime': workspaceStorageInitDuration,
 			'localStorageTime': localStorageDuration,
-				'integrityWorkspace': workspaceIntegrity,
-				'workspaceIntegrityCheckTime': perf.getDuration('willCheckWorkspaceStorageIntegrity', 'didCheckWorkspaceStorageIntegrity'),
 			'workbenchRequireTime': workbenchLoadDuration,
 			'workspaceKeys': this.storageService.storage.getSize(StorageScope.WORKSPACE),
 			'startupKind': this.lifecycleService.startupKind
 		});
-		}, error => errors.onUnexpectedError(error));
 	}
 
 	private initServiceCollection(container: HTMLElement): [IInstantiationService, ServiceCollection] {