From e6f93f30747c081dbf8640a62ef92d52545e52f8 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Thu, 24 Jan 2019 10:56:34 -0800 Subject: [PATCH] Extract isPreferredFix --- .../src/features/quickFix.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/extensions/typescript-language-features/src/features/quickFix.ts b/extensions/typescript-language-features/src/features/quickFix.ts index ec98820c7f5..960e076e590 100644 --- a/extensions/typescript-language-features/src/features/quickFix.ts +++ b/extensions/typescript-language-features/src/features/quickFix.ts @@ -269,9 +269,7 @@ class TypeScriptQuickFixProvider implements vscode.CodeActionProvider { arguments: [tsAction], title: '' }; - if (tsAction.fixName === 'spelling') { - codeAction.isPreferred = true; - } + codeAction.isPreferred = isPreferredFix(tsAction); return codeAction; } @@ -305,6 +303,11 @@ class TypeScriptQuickFixProvider implements vscode.CodeActionProvider { } } +const preferredFixes = new Set(['spelling']); +function isPreferredFix(tsAction: Proto.CodeFixAction): boolean { + return preferredFixes.has(tsAction.fixName); +} + export function register( selector: vscode.DocumentSelector, client: ITypeScriptServiceClient, -- GitLab