From e51139409d8d8c5533376d0f22f6d60c6a687d55 Mon Sep 17 00:00:00 2001
From: Johannes Rieken <johannes.rieken@gmail.com>
Date: Tue, 25 Oct 2016 15:52:23 +0200
Subject: [PATCH] update tests for #13924

---
 .../node/api/extHostLanguageFeatures.test.ts  | 25 ++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/src/vs/workbench/test/node/api/extHostLanguageFeatures.test.ts b/src/vs/workbench/test/node/api/extHostLanguageFeatures.test.ts
index 864d2eb757b..18b8f3667d1 100644
--- a/src/vs/workbench/test/node/api/extHostLanguageFeatures.test.ts
+++ b/src/vs/workbench/test/node/api/extHostLanguageFeatures.test.ts
@@ -743,6 +743,27 @@ suite('ExtHostLanguageFeatures', function () {
 
 	// --- parameter hints
 
+	test('Parameter Hints, order', function () {
+
+		disposables.push(extHost.registerSignatureHelpProvider(defaultSelector, <vscode.SignatureHelpProvider>{
+			provideSignatureHelp(): any {
+				return undefined;
+			}
+		}, []));
+
+		disposables.push(extHost.registerSignatureHelpProvider(defaultSelector, <vscode.SignatureHelpProvider>{
+			provideSignatureHelp(): vscode.SignatureHelp {
+				return new types.SignatureHelp();
+			}
+		}, []));
+
+		return threadService.sync().then(() => {
+
+			return provideSignatureHelp(model, new EditorPosition(1, 1)).then(value => {
+				assert.ok(value);
+			});
+		});
+	});
 	test('Parameter Hints, evil provider', function () {
 
 		disposables.push(extHost.registerSignatureHelpProvider(defaultSelector, <vscode.SignatureHelpProvider>{
@@ -754,9 +775,7 @@ suite('ExtHostLanguageFeatures', function () {
 		return threadService.sync().then(() => {
 
 			return provideSignatureHelp(model, new EditorPosition(1, 1)).then(value => {
-				throw new Error('error expeted');
-			}, err => {
-				assert.equal(err.message, 'evil');
+				assert.equal(value, undefined);
 			});
 		});
 	});
-- 
GitLab