diff --git a/src/vs/workbench/test/node/api/extHostLanguageFeatures.test.ts b/src/vs/workbench/test/node/api/extHostLanguageFeatures.test.ts index 864d2eb757b864e1e0e27b96b756d12164c11285..18b8f3667d17fbef57f776571dad84e8f68c82a6 100644 --- a/src/vs/workbench/test/node/api/extHostLanguageFeatures.test.ts +++ b/src/vs/workbench/test/node/api/extHostLanguageFeatures.test.ts @@ -743,6 +743,27 @@ suite('ExtHostLanguageFeatures', function () { // --- parameter hints + test('Parameter Hints, order', function () { + + disposables.push(extHost.registerSignatureHelpProvider(defaultSelector, { + provideSignatureHelp(): any { + return undefined; + } + }, [])); + + disposables.push(extHost.registerSignatureHelpProvider(defaultSelector, { + provideSignatureHelp(): vscode.SignatureHelp { + return new types.SignatureHelp(); + } + }, [])); + + return threadService.sync().then(() => { + + return provideSignatureHelp(model, new EditorPosition(1, 1)).then(value => { + assert.ok(value); + }); + }); + }); test('Parameter Hints, evil provider', function () { disposables.push(extHost.registerSignatureHelpProvider(defaultSelector, { @@ -754,9 +775,7 @@ suite('ExtHostLanguageFeatures', function () { return threadService.sync().then(() => { return provideSignatureHelp(model, new EditorPosition(1, 1)).then(value => { - throw new Error('error expeted'); - }, err => { - assert.equal(err.message, 'evil'); + assert.equal(value, undefined); }); }); });