From e429fc386e9a202c1a1471b3184b972152dc8ffb Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Tue, 8 Sep 2020 20:10:28 +0200 Subject: [PATCH] remove `NotebookDocument#displayOrder` , fixes https://github.com/microsoft/vscode/issues/106305 --- src/vs/vscode.proposed.d.ts | 1 - src/vs/workbench/api/common/extHostNotebook.ts | 3 --- 2 files changed, 4 deletions(-) diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index 676798f8e07..b0b5547fa83 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -1327,7 +1327,6 @@ declare module 'vscode' { readonly isUntitled: boolean; readonly cells: ReadonlyArray; languages: string[]; - displayOrder?: GlobPattern[]; metadata: NotebookDocumentMetadata; } diff --git a/src/vs/workbench/api/common/extHostNotebook.ts b/src/vs/workbench/api/common/extHostNotebook.ts index 46835b397b7..6998c475a7e 100644 --- a/src/vs/workbench/api/common/extHostNotebook.ts +++ b/src/vs/workbench/api/common/extHostNotebook.ts @@ -215,7 +215,6 @@ export class ExtHostNotebookDocument extends Disposable { private _metadata: Required = notebookDocumentMetadataDefaults; private _metadataChangeListener: IDisposable; - private _displayOrder: string[] = []; private _versionId = 0; private _isDirty: boolean = false; private _backupCounter = 1; @@ -284,8 +283,6 @@ export class ExtHostNotebookDocument extends Disposable { get cells(): ReadonlyArray { return that._cells.map(cell => cell.cell); }, get languages() { return that._languages; }, set languages(value: string[]) { that._trySetLanguages(value); }, - get displayOrder() { return that._displayOrder; }, - set displayOrder(value: string[]) { that._displayOrder = value; }, get metadata() { return that._metadata; }, set metadata(value: Required) { that._updateMetadata(value); }, }); -- GitLab