Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
dc744d61
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
dc744d61
编写于
4月 21, 2020
作者:
R
rebornix
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Restore focus after moving cells or deleting cells.
上级
2e7e1311
变更
4
显示空白变更内容
内联
并排
Showing
4 changed file
with
38 addition
and
23 deletion
+38
-23
src/vs/workbench/contrib/notebook/browser/contrib/notebookActions.ts
...bench/contrib/notebook/browser/contrib/notebookActions.ts
+17
-3
src/vs/workbench/contrib/notebook/browser/notebookBrowser.ts
src/vs/workbench/contrib/notebook/browser/notebookBrowser.ts
+4
-4
src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
+12
-11
src/vs/workbench/contrib/notebook/test/testNotebookEditor.ts
src/vs/workbench/contrib/notebook/test/testNotebookEditor.ts
+5
-5
未找到文件。
src/vs/workbench/contrib/notebook/browser/contrib/notebookActions.ts
浏览文件 @
dc744d61
...
...
@@ -697,7 +697,7 @@ registerAction2(class extends Action2 {
});
}
run
(
accessor
:
ServicesAccessor
,
context
?:
INotebookCellActionContext
)
{
async
run
(
accessor
:
ServicesAccessor
,
context
?:
INotebookCellActionContext
)
{
if
(
!
isCellActionContext
(
context
))
{
context
=
getActiveCellContext
(
accessor
);
if
(
!
context
)
{
...
...
@@ -705,14 +705,28 @@ registerAction2(class extends Action2 {
}
}
return
context
.
notebookEditor
.
deleteNotebookCell
(
context
.
cell
);
const
index
=
context
.
notebookEditor
.
viewModel
!
.
getCellIndex
(
context
.
cell
);
const
result
=
await
context
.
notebookEditor
.
deleteNotebookCell
(
context
.
cell
);
if
(
result
)
{
// deletion succeeds, move focus to the next cell
if
(
index
<
context
.
notebookEditor
.
viewModel
!
.
length
)
{
context
.
notebookEditor
.
focusNotebookCell
(
context
.
notebookEditor
.
viewModel
!
.
viewCells
[
index
],
false
);
}
}
}
});
async
function
moveCell
(
context
:
INotebookCellActionContext
,
direction
:
'
up
'
|
'
down
'
):
Promise
<
void
>
{
direction
===
'
up
'
?
const
result
=
direction
===
'
up
'
?
context
.
notebookEditor
.
moveCellUp
(
context
.
cell
)
:
context
.
notebookEditor
.
moveCellDown
(
context
.
cell
);
if
(
result
)
{
// move cell command only works when the cell container has focus
context
.
notebookEditor
.
focusNotebookCell
(
context
.
cell
,
false
);
}
}
async
function
copyCell
(
context
:
INotebookCellActionContext
,
direction
:
'
up
'
|
'
down
'
):
Promise
<
void
>
{
...
...
src/vs/workbench/contrib/notebook/browser/notebookBrowser.ts
浏览文件 @
dc744d61
...
...
@@ -134,22 +134,22 @@ export interface INotebookEditor {
/**
* Delete a cell from the notebook
*/
deleteNotebookCell
(
cell
:
ICellViewModel
):
void
;
deleteNotebookCell
(
cell
:
ICellViewModel
):
Promise
<
boolean
>
;
/**
* Move a cell up one spot
*/
moveCellUp
(
cell
:
ICellViewModel
):
void
;
moveCellUp
(
cell
:
ICellViewModel
):
Promise
<
boolean
>
;
/**
* Move a cell down one spot
*/
moveCellDown
(
cell
:
ICellViewModel
):
void
;
moveCellDown
(
cell
:
ICellViewModel
):
Promise
<
boolean
>
;
/**
* Move a cell above or below another cell
*/
moveCell
(
cell
:
ICellViewModel
,
relativeToCell
:
ICellViewModel
,
direction
:
'
above
'
|
'
below
'
):
Promise
<
void
>
;
moveCell
(
cell
:
ICellViewModel
,
relativeToCell
:
ICellViewModel
,
direction
:
'
above
'
|
'
below
'
):
Promise
<
boolean
>
;
/**
* Switch the cell into editing mode.
...
...
src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
浏览文件 @
dc744d61
...
...
@@ -675,35 +675,36 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
return
new
Promise
(
resolve
=>
{
r
=
resolve
;
});
}
async
deleteNotebookCell
(
cell
:
ICellViewModel
):
Promise
<
void
>
{
async
deleteNotebookCell
(
cell
:
ICellViewModel
):
Promise
<
boolean
>
{
(
cell
as
CellViewModel
).
save
();
const
index
=
this
.
notebookViewModel
!
.
getCellIndex
(
cell
);
this
.
notebookViewModel
!
.
deleteCell
(
index
,
true
);
return
true
;
}
async
moveCellDown
(
cell
:
ICellViewModel
):
Promise
<
void
>
{
async
moveCellDown
(
cell
:
ICellViewModel
):
Promise
<
boolean
>
{
const
index
=
this
.
notebookViewModel
!
.
getCellIndex
(
cell
);
if
(
index
===
this
.
notebookViewModel
!
.
length
-
1
)
{
return
;
return
false
;
}
const
newIdx
=
index
+
1
;
return
this
.
moveCellToIndex
(
index
,
newIdx
);
}
async
moveCellUp
(
cell
:
ICellViewModel
):
Promise
<
void
>
{
async
moveCellUp
(
cell
:
ICellViewModel
):
Promise
<
boolean
>
{
const
index
=
this
.
notebookViewModel
!
.
getCellIndex
(
cell
);
if
(
index
===
0
)
{
return
;
return
false
;
}
const
newIdx
=
index
-
1
;
return
this
.
moveCellToIndex
(
index
,
newIdx
);
}
async
moveCell
(
cell
:
ICellViewModel
,
relativeToCell
:
ICellViewModel
,
direction
:
'
above
'
|
'
below
'
):
Promise
<
void
>
{
async
moveCell
(
cell
:
ICellViewModel
,
relativeToCell
:
ICellViewModel
,
direction
:
'
above
'
|
'
below
'
):
Promise
<
boolean
>
{
if
(
cell
===
relativeToCell
)
{
return
;
return
false
;
}
const
originalIdx
=
this
.
notebookViewModel
!
.
getCellIndex
(
cell
);
...
...
@@ -713,15 +714,15 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
return
this
.
moveCellToIndex
(
originalIdx
,
newIdx
);
}
private
async
moveCellToIndex
(
index
:
number
,
newIdx
:
number
):
Promise
<
void
>
{
private
async
moveCellToIndex
(
index
:
number
,
newIdx
:
number
):
Promise
<
boolean
>
{
if
(
!
this
.
notebookViewModel
!
.
moveCellToIdx
(
index
,
newIdx
,
true
))
{
return
;
throw
new
Error
(
'
Notebook Editor move cell, index out of range
'
)
;
}
let
r
:
()
=>
void
;
let
r
:
(
val
:
boolean
)
=>
void
;
DOM
.
scheduleAtNextAnimationFrame
(()
=>
{
this
.
list
?.
revealElementInView
(
this
.
notebookViewModel
!
.
viewCells
[
newIdx
]);
r
();
r
(
true
);
});
return
new
Promise
(
resolve
=>
{
r
=
resolve
;
});
...
...
src/vs/workbench/contrib/notebook/test/testNotebookEditor.ts
浏览文件 @
dc744d61
...
...
@@ -95,15 +95,15 @@ export class TestNotebookEditor implements INotebookEditor {
throw
new
Error
(
'
Method not implemented.
'
);
}
moveCellDown
(
cell
:
CellViewModel
):
void
{
moveCellDown
(
cell
:
CellViewModel
):
Promise
<
boolean
>
{
throw
new
Error
(
'
Method not implemented.
'
);
}
moveCellUp
(
cell
:
CellViewModel
):
void
{
moveCellUp
(
cell
:
CellViewModel
):
Promise
<
boolean
>
{
throw
new
Error
(
'
Method not implemented.
'
);
}
moveCell
(
cell
:
ICellViewModel
,
relativeToCell
:
ICellViewModel
,
direction
:
'
above
'
|
'
below
'
):
Promise
<
void
>
{
moveCell
(
cell
:
ICellViewModel
,
relativeToCell
:
ICellViewModel
,
direction
:
'
above
'
|
'
below
'
):
Promise
<
boolean
>
{
throw
new
Error
(
'
Method not implemented.
'
);
}
...
...
@@ -153,8 +153,8 @@ export class TestNotebookEditor implements INotebookEditor {
async
insertNotebookCell
(
cell
:
CellViewModel
,
type
:
CellKind
,
direction
:
'
above
'
|
'
below
'
):
Promise
<
CellViewModel
>
{
throw
new
Error
(
'
Method not implemented.
'
);
}
deleteNotebookCell
(
cell
:
CellViewModel
):
void
{
//
throw new Error('Method not implemented.');
deleteNotebookCell
(
cell
:
CellViewModel
):
Promise
<
boolean
>
{
throw
new
Error
(
'
Method not implemented.
'
);
}
editNotebookCell
(
cell
:
CellViewModel
):
void
{
// throw new Error('Method not implemented.');
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录