提交 d9e6741a 编写于 作者: R Rob Lourens

Fix #67073 - hide fancy selectbox when scrolling settings

上级 aad260bc
...@@ -605,9 +605,9 @@ export class SettingsEditor2 extends BaseEditor { ...@@ -605,9 +605,9 @@ export class SettingsEditor2 extends BaseEditor {
this.settingRenderers.allRenderers)); this.settingRenderers.allRenderers));
this.settingsTree.getHTMLElement().attributes.removeNamedItem('tabindex'); this.settingsTree.getHTMLElement().attributes.removeNamedItem('tabindex');
// this._register(this.settingsTree.onDidScroll(() => { this._register(this.settingsTree.onDidScroll(() => {
// this.updateTreeScrollSync(); this.updateTreeScrollSync();
// })); }));
} }
private notifyNoSaveNeeded() { private notifyNoSaveNeeded() {
...@@ -644,13 +644,13 @@ export class SettingsEditor2 extends BaseEditor { ...@@ -644,13 +644,13 @@ export class SettingsEditor2 extends BaseEditor {
// this.updateTreePagingByScroll(); // this.updateTreePagingByScroll();
const element = this.tocTreeModel.children[0]; // const element = this.tocTreeModel.children[0];
// const elementToSync = this.settingsTree.getFirstVisibleElement(); // const elementToSync = this.settingsTree.getFirstVisibleElement();
// const element = elementToSync instanceof SettingsTreeSettingElement ? elementToSync.parent : // const element = elementToSync instanceof SettingsTreeSettingElement ? elementToSync.parent :
// elementToSync instanceof SettingsTreeGroupElement ? elementToSync : // elementToSync instanceof SettingsTreeGroupElement ? elementToSync :
// null; // null;
if (element && this.tocTree.getSelection()[0] !== element) { // if (element && this.tocTree.getSelection()[0] !== element) {
// this.tocTree.reveal(element); // this.tocTree.reveal(element);
// const elementTop = this.tocTree.getRelativeTop(element); // const elementTop = this.tocTree.getRelativeTop(element);
// collapseAll(this.tocTree, element); // collapseAll(this.tocTree, element);
...@@ -664,15 +664,8 @@ export class SettingsEditor2 extends BaseEditor { ...@@ -664,15 +664,8 @@ export class SettingsEditor2 extends BaseEditor {
// this.tocTree.setSelection([element]); // this.tocTree.setSelection([element]);
// this.tocTree.setFocus(element, { fromScroll: true }); // this.tocTree.setFocus(element, { fromScroll: true });
}
}
// private updateTreePagingByScroll(): void {
// const lastVisibleElement = this.settingsTree.getLastVisibleElement();
// if (lastVisibleElement && this.settingsTreeDataSource.pageTo(lastVisibleElement.index)) {
// this.renderTree();
// }
// } // }
}
private updateChangedSetting(key: string, value: any): Promise<void> { private updateChangedSetting(key: string, value: any): Promise<void> {
// ConfigurationService displays the error if this fails. // ConfigurationService displays the error if this fails.
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册