From d93221d7d5bf30b3161a230909c3c85191139574 Mon Sep 17 00:00:00 2001
From: Daniel Imms <daimms@microsoft.com>
Date: Mon, 4 Mar 2019 16:07:52 -0800
Subject: [PATCH] Strict null check contrib/terminal

Fixes #69686
---
 .../contrib/terminal/common/terminal.ts       |  2 +-
 .../terminal/common/terminalService.ts        |  2 +-
 .../electron-browser/terminalService.ts       | 19 +++++++++++--------
 3 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/src/vs/workbench/contrib/terminal/common/terminal.ts b/src/vs/workbench/contrib/terminal/common/terminal.ts
index d36b3cbeae3..5673030976d 100644
--- a/src/vs/workbench/contrib/terminal/common/terminal.ts
+++ b/src/vs/workbench/contrib/terminal/common/terminal.ts
@@ -251,7 +251,7 @@ export interface ITerminalService {
 	findPrevious(): void;
 
 	setContainers(panelContainer: HTMLElement, terminalContainer: HTMLElement): void;
-	selectDefaultWindowsShell(): Promise<string>;
+	selectDefaultWindowsShell(): Promise<string | undefined>;
 	setWorkspaceShellAllowed(isAllowed: boolean): void;
 
 	requestExtHostProcess(proxy: ITerminalProcessExtHostProxy, shellLaunchConfig: IShellLaunchConfig, activeWorkspaceRootUri: URI, cols: number, rows: number): void;
diff --git a/src/vs/workbench/contrib/terminal/common/terminalService.ts b/src/vs/workbench/contrib/terminal/common/terminalService.ts
index 2af5a375481..ab539243fc7 100644
--- a/src/vs/workbench/contrib/terminal/common/terminalService.ts
+++ b/src/vs/workbench/contrib/terminal/common/terminalService.ts
@@ -92,7 +92,7 @@ export abstract class TerminalService implements ITerminalService {
 	public abstract createTerminalRenderer(name: string): ITerminalInstance;
 	public abstract createInstance(terminalFocusContextKey: IContextKey<boolean>, configHelper: ITerminalConfigHelper, container: HTMLElement, shellLaunchConfig: IShellLaunchConfig, doCreateProcess: boolean): ITerminalInstance;
 	public abstract getActiveOrCreateInstance(wasNewTerminalAction?: boolean): ITerminalInstance;
-	public abstract selectDefaultWindowsShell(): Promise<string>;
+	public abstract selectDefaultWindowsShell(): Promise<string | undefined>;
 	public abstract setContainers(panelContainer: HTMLElement, terminalContainer: HTMLElement): void;
 	public abstract requestExtHostProcess(proxy: ITerminalProcessExtHostProxy, shellLaunchConfig: IShellLaunchConfig, activeWorkspaceRootUri: URI, cols: number, rows: number): void;
 
diff --git a/src/vs/workbench/contrib/terminal/electron-browser/terminalService.ts b/src/vs/workbench/contrib/terminal/electron-browser/terminalService.ts
index fbace8ec6fb..fcbd99a09b3 100644
--- a/src/vs/workbench/contrib/terminal/electron-browser/terminalService.ts
+++ b/src/vs/workbench/contrib/terminal/electron-browser/terminalService.ts
@@ -64,7 +64,10 @@ export class TerminalService extends AbstractTerminalService implements ITermina
 			if (request.termProgram === 'vscode' && request.filesToWait) {
 				pfs.whenDeleted(request.filesToWait.waitMarkerFilePath).then(() => {
 					if (this.terminalInstances.length > 0) {
-						this.getActiveInstance().focus();
+						const terminal = this.getActiveInstance();
+						if (terminal) {
+							terminal.focus();
+						}
 					}
 				});
 			}
@@ -215,14 +218,14 @@ export class TerminalService extends AbstractTerminalService implements ITermina
 		);
 	}
 
-	public selectDefaultWindowsShell(): Promise<string> {
+	public selectDefaultWindowsShell(): Promise<string | undefined> {
 		return this._detectWindowsShells().then(shells => {
 			const options: IPickOptions<IQuickPickItem> = {
 				placeHolder: nls.localize('terminal.integrated.chooseWindowsShell', "Select your preferred terminal shell, you can change this later in your settings")
 			};
 			return this._quickInputService.pick(shells, options).then(value => {
 				if (!value) {
-					return null;
+					return undefined;
 				}
 				const shell = value.description;
 				return this._configurationService.updateValue('terminal.integrated.shell.windows', shell, ConfigurationTarget.USER).then(() => shell);
@@ -270,13 +273,13 @@ export class TerminalService extends AbstractTerminalService implements ITermina
 			});
 	}
 
-	private _validateShellPaths(label: string, potentialPaths: string[]): Promise<[string, string]> {
+	private _validateShellPaths(label: string, potentialPaths: string[]): Promise<[string, string] | null> {
+		if (potentialPaths.length === 0) {
+			return Promise.resolve(null);
+		}
 		const current = potentialPaths.shift();
-		return pfs.fileExists(current).then(exists => {
+		return pfs.fileExists(current!).then(exists => {
 			if (!exists) {
-				if (potentialPaths.length === 0) {
-					return null;
-				}
 				return this._validateShellPaths(label, potentialPaths);
 			}
 			return [label, current] as [string, string];
-- 
GitLab