From d8feb77a065a7532c5d96be93578a577cbcc5891 Mon Sep 17 00:00:00 2001 From: isidor Date: Thu, 19 Jul 2018 11:36:56 +0200 Subject: [PATCH] list: do not steal focus for hidden elements (properly get style) --- src/vs/base/browser/ui/list/listWidget.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/base/browser/ui/list/listWidget.ts b/src/vs/base/browser/ui/list/listWidget.ts index 9b7be4b18e8..8ac00184f28 100644 --- a/src/vs/base/browser/ui/list/listWidget.ts +++ b/src/vs/base/browser/ui/list/listWidget.ts @@ -351,8 +351,9 @@ class DOMFocusController implements IDisposable { const focusedDomElement = this.view.domElement(focus[0]); const tabIndexElement = focusedDomElement.querySelector('[tabIndex]'); + const style = tabIndexElement && window.getComputedStyle(tabIndexElement); - if (!tabIndexElement || !(tabIndexElement instanceof HTMLElement) || tabIndexElement.style.visibility === 'hidden' || tabIndexElement.style.display === 'none') { + if (!tabIndexElement || !(tabIndexElement instanceof HTMLElement) || style.visibility === 'hidden' || style.display === 'none') { return; } -- GitLab