From d8ea9d9dcd008097ddc6565ed16c3478687a4e11 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 20 Mar 2019 10:50:03 -0700 Subject: [PATCH] Fix null check in terminal --- .../workbench/contrib/terminal/browser/terminalInstance.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index 6b744c7b073..e7e23ed4ff0 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -762,7 +762,11 @@ export class TerminalInstance implements ITerminalInstance { if (!this._xterm) { return; } - const text = window.getSelection().toString(); + const selection = window.getSelection(); + if (!selection) { + return; + } + const text = selection.toString(); if (!text || force) { this._xterm.focus(); } -- GitLab